Commit 333fd216 authored by antirez's avatar antirez
Browse files

TODO change and minor SETNX optimization

parent 231d758e
...@@ -6,7 +6,6 @@ VERSION 1.2 TODO (Zsets, Integer encoding, Append only journal) ...@@ -6,7 +6,6 @@ VERSION 1.2 TODO (Zsets, Integer encoding, Append only journal)
Most of the features already implemented for this release. The following is a list of the missing things in order to release the first beta tar.gz: Most of the features already implemented for this release. The following is a list of the missing things in order to release the first beta tar.gz:
* Document "masterauth" in redis.conf, also merge the other related patch if it seems a safe one. * Document "masterauth" in redis.conf, also merge the other related patch if it seems a safe one.
* SETNX and MSETNX should use lookupKeWrite() in order to expire volatile keys when a write attempt is made.
VERSION 1.4 TODO (Hash type) VERSION 1.4 TODO (Hash type)
============================ ============================
......
...@@ -2979,7 +2979,7 @@ static void echoCommand(redisClient *c) { ...@@ -2979,7 +2979,7 @@ static void echoCommand(redisClient *c) {
static void setGenericCommand(redisClient *c, int nx) { static void setGenericCommand(redisClient *c, int nx) {
int retval; int retval;
deleteIfVolatile(c->db,c->argv[1]); if (nx) deleteIfVolatile(c->db,c->argv[1]);
retval = dictAdd(c->db->dict,c->argv[1],c->argv[2]); retval = dictAdd(c->db->dict,c->argv[1],c->argv[2]);
if (retval == DICT_ERR) { if (retval == DICT_ERR) {
if (!nx) { if (!nx) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment