Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
333fd216
Commit
333fd216
authored
Dec 10, 2009
by
antirez
Browse files
TODO change and minor SETNX optimization
parent
231d758e
Changes
2
Hide whitespace changes
Inline
Side-by-side
TODO
View file @
333fd216
...
@@ -6,7 +6,6 @@ VERSION 1.2 TODO (Zsets, Integer encoding, Append only journal)
...
@@ -6,7 +6,6 @@ VERSION 1.2 TODO (Zsets, Integer encoding, Append only journal)
Most of the features already implemented for this release. The following is a list of the missing things in order to release the first beta tar.gz:
Most of the features already implemented for this release. The following is a list of the missing things in order to release the first beta tar.gz:
* Document "masterauth" in redis.conf, also merge the other related patch if it seems a safe one.
* Document "masterauth" in redis.conf, also merge the other related patch if it seems a safe one.
* SETNX and MSETNX should use lookupKeWrite() in order to expire volatile keys when a write attempt is made.
VERSION 1.4 TODO (Hash type)
VERSION 1.4 TODO (Hash type)
============================
============================
...
...
redis.c
View file @
333fd216
...
@@ -2979,7 +2979,7 @@ static void echoCommand(redisClient *c) {
...
@@ -2979,7 +2979,7 @@ static void echoCommand(redisClient *c) {
static
void
setGenericCommand
(
redisClient
*
c
,
int
nx
)
{
static
void
setGenericCommand
(
redisClient
*
c
,
int
nx
)
{
int
retval
;
int
retval
;
deleteIfVolatile
(
c
->
db
,
c
->
argv
[
1
]);
if
(
nx
)
deleteIfVolatile
(
c
->
db
,
c
->
argv
[
1
]);
retval
=
dictAdd
(
c
->
db
->
dict
,
c
->
argv
[
1
],
c
->
argv
[
2
]);
retval
=
dictAdd
(
c
->
db
->
dict
,
c
->
argv
[
1
],
c
->
argv
[
2
]);
if
(
retval
==
DICT_ERR
)
{
if
(
retval
==
DICT_ERR
)
{
if
(
!
nx
)
{
if
(
!
nx
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment