Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
3f399c3b
Commit
3f399c3b
authored
Oct 18, 2018
by
youjiali1995
Committed by
antirez
Oct 22, 2018
Browse files
migrate: fix mismatch of RESTORE reply when some keys have expired.
parent
eaaff621
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/cluster.c
View file @
3f399c3b
...
...
@@ -5164,10 +5164,10 @@ try_again:
serverAssertWithInfo
(
c
,
NULL
,
rioWriteBulkLongLong
(
&
cmd
,
dbid
));
}
int
expired
=
0
;
/* Number of keys that we'll find
already
expired.
Note that serializing large keys may take some time
so certain keys that were found non expired by the
lookupKey() function, may be expired later. */
int
non_
expired
=
0
;
/* Number of keys that we'll find
non
expired.
Note that serializing large keys may take some time
so certain keys that were found non expired by the
lookupKey() function, may be expired later. */
/* Create RESTORE payload and generate the protocol to call the command. */
for
(
j
=
0
;
j
<
num_keys
;
j
++
)
{
...
...
@@ -5177,11 +5177,12 @@ try_again:
if
(
expireat
!=
-
1
)
{
ttl
=
expireat
-
mstime
();
if
(
ttl
<
0
)
{
expired
++
;
continue
;
}
if
(
ttl
<
1
)
ttl
=
1
;
}
kv
[
non_expired
++
]
=
kv
[
j
];
serverAssertWithInfo
(
c
,
NULL
,
rioWriteBulkCount
(
&
cmd
,
'*'
,
replace
?
5
:
4
));
...
...
@@ -5208,6 +5209,7 @@ try_again:
if
(
replace
)
serverAssertWithInfo
(
c
,
NULL
,
rioWriteBulkString
(
&
cmd
,
"REPLACE"
,
7
));
}
num_keys
=
non_expired
;
/* Transfer the query to the other node in 64K chunks. */
errno
=
0
;
...
...
@@ -5250,7 +5252,7 @@ try_again:
* command name itself. */
if
(
!
copy
)
newargv
=
zmalloc
(
sizeof
(
robj
*
)
*
(
num_keys
+
1
));
for
(
j
=
0
;
j
<
num_keys
-
expired
;
j
++
)
{
for
(
j
=
0
;
j
<
num_keys
;
j
++
)
{
if
(
syncReadLine
(
cs
->
fd
,
buf2
,
sizeof
(
buf2
),
timeout
)
<=
0
)
{
socket_error
=
1
;
break
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment