Unverified Commit 4ba47d2d authored by guybe7's avatar guybe7 Committed by GitHub
Browse files

Add reply_schema to command json files (internal for now) (#10273)

Work in progress towards implementing a reply schema as part of COMMAND DOCS, see #9845
Since ironing the details of the reply schema of each and every command can take a long time, we
would like to merge this PR when the infrastructure is ready, and let this mature in the unstable branch.
Meanwhile the changes of this PR are internal, they are part of the repo, but do not affect the produced build.

### Background
In #9656 we add a lot of information about Redis commands, but we are missing information about the replies

### Motivation
1. Documentation. This is the primary goal.
2. It should be possible, based on the output of COMMAND, to be able to generate client code in typed
  languages. In order to do that, we need Redis to tell us, in detail, what each reply looks like.
3. We would like to build a fuzzer that verifies the reply structure (for now we use the existing
  testsuite, see the "Testing" section)

### Schema
The idea is to supply some sort of schema for the various replies of each command.
The schema will describe the conceptual structure of the reply (for generated clients), as defined in RESP3.
Note that the reply structure itself may change, depending on the arguments (e.g. `XINFO STREAM`, with
and without the `FULL` modifier)
We decided to use the standard json-schema (see https://json-schema.org/) as the reply-schema.

Example for `BZPOPMIN`:
```
"reply_schema": {
    "oneOf": [
        {
            "description": "Timeout reached and no elements were popped.",
            "type": "null"
        },
        {
            "description": "The keyname, popped member, and its score.",
            "type": "array",
            "minItems": 3,
            "maxItems": 3,
            "items": [
                {
                    "description": "Keyname",
                    "type": "string"
                },
                {
                    "description": "Member",
                    "type": "string"
                },
                {
                    "description": "Score",
                    "type": "number"
                }
            ]
        }
    ]
}
```

#### Notes
1.  It is ok that some commands' reply structure depends on the arguments and it's the caller's responsibility
  to know which is the relevant one. this comes after looking at other request-reply systems like OpenAPI,
  where the reply schema can also be oneOf and the caller is responsible to know which schema is the relevant one.
2. The reply schemas will describe RESP3 replies only. even though RESP3 is structured, we want to use reply
  schema for documentation (and possibly to create a fuzzer that validates the replies)
3. For documentation, the description field will include an explanation of the scenario in which the reply is sent,
  including any relation to arguments. for example, for `ZRANGE`'s two schemas we will need to state that one
  is with `WITHSCORES` and the other is without.
4. For documentation, there will be another optional field "notes" in which we will add a short description of
  the representation in RESP2, in case it's not trivial (RESP3's `ZRANGE`'s nested array vs. RESP2's flat
  array, for example)

Given the above:
1. We can generate the "return" section of all commands in [redis-doc](https://redis.io/commands/)
  (given that "description" and "notes" are comprehensive enough)
2. We can generate a client in a strongly typed language (but the return type could be a conceptual
  `union` and the caller needs to know which schema is relevant). see the section below for RESP2 support.
3. We can create a fuzzer for RESP3.

### Limitations (because we are using the standard json-schema)
The problem is that Redis' replies are more diverse than what the json format allows. This means that,
when we convert the reply to a json (in order to validate the schema against it), we lose information (see
the "Testing" section below).
The other option would have been to extend the standard json-schema (and json format) to include stuff
like sets, bulk-strings, error-string, etc. but that would mean also extending the schema-validator - and that
seemed like too much work, so we decided to compromise.

Examples:
1. We cannot tell the difference between an "array" and a "set"
2. We cannot tell the difference between simple-string and bulk-string
3. we cannot verify true uniqueness of items in commands like ZRANGE: json-schema doesn't cover the
  case of two identical members with different scores (e.g. `[["m1",6],["m1",7]]`) because `uniqueItems`
  compares (member,score) tuples and not just the member name. 

### Testing
This commit includes some changes inside Redis in order to verify the schemas (existing and future ones)
are indeed correct (i.e. describe the actual response of Redis).
To do that, we added a debugging feature to Redis that causes it to produce a log of all the commands
it executed and their replies.
For that, Redis needs to be compiled with `-DLOG_REQ_RES` and run with
`--reg-res-logfile <file> --client-default-resp 3` (the testsuite already does that if you run it with
`--log-req-res --force-resp3`)
You should run the testsuite with the above args (and `--dont-clean`) in order to make Redis generate
`.reqres` files (same dir as the `stdout` files) which contain request-response pairs.
These files are later on processed by `./utils/req-res-log-validator.py` which does:
1. Goes over req-res files, generated by redis-servers, spawned by the testsuite (see logreqres.c)
2. For each request-response pair, it validates the response against the request's reply_schema
  (obtained from the extended COMMAND DOCS)
5. In order to get good coverage of the Redis commands, and all their different replies, we chose to use
  the existing redis test suite, rather than attempt to write a fuzzer.

#### Notes about RESP2
1. We will not be able to use the testing tool to verify RESP2 replies (we are ok with that, it's time to
  accept RESP3 as the future RESP)
2. Since the majority of the test suite is using RESP2, and we want the server to reply with RESP3
  so that we can validate it, we will need to know how to convert the actual reply to the one expected.
   - number and boolean are always strings in RESP2 so the conversion is easy
   - objects (maps) are always a flat array in RESP2
   - others (nested array in RESP3's `ZRANGE` and others) will need some special per-command
     handling (so the client will not be totally auto-generated)

Example for ZRANGE:
```
"reply_schema": {
    "anyOf": [
        {
            "description": "A list of member elements",
            "type": "array",
            "uniqueItems": true,
            "items": {
                "type": "string"
            }
        },
        {
            "description": "Members and their scores. Returned in case `WITHSCORES` was used.",
            "notes": "In RESP2 this is returned as a flat array",
            "type": "array",
            "uniqueItems": true,
            "items": {
                "type": "array",
                "minItems": 2,
                "maxItems": 2,
                "items": [
                    {
                        "description": "Member",
                        "type": "string"
                    },
                    {
                        "description": "Score",
                        "type": "number"
                    }
                ]
            }
        }
    ]
}
```

### Other changes
1. Some tests that behave differently depending on the RESP are now being tested for both RESP,
  regardless of the special log-req-res mode ("Pub/Sub PING" for example)
2. Update the history field of CLIENT LIST
3. Added basic tests for commands that were not covered at all by the testsuite

### TODO

- [x] (maybe a different PR) add a "condition" field to anyOf/oneOf schemas that refers to args. e.g.
  when `SET` return NULL, the condition is `arguments.get||arguments.condition`, for `OK` the condition
  is `!arguments.get`, and for `string` the condition is `arguments.get` - https://github.com/redis/redis/issues/11896
- [x] (maybe a different PR) also run `runtest-cluster` in the req-res logging mode
- [x] add the new tests to GH actions (i.e. compile with `-DLOG_REQ_RES`, run the tests, and run the validator)
- [x] (maybe a different PR) figure out a way to warn about (sub)schemas that are uncovered by the output
  of the tests - https://github.com/redis/redis/issues/11897
- [x] (probably a separate PR) add all missing schemas
- [x] check why "SDOWN is triggered by misconfigured instance replying with errors" fails with --log-req-res
- [x] move the response transformers to their own file (run both regular, cluster, and sentinel tests - need to
  fight with the tcl including mechanism a bit)
- [x] issue: module API - https://github.com/redis/redis/issues/11898
- [x] (probably a separate PR): improve schemas: add `required` to `object`s - https://github.com/redis/redis/issues/11899

Co-authored-by: default avatarOzan Tezcan <ozantezcan@gmail.com>
Co-authored-by: default avatarHanna Fadida <hanna.fadida@redislabs.com>
Co-authored-by: default avatarOran Agra <oran@redislabs.com>
Co-authored-by: default avatarShaya Potter <shaya@redislabs.com>
parent c46d68d6
...@@ -75,3 +75,4 @@ jobs: ...@@ -75,3 +75,4 @@ jobs:
run: | run: |
yum -y install gcc make yum -y install gcc make
make REDIS_CFLAGS='-Werror' make REDIS_CFLAGS='-Werror'
...@@ -11,7 +11,7 @@ on: ...@@ -11,7 +11,7 @@ on:
inputs: inputs:
skipjobs: skipjobs:
description: 'jobs to skip (delete the ones you wanna keep, do not leave empty)' description: 'jobs to skip (delete the ones you wanna keep, do not leave empty)'
default: 'valgrind,sanitizer,tls,freebsd,macos,alpine,32bit,iothreads,ubuntu,centos,malloc,specific' default: 'valgrind,sanitizer,tls,freebsd,macos,alpine,32bit,iothreads,ubuntu,centos,malloc,specific,reply-schema'
skiptests: skiptests:
description: 'tests to skip (delete the ones you wanna keep, do not leave empty)' description: 'tests to skip (delete the ones you wanna keep, do not leave empty)'
default: 'redis,modules,sentinel,cluster,unittest' default: 'redis,modules,sentinel,cluster,unittest'
...@@ -898,3 +898,44 @@ jobs: ...@@ -898,3 +898,44 @@ jobs:
- name: cluster tests - name: cluster tests
if: true && !contains(github.event.inputs.skiptests, 'cluster') if: true && !contains(github.event.inputs.skiptests, 'cluster')
run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}} run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
reply-schemas-validator:
runs-on: ubuntu-latest
timeout-minutes: 14400
if: |
(github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) &&
!contains(github.event.inputs.skipjobs, 'reply-schema')
steps:
- name: prep
if: github.event_name == 'workflow_dispatch'
run: |
echo "GITHUB_REPOSITORY=${{github.event.inputs.use_repo}}" >> $GITHUB_ENV
echo "GITHUB_HEAD_REF=${{github.event.inputs.use_git_ref}}" >> $GITHUB_ENV
echo "skipping: ${{github.event.inputs.skipjobs}} and ${{github.event.inputs.skiptests}}"
- uses: actions/checkout@v3
with:
repository: ${{ env.GITHUB_REPOSITORY }}
ref: ${{ env.GITHUB_HEAD_REF }}
- name: make
run: make REDIS_CFLAGS='-Werror -DLOG_REQ_RES'
- name: testprep
run: sudo apt-get install tcl8.6 tclx
- name: test
if: true && !contains(github.event.inputs.skiptests, 'redis')
run: ./runtest --log-req-res --dont-clean --force-resp3 --tags -slow --verbose --dump-logs ${{github.event.inputs.test_args}}
- name: module api test
if: true && !contains(github.event.inputs.skiptests, 'modules')
run: ./runtest-moduleapi --log-req-res --dont-clean --force-resp3 --dont-pre-clean --verbose --dump-logs ${{github.event.inputs.test_args}}
- name: sentinel tests
if: true && !contains(github.event.inputs.skiptests, 'sentinel')
run: ./runtest-sentinel --log-req-res --dont-clean --force-resp3 ${{github.event.inputs.cluster_test_args}}
- name: cluster tests
if: true && !contains(github.event.inputs.skiptests, 'cluster')
run: ./runtest-cluster --log-req-res --dont-clean --force-resp3 ${{github.event.inputs.cluster_test_args}}
- name: Install Python dependencies
uses: py-actions/py-dependency-install@v4
with:
path: "./utils/req-res-validator/requirements.txt"
- name: validator
run: ./utils/req-res-log-validator.py --verbose --fail-missing-reply-schemas --fail-commands-not-all-hit
name: Reply-schemas linter
on:
push:
paths:
- 'src/commands/*.json'
pull_request:
paths:
- 'src/commands/*.json'
jobs:
reply-schemas-linter:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Setup nodejs
uses: actions/setup-node@v3
- name: Install packages
run: npm install ajv
- name: linter
run: node ./utils/reply_schema_linter.js
...@@ -330,9 +330,17 @@ QUIET_LINK = @printf ' %b %b\n' $(LINKCOLOR)LINK$(ENDCOLOR) $(BINCOLOR)$@$(EN ...@@ -330,9 +330,17 @@ QUIET_LINK = @printf ' %b %b\n' $(LINKCOLOR)LINK$(ENDCOLOR) $(BINCOLOR)$@$(EN
QUIET_INSTALL = @printf ' %b %b\n' $(LINKCOLOR)INSTALL$(ENDCOLOR) $(BINCOLOR)$@$(ENDCOLOR) 1>&2; QUIET_INSTALL = @printf ' %b %b\n' $(LINKCOLOR)INSTALL$(ENDCOLOR) $(BINCOLOR)$@$(ENDCOLOR) 1>&2;
endif endif
ifneq (, $(findstring LOG_REQ_RES, $(REDIS_CFLAGS)))
COMMANDS_FILENAME=commands_with_reply_schema
GEN_COMMANDS_FLAGS=--with-reply-schema
else
COMMANDS_FILENAME=commands
GEN_COMMANDS_FLAGS=
endif
REDIS_SERVER_NAME=redis-server$(PROG_SUFFIX) REDIS_SERVER_NAME=redis-server$(PROG_SUFFIX)
REDIS_SENTINEL_NAME=redis-sentinel$(PROG_SUFFIX) REDIS_SENTINEL_NAME=redis-sentinel$(PROG_SUFFIX)
REDIS_SERVER_OBJ=adlist.o quicklist.o ae.o anet.o dict.o server.o sds.o zmalloc.o lzf_c.o lzf_d.o pqsort.o zipmap.o sha1.o ziplist.o release.o networking.o util.o object.o db.o replication.o rdb.o t_string.o t_list.o t_set.o t_zset.o t_hash.o config.o aof.o pubsub.o multi.o debug.o sort.o intset.o syncio.o cluster.o crc16.o endianconv.o slowlog.o eval.o bio.o rio.o rand.o memtest.o syscheck.o crcspeed.o crc64.o bitops.o sentinel.o notify.o setproctitle.o blocked.o hyperloglog.o latency.o sparkline.o redis-check-rdb.o redis-check-aof.o geo.o lazyfree.o module.o evict.o expire.o geohash.o geohash_helper.o childinfo.o defrag.o siphash.o rax.o t_stream.o listpack.o localtime.o lolwut.o lolwut5.o lolwut6.o acl.o tracking.o socket.o tls.o sha256.o timeout.o setcpuaffinity.o monotonic.o mt19937-64.o resp_parser.o call_reply.o script_lua.o script.o functions.o function_lua.o commands.o strl.o connection.o unix.o REDIS_SERVER_OBJ=adlist.o quicklist.o ae.o anet.o dict.o server.o sds.o zmalloc.o lzf_c.o lzf_d.o pqsort.o zipmap.o sha1.o ziplist.o release.o networking.o util.o object.o db.o replication.o rdb.o t_string.o t_list.o t_set.o t_zset.o t_hash.o config.o aof.o pubsub.o multi.o debug.o sort.o intset.o syncio.o cluster.o crc16.o endianconv.o slowlog.o eval.o bio.o rio.o rand.o memtest.o syscheck.o crcspeed.o crc64.o bitops.o sentinel.o notify.o setproctitle.o blocked.o hyperloglog.o latency.o sparkline.o redis-check-rdb.o redis-check-aof.o geo.o lazyfree.o module.o evict.o expire.o geohash.o geohash_helper.o childinfo.o defrag.o siphash.o rax.o t_stream.o listpack.o localtime.o lolwut.o lolwut5.o lolwut6.o acl.o tracking.o socket.o tls.o sha256.o timeout.o setcpuaffinity.o monotonic.o mt19937-64.o resp_parser.o call_reply.o script_lua.o script.o functions.o function_lua.o $(COMMANDS_FILENAME).o strl.o connection.o unix.o logreqres.o
REDIS_CLI_NAME=redis-cli$(PROG_SUFFIX) REDIS_CLI_NAME=redis-cli$(PROG_SUFFIX)
REDIS_CLI_OBJ=anet.o adlist.o dict.o redis-cli.o zmalloc.o release.o ae.o redisassert.o crcspeed.o crc64.o siphash.o crc16.o monotonic.o cli_common.o mt19937-64.o strl.o REDIS_CLI_OBJ=anet.o adlist.o dict.o redis-cli.o zmalloc.o release.o ae.o redisassert.o crcspeed.o crc64.o siphash.o crc16.o monotonic.o cli_common.o mt19937-64.o strl.o
REDIS_BENCHMARK_NAME=redis-benchmark$(PROG_SUFFIX) REDIS_BENCHMARK_NAME=redis-benchmark$(PROG_SUFFIX)
...@@ -425,8 +433,8 @@ DEP = $(REDIS_SERVER_OBJ:%.o=%.d) $(REDIS_CLI_OBJ:%.o=%.d) $(REDIS_BENCHMARK_OBJ ...@@ -425,8 +433,8 @@ DEP = $(REDIS_SERVER_OBJ:%.o=%.d) $(REDIS_CLI_OBJ:%.o=%.d) $(REDIS_BENCHMARK_OBJ
# The file commands.c is checked in and doesn't normally need to be rebuilt. It # The file commands.c is checked in and doesn't normally need to be rebuilt. It
# is built only if python is available and its prereqs are modified. # is built only if python is available and its prereqs are modified.
ifneq (,$(PYTHON)) ifneq (,$(PYTHON))
commands.c: commands/*.json ../utils/generate-command-code.py $(COMMANDS_FILENAME).c: commands/*.json ../utils/generate-command-code.py
$(QUIET_GEN)$(PYTHON) ../utils/generate-command-code.py $(QUIET_GEN)$(PYTHON) ../utils/generate-command-code.py $(GEN_COMMANDS_FLAGS)
endif endif
clean: clean:
......
...@@ -195,6 +195,11 @@ void unblockClient(client *c) { ...@@ -195,6 +195,11 @@ void unblockClient(client *c) {
* or in case a shutdown operation was canceled and we are still in the processCommand sequence */ * or in case a shutdown operation was canceled and we are still in the processCommand sequence */
if (!(c->flags & CLIENT_PENDING_COMMAND) && c->bstate.btype != BLOCKED_SHUTDOWN) { if (!(c->flags & CLIENT_PENDING_COMMAND) && c->bstate.btype != BLOCKED_SHUTDOWN) {
freeClientOriginalArgv(c); freeClientOriginalArgv(c);
/* Clients that are not blocked on keys are not reprocessed so we must
* call reqresAppendResponse here (for clients blocked on key,
* unblockClientOnKey is called, which eventually calls processCommand,
* which calls reqresAppendResponse) */
reqresAppendResponse(c);
resetClient(c); resetClient(c);
} }
...@@ -612,6 +617,8 @@ static void unblockClientOnKey(client *c, robj *key) { ...@@ -612,6 +617,8 @@ static void unblockClientOnKey(client *c, robj *key) {
c->bstate.btype == BLOCKED_LIST || c->bstate.btype == BLOCKED_LIST ||
c->bstate.btype == BLOCKED_ZSET); c->bstate.btype == BLOCKED_ZSET);
/* We need to unblock the client before calling processCommandAndResetClient
* because it checks the CLIENT_BLOCKED flag */
unblockClient(c); unblockClient(c);
/* In case this client was blocked on keys during command /* In case this client was blocked on keys during command
* we need to re process the command again */ * we need to re process the command again */
......
...@@ -13,6 +13,24 @@ ...@@ -13,6 +13,24 @@
"STALE", "STALE",
"SENTINEL" "SENTINEL"
], ],
"reply_schema": {
"anyOf": [
{
"type": "array",
"description": "In case `categoryname` was not given, a list of existing ACL categories",
"items": {
"type": "string"
}
},
{
"type": "array",
"description": "In case `categoryname` was given, list of commands that fall under the provided ACL category",
"items": {
"type": "string"
}
}
]
},
"arguments": [ "arguments": [
{ {
"name": "categoryname", "name": "categoryname",
......
...@@ -14,6 +14,10 @@ ...@@ -14,6 +14,10 @@
"STALE", "STALE",
"SENTINEL" "SENTINEL"
], ],
"reply_schema": {
"type": "integer",
"description": "The number of users that were deleted"
},
"arguments": [ "arguments": [
{ {
"name": "username", "name": "username",
......
...@@ -15,6 +15,18 @@ ...@@ -15,6 +15,18 @@
"STALE", "STALE",
"SENTINEL" "SENTINEL"
], ],
"reply_schema": {
"anyOf": [
{
"const": "OK",
"description": "The given user may successfully execute the given command."
},
{
"type": "string",
"description": "The description of the problem, in case the user is not allowed to run the given command."
}
]
},
"arguments": [ "arguments": [
{ {
"name": "username", "name": "username",
......
...@@ -13,6 +13,10 @@ ...@@ -13,6 +13,10 @@
"STALE", "STALE",
"SENTINEL" "SENTINEL"
], ],
"reply_schema": {
"type": "string",
"description": "Pseudorandom data. By default it contains 64 bytes, representing 256 bits of data. If `bits` was given, the output string length is the number of specified bits (rounded to the next multiple of 4) divided by 4."
},
"arguments": [ "arguments": [
{ {
"name": "bits", "name": "bits",
......
...@@ -29,6 +29,63 @@ ...@@ -29,6 +29,63 @@
"name": "username", "name": "username",
"type": "string" "type": "string"
} }
] ],
"reply_schema": {
"oneOf": [
{
"description": "a set of ACL rule definitions for the user",
"type": "object",
"additionalProperties": false,
"properties": {
"flags": {
"type": "array",
"items": {
"type": "string"
}
},
"passwords": {
"type": "array",
"items": {
"type": "string"
}
},
"commands": {
"description": "root selector's commands",
"type": "string"
},
"keys": {
"description": "root selector's keys",
"type": "string"
},
"channels": {
"description": "root selector's channels",
"type": "string"
},
"selectors": {
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"commands": {
"type": "string"
},
"keys": {
"type": "string"
},
"channels": {
"type": "string"
}
}
}
}
}
},
{
"description": "If user does not exist",
"type": "null"
}
]
}
} }
} }
...@@ -11,6 +11,13 @@ ...@@ -11,6 +11,13 @@
"LOADING", "LOADING",
"STALE", "STALE",
"SENTINEL" "SENTINEL"
] ],
"reply_schema": {
"type": "array",
"description": "A list of subcommands and their description",
"items": {
"type": "string"
}
}
} }
} }
...@@ -13,6 +13,13 @@ ...@@ -13,6 +13,13 @@
"LOADING", "LOADING",
"STALE", "STALE",
"SENTINEL" "SENTINEL"
] ],
"reply_schema": {
"type": "array",
"description": "A list of currently active ACL rules",
"items": {
"type": "string"
}
}
} }
} }
...@@ -13,6 +13,9 @@ ...@@ -13,6 +13,9 @@
"LOADING", "LOADING",
"STALE", "STALE",
"SENTINEL" "SENTINEL"
] ],
"reply_schema": {
"const": "OK"
}
} }
} }
...@@ -20,6 +20,54 @@ ...@@ -20,6 +20,54 @@
"STALE", "STALE",
"SENTINEL" "SENTINEL"
], ],
"reply_schema": {
"oneOf": [
{
"description": "In case `RESET` was not given, a list of recent ACL security events.",
"type": "array",
"items": {
"type": "object",
"additionalProperties": false,
"properties": {
"count": {
"type": "integer"
},
"reason": {
"type": "string"
},
"context": {
"type": "string"
},
"object": {
"type": "string"
},
"username": {
"type": "string"
},
"age-seconds": {
"type": "number"
},
"client-info": {
"type": "string"
},
"entry-id": {
"type": "integer"
},
"timestamp-created": {
"type": "integer"
},
"timestamp-last-updated": {
"type": "integer"
}
}
}
},
{
"const": "OK",
"description": "In case `RESET` was given, OK indicates ACL log was cleared."
}
]
},
"arguments": [ "arguments": [
{ {
"name": "operation", "name": "operation",
......
...@@ -13,6 +13,9 @@ ...@@ -13,6 +13,9 @@
"LOADING", "LOADING",
"STALE", "STALE",
"SENTINEL" "SENTINEL"
] ],
"reply_schema": {
"const": "OK"
}
} }
} }
...@@ -24,6 +24,9 @@ ...@@ -24,6 +24,9 @@
"STALE", "STALE",
"SENTINEL" "SENTINEL"
], ],
"reply_schema": {
"const": "OK"
},
"arguments": [ "arguments": [
{ {
"name": "username", "name": "username",
......
...@@ -13,6 +13,13 @@ ...@@ -13,6 +13,13 @@
"LOADING", "LOADING",
"STALE", "STALE",
"SENTINEL" "SENTINEL"
] ],
"reply_schema": {
"type": "array",
"description": "List of existing ACL users",
"items": {
"type": "string"
}
}
} }
} }
...@@ -12,6 +12,10 @@ ...@@ -12,6 +12,10 @@
"LOADING", "LOADING",
"STALE", "STALE",
"SENTINEL" "SENTINEL"
] ],
"reply_schema": {
"type": "string",
"description": "The username of the current connection."
}
} }
} }
...@@ -34,6 +34,10 @@ ...@@ -34,6 +34,10 @@
} }
} }
], ],
"reply_schema": {
"type": "integer",
"description": "The the length of the string after the append operation."
},
"arguments": [ "arguments": [
{ {
"name": "key", "name": "key",
......
...@@ -11,6 +11,9 @@ ...@@ -11,6 +11,9 @@
], ],
"acl_categories": [ "acl_categories": [
"CONNECTION" "CONNECTION"
] ],
"reply_schema": {
"const": "OK"
}
} }
} }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment