Commit 4d62a82b authored by antirez's avatar antirez
Browse files

Cluster: mismatch sender ID log put back at DEBUG level.

parent 4685f253
...@@ -1331,27 +1331,19 @@ void clusterProcessGossipSection(clusterMsg *hdr, clusterLink *link) { ...@@ -1331,27 +1331,19 @@ void clusterProcessGossipSection(clusterMsg *hdr, clusterLink *link) {
} }
/* If we already know this node, but it is not reachable, and /* If we already know this node, but it is not reachable, and
<<<<<<< HEAD
* we see a different address in the gossip section, start an
* handshake with the (possibly) new address: this will result
* into a node address update if the handshake will be
* successful. */
if (node->flags & (REDIS_NODE_FAIL|REDIS_NODE_PFAIL) &&
=======
* we see a different address in the gossip section of a node that * we see a different address in the gossip section of a node that
* can talk with this other node, update the address, disconnect * can talk with this other node, update the address, disconnect
* the old link if any, so that we'll attempt to connect with the * the old link if any, so that we'll attempt to connect with the
* new address. */ * new address. */
if (node->flags & (CLUSTER_NODE_FAIL|CLUSTER_NODE_PFAIL) && if (node->flags & (REDIS_NODE_FAIL|REDIS_NODE_PFAIL) &&
!(flags & CLUSTER_NODE_NOADDR) && !(flags & REDIS_NODE_NOADDR) &&
!(flags & (CLUSTER_NODE_FAIL|CLUSTER_NODE_PFAIL)) && !(flags & (REDIS_NODE_FAIL|REDIS_NODE_PFAIL)) &&
>>>>>>> bd998b7... Better address udpate strategy when processing gossip sections.
(strcasecmp(node->ip,g->ip) || node->port != ntohs(g->port))) (strcasecmp(node->ip,g->ip) || node->port != ntohs(g->port)))
{ {
if (node->link) freeClusterLink(node->link); if (node->link) freeClusterLink(node->link);
memcpy(node->ip,g->ip,NET_IP_STR_LEN); memcpy(node->ip,g->ip,NET_IP_STR_LEN);
node->port = ntohs(g->port); node->port = ntohs(g->port);
node->flags &= ~CLUSTER_NODE_NOADDR; node->flags &= ~REDIS_NODE_NOADDR;
} }
} else { } else {
/* If it's not in NOADDR state and we don't have it, we /* If it's not in NOADDR state and we don't have it, we
...@@ -1729,7 +1721,7 @@ int clusterProcessPacket(clusterLink *link) { ...@@ -1729,7 +1721,7 @@ int clusterProcessPacket(clusterLink *link) {
/* If the reply has a non matching node ID we /* If the reply has a non matching node ID we
* disconnect this node and set it as not having an associated * disconnect this node and set it as not having an associated
* address. */ * address. */
redisLog(REDIS_WARNING,"PONG contains mismatching sender ID. About node %.40s added %d ms ago, having flags %d", redisLog(REDIS_DEBUG,"PONG contains mismatching sender ID. About node %.40s added %d ms ago, having flags %d",
link->node->name, link->node->name,
(int)(mstime()-(link->node->ctime)), (int)(mstime()-(link->node->ctime)),
link->node->flags); link->node->flags);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment