Unverified Commit 5860fa3d authored by ranshid's avatar ranshid Committed by GitHub
Browse files

deflake client-eviction test "evict clients only until below limit" (#10354)



After introducing #9822 need to prevent client reply buffer shrink
to maintain correct client memory math.

add needs:debug missing one one test.
Co-authored-by: default avatarOran Agra <oran@redislabs.com>
parent fa5d9006
...@@ -217,7 +217,7 @@ start_server {} { ...@@ -217,7 +217,7 @@ start_server {} {
r debug pause-cron 0 r debug pause-cron 0
$rr close $rr close
$redirected_c close $redirected_c close
} } {0} {needs:debug}
test "client evicted due to client tracking prefixes" { test "client evicted due to client tracking prefixes" {
r flushdb r flushdb
...@@ -395,6 +395,7 @@ start_server {} { ...@@ -395,6 +395,7 @@ start_server {} {
test "evict clients only until below limit" { test "evict clients only until below limit" {
set client_count 10 set client_count 10
set client_mem [mb 1] set client_mem [mb 1]
r debug replybuffer-peak-reset-time never
r config set maxmemory-clients 0 r config set maxmemory-clients 0
r client setname control r client setname control
r client no-evict on r client no-evict on
...@@ -437,8 +438,11 @@ start_server {} { ...@@ -437,8 +438,11 @@ start_server {} {
set connected_clients [llength [lsearch -all [split [string trim [r client list]] "\r\n"] *name=client*]] set connected_clients [llength [lsearch -all [split [string trim [r client list]] "\r\n"] *name=client*]]
assert {$connected_clients == [expr $client_count / 2]} assert {$connected_clients == [expr $client_count / 2]}
# Restore the peak reset time to default
r debug replybuffer-peak-reset-time reset
foreach rr $rrs {$rr close} foreach rr $rrs {$rr close}
} } {} {needs:debug}
} }
start_server {} { start_server {} {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment