Unverified Commit 5e3a15ae authored by Yossi Gottlieb's avatar Yossi Gottlieb Committed by GitHub
Browse files

Fix failing cluster tests. (#8763)

Disable replica migration to avoid a race condition where the
migrated-from node turns into a replica.

Long term, this test should probably be improved to handle multiple
slots and accept such auto migrations but this is a quick fix to
stabilize the CI without completely dropping this test.
parent a0e19e3c
......@@ -174,4 +174,4 @@ proc wait_for_cluster_propagation {} {
} else {
fail "cluster config did not reach a consistent state"
}
}
\ No newline at end of file
}
......@@ -9,6 +9,7 @@ source "../tests/includes/utils.tcl"
test "Create a 2 nodes cluster" {
create_cluster 2 0
config_set_all_nodes cluster-allow-replica-migration no
}
test "Cluster is up" {
......@@ -87,3 +88,5 @@ test "Half-finish importing" {
fix_cluster $nodefrom(addr)
assert_equal "xyz" [$cluster get aga]
}
config_set_all_nodes cluster-allow-replica-migration yes
......@@ -9,6 +9,7 @@ source "../tests/includes/utils.tcl"
test "Create a 10 nodes cluster" {
create_cluster 10 0
config_set_all_nodes cluster-allow-replica-migration no
}
test "Cluster is up" {
......@@ -54,3 +55,4 @@ test "Keys are accessible" {
}
}
config_set_all_nodes cluster-allow-replica-migration yes
source "../../../tests/support/cli.tcl"
proc config_set_all_nodes {keyword value} {
foreach_redis_id id {
R $id config set $keyword $value
}
}
proc fix_cluster {addr} {
set code [catch {
exec ../../../src/redis-cli {*}[rediscli_tls_config "../../../tests"] --cluster fix $addr << yes
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment