Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
61de1c11
Commit
61de1c11
authored
Mar 23, 2020
by
antirez
Browse files
Fix BITFIELD_RO test.
parent
918086e2
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/bitops.c
View file @
61de1c11
...
@@ -1007,7 +1007,7 @@ void bitfieldGeneric(client *c, int flags) {
...
@@ -1007,7 +1007,7 @@ void bitfieldGeneric(client *c, int flags) {
}
else
{
}
else
{
if
(
flags
&
BITFIELD_FLAG_READONLY
)
{
if
(
flags
&
BITFIELD_FLAG_READONLY
)
{
zfree
(
ops
);
zfree
(
ops
);
addReplyError
(
c
,
"BITFIELD_RO only support the GET subcommand"
);
addReplyError
(
c
,
"BITFIELD_RO only support
s
the GET subcommand"
);
return
;
return
;
}
}
...
...
tests/unit/bitfield.tcl
View file @
61de1c11
...
@@ -207,7 +207,7 @@ start_server {tags {"repl"}} {
...
@@ -207,7 +207,7 @@ start_server {tags {"repl"}} {
set master_port
[
srv -1 port
]
set master_port
[
srv -1 port
]
set slave
[
srv 0 client
]
set slave
[
srv 0 client
]
test
{
setup slave
}
{
test
{
BITFIELD:
setup slave
}
{
$slave slaveof $master_host $master_port
$slave slaveof $master_host $master_port
wait_for_condition 50 100
{
wait_for_condition 50 100
{
[
s 0 master_link_status
]
eq
{
up
}
[
s 0 master_link_status
]
eq
{
up
}
...
@@ -216,7 +216,7 @@ start_server {tags {"repl"}} {
...
@@ -216,7 +216,7 @@ start_server {tags {"repl"}} {
}
}
}
}
test
{
write on master, read on slave
}
{
test
{
BITFIELD:
write on master, read on slave
}
{
$master del bits
$master del bits
assert_equal 0
[
$master
bitfield bits set u8 0 255
]
assert_equal 0
[
$master
bitfield bits set u8 0 255
]
assert_equal 255
[
$master
bitfield bits set u8 0 100
]
assert_equal 255
[
$master
bitfield bits set u8 0 100
]
...
@@ -224,9 +224,9 @@ start_server {tags {"repl"}} {
...
@@ -224,9 +224,9 @@ start_server {tags {"repl"}} {
assert_equal 100
[
$slave
bitfield_ro bits get u8 0
]
assert_equal 100
[
$slave
bitfield_ro bits get u8 0
]
}
}
test
{
bitfield_ro with
write option
}
{
test
{
BITFIELD_RO fails when
write option
is used
}
{
catch
{
$slave
bitfield_ro bits set u8 0 100 get u8 0
}
err
catch
{
$slave
bitfield_ro bits set u8 0 100 get u8 0
}
err
assert_match
{
*ERR
bitfield_ro
only support
get
subcommand*
}
$err
assert_match
{
*ERR
BITFIELD_RO
only support
s the GET
subcommand*
}
$err
}
}
}
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment