Unverified Commit 6a7dd00c authored by Binbin's avatar Binbin Committed by GitHub
Browse files

Re-enable aof-race integration tests (#10972)

This is the history of aof-race related changes:
1. added in 3aa4b009
2. disabled in dcdfd005
3. enabled in 5c639226
4. disabled in 53a2af39

This PR refreshes the aof-race test, re-enable it.
Closes #10971
parent 4505eb18
source tests/support/aofmanifest.tcl
set defaults { appendonly {yes} appendfilename {appendonly.aof} appenddirname {appendonlydir} aof-use-rdb-preamble {no} }
set server_path [tmpdir server.aof]
proc start_server_aof {overrides code} {
upvar defaults defaults srv srv server_path server_path
set config [concat $defaults $overrides]
start_server [list overrides $config] $code
}
tags {"aof"} {
tags {"aof external:skip"} {
# Specific test for a regression where internal buffers were not properly
# cleaned after a child responsible for an AOF rewrite exited. This buffer
# was subsequently appended to the new AOF, resulting in duplicate commands.
start_server_aof [list dir $server_path] {
set client [redis [srv host] [srv port] 0 $::tls]
set bench [open "|src/redis-benchmark -q -s [srv unixsocket] -c 20 -n 20000 incr foo" "r+"]
set client [redis [dict get $srv host] [dict get $srv port] 0 $::tls]
set bench [open "|src/redis-benchmark -q -s [dict get $srv unixsocket] -c 20 -n 20000 incr foo" "r+"]
after 100
wait_for_condition 100 1 {
[$client get foo] > 0
} else {
# Don't care if it fails.
}
# Benchmark should be running by now: start background rewrite
$client bgrewriteaof
......@@ -23,13 +22,16 @@ tags {"aof"} {
# Read until benchmark pipe reaches EOF
while {[string length [read $bench]] > 0} {}
waitForBgrewriteaof $client
# Check contents of foo
assert_equal 20000 [$client get foo]
}
# Restart server to replay AOF
start_server_aof [list dir $server_path] {
set client [redis [srv host] [srv port] 0 $::tls]
set client [redis [dict get $srv host] [dict get $srv port] 0 $::tls]
wait_done_loading $client
assert_equal 20000 [$client get foo]
}
}
......@@ -50,6 +50,7 @@ set ::all_tests {
integration/replication-buffer
integration/shutdown
integration/aof
integration/aof-race
integration/aof-multi-part
integration/rdb
integration/corrupt-dump
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment