Unverified Commit 8fb89a57 authored by nitaicaro's avatar nitaicaro Committed by GitHub
Browse files

Fixed Tracking test “The other connection is able to get invalidations” (#7871)



PROBLEM:

[$rd1 read] reads invalidation messages one by one, so it's never going to see the second invalidation message produced after INCR b, whether or not it exists. Adding another read will block incase no invalidation message is produced.

FIX:

We switch the order of "INCR a" and "INCR b" - now "INCR b" comes first. We still only read the first invalidation message produces. If an invalidation message is wrongly produces for b - then it will be produced before that of a, since "INCR b" comes before "INCR a".
Co-authored-by: default avatarNitai Caro <caronita@amazon.com>
parent 67b43f75
...@@ -16,9 +16,10 @@ start_server {tags {"tracking"}} { ...@@ -16,9 +16,10 @@ start_server {tags {"tracking"}} {
test {The other connection is able to get invalidations} { test {The other connection is able to get invalidations} {
r SET a 1 r SET a 1
r SET b 1
r GET a r GET a
r INCR a r INCR b ; # This key should not be notified, since it wasn't fetched.
r INCR b ; # This key should not be notified, since it wasn't fetched. r INCR a
set keys [lindex [$rd1 read] 2] set keys [lindex [$rd1 read] 2]
assert {[llength $keys] == 1} assert {[llength $keys] == 1}
assert {[lindex $keys 0] eq {a}} assert {[lindex $keys 0] eq {a}}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment