Unverified Commit ae9764ea authored by Binbin's avatar Binbin Committed by GitHub
Browse files

Increment the stat_rdb_saves counter in SAVE command (#10827)

Currently, we only increment stat_rdb_saves in rdbSaveBackground,
we should also increment it in the SAVE command.

We concluded there's no need to increment when:
1. saving a base file for an AOF
2. when saving an empty rdb file to delete an old one
3. when saving to sockets (not creating a persistence / snapshot file)

The stat counter was introduced in #10178

* fix a wrong comment in startSaving
parent b8665b87
...@@ -2746,7 +2746,7 @@ void stopLoading(int success) { ...@@ -2746,7 +2746,7 @@ void stopLoading(int success) {
} }
void startSaving(int rdbflags) { void startSaving(int rdbflags) {
/* Fire the persistence modules end event. */ /* Fire the persistence modules start event. */
int subevent; int subevent;
if (rdbflags & RDBFLAGS_AOF_PREAMBLE && getpid() != server.pid) if (rdbflags & RDBFLAGS_AOF_PREAMBLE && getpid() != server.pid)
subevent = REDISMODULE_SUBEVENT_PERSISTENCE_AOF_START; subevent = REDISMODULE_SUBEVENT_PERSISTENCE_AOF_START;
...@@ -3479,6 +3479,9 @@ void saveCommand(client *c) { ...@@ -3479,6 +3479,9 @@ void saveCommand(client *c) {
addReplyError(c,"Background save already in progress"); addReplyError(c,"Background save already in progress");
return; return;
} }
server.stat_rdb_saves++;
rdbSaveInfo rsi, *rsiptr; rdbSaveInfo rsi, *rsiptr;
rsiptr = rdbPopulateSaveInfo(&rsi); rsiptr = rdbPopulateSaveInfo(&rsi);
if (rdbSave(SLAVE_REQ_NONE,server.rdb_filename,rsiptr) == C_OK) { if (rdbSave(SLAVE_REQ_NONE,server.rdb_filename,rsiptr) == C_OK) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment