Unverified Commit d2405b9b authored by judeng's avatar judeng Committed by GitHub
Browse files

fix benchmark failure in daily test with TLS (#10896)

The new test added in #10891 can fail with a different error.
see comment in networking.c saying
```c
        /* That's a best effort error message, don't check write errors.
         * Note that for TLS connections, no handshake was done yet so nothing
         * is written and the connection will just drop. */
```
parent aabce893
......@@ -118,11 +118,11 @@ start_server {tags {"benchmark network external:skip"}} {
}
test {benchmark: clients idle mode should return error when reached maxclients limit} {
set cmd [redisbenchmark $master_host $master_port "-c 2 -I"]
set cmd [redisbenchmark $master_host $master_port "-c 10 -I"]
set original_maxclients [lindex [r config get maxclients] 1]
r config set maxclients 1
r config set maxclients 5
catch { exec {*}$cmd } error
assert_match "*ERR max number of clients reached*" $error
assert_match "*Error*" $error
r config set maxclients $original_maxclients
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment