Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
ea0af9ac
Commit
ea0af9ac
authored
Apr 17, 2014
by
antirez
Browse files
ZREMRANGE* commands refactored into a single generic function.
parent
019e6f18
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/t_zset.c
View file @
ea0af9ac
...
@@ -1313,31 +1313,74 @@ void zremCommand(redisClient *c) {
...
@@ -1313,31 +1313,74 @@ void zremCommand(redisClient *c) {
addReplyLongLong(c,deleted);
addReplyLongLong(c,deleted);
}
}
void
zremrangebyscoreCommand
(
redisClient
*
c
)
{
/* Implements ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREMRANGEBYLEX commands. */
#define ZRANGE_RANK 0
#define ZRANGE_SCORE 1
#define ZRANGE_LEX 2
void zremrangeGenericCommand(redisClient *c, int rangetype) {
robj *key = c->argv[1];
robj *key = c->argv[1];
robj *zobj;
robj *zobj;
zrangespec
range
;
int keyremoved = 0;
int keyremoved = 0;
unsigned long deleted;
unsigned long deleted;
zrangespec range;
long start, end, llen;
/* Parse the range arguments. */
/* Step 1: Parse the range. */
if
(
zslParseRange
(
c
->
argv
[
2
],
c
->
argv
[
3
],
&
range
)
!=
REDIS_OK
)
{
if (rangetype == ZRANGE_RANK) {
addReplyError
(
c
,
"min or max is not a float"
);
if ((getLongFromObjectOrReply(c,c->argv[2],&start,NULL) != REDIS_OK) ||
return
;
(getLongFromObjectOrReply(c,c->argv[3],&end,NULL) != REDIS_OK))
return;
} else if (rangetype == ZRANGE_SCORE) {
if (zslParseRange(c->argv[2],c->argv[3],&range) != REDIS_OK) {
addReplyError(c,"min or max is not a float");
return;
}
}
}
/* Step 2: Lookup & range sanity checks if needed. */
if ((zobj = lookupKeyWriteOrReply(c,key,shared.czero)) == NULL ||
if ((zobj = lookupKeyWriteOrReply(c,key,shared.czero)) == NULL ||
checkType(c,zobj,REDIS_ZSET)) return;
checkType(c,zobj,REDIS_ZSET)) return;
if (rangetype == ZRANGE_RANK) {
/* Sanitize indexes. */
llen = zsetLength(zobj);
if (start < 0) start = llen+start;
if (end < 0) end = llen+end;
if (start < 0) start = 0;
/* Invariant: start >= 0, so this test will be true when end < 0.
* The range is empty when start > end or start >= length. */
if (start > end || start >= llen) {
addReply(c,shared.czero);
return;
}
if (end >= llen) end = llen-1;
}
/* Step 3: Perform the range deletion operation. */
if (zobj->encoding == REDIS_ENCODING_ZIPLIST) {
if (zobj->encoding == REDIS_ENCODING_ZIPLIST) {
zobj
->
ptr
=
zzlDeleteRangeByScore
(
zobj
->
ptr
,
range
,
&
deleted
);
switch(rangetype) {
case ZRANGE_RANK:
zobj->ptr = zzlDeleteRangeByRank(zobj->ptr,start+1,end+1,&deleted);
break;
case ZRANGE_SCORE:
zobj->ptr = zzlDeleteRangeByScore(zobj->ptr,range,&deleted);
break;
}
if (zzlLength(zobj->ptr) == 0) {
if (zzlLength(zobj->ptr) == 0) {
dbDelete(c->db,key);
dbDelete(c->db,key);
keyremoved = 1;
keyremoved = 1;
}
}
} else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {
} else if (zobj->encoding == REDIS_ENCODING_SKIPLIST) {
zset *zs = zobj->ptr;
zset *zs = zobj->ptr;
deleted
=
zslDeleteRangeByScore
(
zs
->
zsl
,
range
,
zs
->
dict
);
switch(rangetype) {
case ZRANGE_RANK:
deleted = zslDeleteRangeByRank(zs->zsl,start+1,end+1,zs->dict);
break;
case ZRANGE_SCORE:
deleted = zslDeleteRangeByScore(zs->zsl,range,zs->dict);
break;
}
if (htNeedsResize(zs->dict)) dictResize(zs->dict);
if (htNeedsResize(zs->dict)) dictResize(zs->dict);
if (dictSize(zs->dict) == 0) {
if (dictSize(zs->dict) == 0) {
dbDelete(c->db,key);
dbDelete(c->db,key);
...
@@ -1347,9 +1390,11 @@ void zremrangebyscoreCommand(redisClient *c) {
...
@@ -1347,9 +1390,11 @@ void zremrangebyscoreCommand(redisClient *c) {
redisPanic("Unknown sorted set encoding");
redisPanic("Unknown sorted set encoding");
}
}
/* Step 4: Notifications and reply. */
if (deleted) {
if (deleted) {
char *event[3] = {"zremrangebyrank","zremrangebyscore","zremrangebylex"};
signalModifiedKey(c->db,key);
signalModifiedKey(c->db,key);
notifyKeyspaceEvent
(
REDIS_NOTIFY_ZSET
,
"zrembyscore"
,
key
,
c
->
db
->
id
);
notifyKeyspaceEvent(REDIS_NOTIFY_ZSET,
event[rangetype]
,key,c->db->id);
if (keyremoved)
if (keyremoved)
notifyKeyspaceEvent(REDIS_NOTIFY_GENERIC,"del",key,c->db->id);
notifyKeyspaceEvent(REDIS_NOTIFY_GENERIC,"del",key,c->db->id);
}
}
...
@@ -1358,63 +1403,11 @@ void zremrangebyscoreCommand(redisClient *c) {
...
@@ -1358,63 +1403,11 @@ void zremrangebyscoreCommand(redisClient *c) {
}
}
void zremrangebyrankCommand(redisClient *c) {
void zremrangebyrankCommand(redisClient *c) {
robj
*
key
=
c
->
argv
[
1
];
zremrangeGenericCommand(c,ZRANGE_RANK);
robj
*
zobj
;
}
long
start
;
long
end
;
int
llen
;
unsigned
long
deleted
;
int
keyremoved
=
0
;
if
((
getLongFromObjectOrReply
(
c
,
c
->
argv
[
2
],
&
start
,
NULL
)
!=
REDIS_OK
)
||
(
getLongFromObjectOrReply
(
c
,
c
->
argv
[
3
],
&
end
,
NULL
)
!=
REDIS_OK
))
return
;
if
((
zobj
=
lookupKeyWriteOrReply
(
c
,
key
,
shared
.
czero
))
==
NULL
||
checkType
(
c
,
zobj
,
REDIS_ZSET
))
return
;
/* Sanitize indexes. */
llen
=
zsetLength
(
zobj
);
if
(
start
<
0
)
start
=
llen
+
start
;
if
(
end
<
0
)
end
=
llen
+
end
;
if
(
start
<
0
)
start
=
0
;
/* Invariant: start >= 0, so this test will be true when end < 0.
* The range is empty when start > end or start >= length. */
if
(
start
>
end
||
start
>=
llen
)
{
addReply
(
c
,
shared
.
czero
);
return
;
}
if
(
end
>=
llen
)
end
=
llen
-
1
;
if
(
zobj
->
encoding
==
REDIS_ENCODING_ZIPLIST
)
{
/* Correct for 1-based rank. */
zobj
->
ptr
=
zzlDeleteRangeByRank
(
zobj
->
ptr
,
start
+
1
,
end
+
1
,
&
deleted
);
if
(
zzlLength
(
zobj
->
ptr
)
==
0
)
{
dbDelete
(
c
->
db
,
key
);
keyremoved
=
1
;
}
}
else
if
(
zobj
->
encoding
==
REDIS_ENCODING_SKIPLIST
)
{
zset
*
zs
=
zobj
->
ptr
;
/* Correct for 1-based rank. */
deleted
=
zslDeleteRangeByRank
(
zs
->
zsl
,
start
+
1
,
end
+
1
,
zs
->
dict
);
if
(
htNeedsResize
(
zs
->
dict
))
dictResize
(
zs
->
dict
);
if
(
dictSize
(
zs
->
dict
)
==
0
)
{
dbDelete
(
c
->
db
,
key
);
keyremoved
=
1
;
}
}
else
{
redisPanic
(
"Unknown sorted set encoding"
);
}
if
(
deleted
)
{
void zremrangebyscoreCommand(redisClient *c) {
signalModifiedKey
(
c
->
db
,
key
);
zremrangeGenericCommand(c,ZRANGE_SCORE);
notifyKeyspaceEvent
(
REDIS_NOTIFY_ZSET
,
"zrembyrank"
,
key
,
c
->
db
->
id
);
if
(
keyremoved
)
notifyKeyspaceEvent
(
REDIS_NOTIFY_GENERIC
,
"del"
,
key
,
c
->
db
->
id
);
}
server
.
dirty
+=
deleted
;
addReplyLongLong
(
c
,
deleted
);
}
}
typedef struct {
typedef struct {
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment