1. 13 Dec, 2015 1 commit
  2. 27 Nov, 2015 1 commit
    • antirez's avatar
      Handle wait3() errors. · 1cc7a454
      antirez authored
      My guess was that wait3() with WNOHANG could never return -1 and an
      error. However issue #2897 may possibly indicate that this could happen
      under non clear conditions. While we try to understand this better,
      better to handle a return value of -1 explicitly, otherwise in the
      case a BGREWRITE is in progress but wait3() returns -1, the effect is to
      match the first branch of the if/else block since server.rdb_child_pid
      is -1, and call backgroundSaveDoneHandler() without a good reason, that
      will, in turn, crash the Redis server with an assertion.
      1cc7a454
  3. 19 Nov, 2015 3 commits
  4. 17 Nov, 2015 2 commits
    • antirez's avatar
      Remove "s" flag for MIGRATE in command table. · b96938b1
      antirez authored
      Maybe there are legitimate use cases for MIGRATE inside Lua scripts, at
      least for now. When the command will be executed in an asynchronous
      fashion (planned) it is possible we'll no longer be able to permit it
      from within Lua scripts.
      b96938b1
    • antirez's avatar
      Fix MIGRATE entry in command table. · 1236471b
      antirez authored
      Thanks to Oran Agra (@oranagra) for reporting. Key extraction would not
      work otherwise and it does not make sense to take wrong data in the
      command table.
      1236471b
  5. 10 Nov, 2015 1 commit
  6. 09 Nov, 2015 2 commits
  7. 05 Nov, 2015 1 commit
  8. 30 Oct, 2015 6 commits
  9. 15 Oct, 2015 2 commits
  10. 01 Oct, 2015 2 commits
  11. 29 Jul, 2015 1 commit
  12. 28 Jul, 2015 5 commits
  13. 27 Jul, 2015 2 commits
  14. 26 Jul, 2015 6 commits
  15. 17 Jul, 2015 1 commit
  16. 16 Jul, 2015 2 commits
    • antirez's avatar
      Client timeout handling improved. · 25e1cb3f
      antirez authored
      The previos attempt to process each client at least once every ten
      seconds was not a good idea, because:
      
      1. Usually because of the past min iterations set to 50, you get much
      better processing period most of the times.
      
      2. However when there are many clients and a normal setting for
      server.hz, the edge case is triggered, and waiting 10 seconds for a
      BLPOP that asked for 1 second is not ok.
      
      3. Moreover, because of the high min-itereations limit of 50, when HZ
      was set to an high value, the actual behavior was to process a lot of
      clients per second.
      
      Also the function checking for timeouts called gettimeofday() at each
      iteration which can be costly.
      
      The new implementation will try to process each client once per second,
      gets the current time as argument, and does not attempt to process more
      than 5 clients per iteration if not needed.
      
      So now:
      
      1. The CPU usage of an idle Redis process is the same or better.
      2. The CPU usage of a busy Redis process is the same or better.
      3. However a non trivial amount of work may be performed per iteration
      when there are many many clients. In this particular case the user may
      want to raise the "HZ" value if needed.
      
      Btw with 4000 clients it was still not possible to noticy any actual
      latency created by processing 400 clients per second, since the work
      performed for each client is pretty small.
      25e1cb3f
    • antirez's avatar
      Clarify a comment in clientsCron(). · e0bb454a
      antirez authored
      e0bb454a
  17. 13 Jul, 2015 2 commits
    • antirez's avatar
      EXISTS is now variadic. · 4c7ee0d5
      antirez authored
      The new return value is the number of keys existing, among the ones
      specified in the command line, counting the same key multiple times if
      given multiple times (and if it exists).
      
      See PR #2667.
      4c7ee0d5
    • antirez's avatar
      Geo: fix command table keys position indexes for three commands. · 5c4fcaf3
      antirez authored
      GEOHASH, GEOPOS and GEODIST where declared as commands not accepting
      keys, so the Redis Cluster redirection did not worked.
      
      Close #2671.
      5c4fcaf3