1. 05 Sep, 2012 1 commit
    • Saj Goonatilleke's avatar
      Bug fix: slaves being pinged every second · 0671d88c
      Saj Goonatilleke authored
      REDIS_REPL_PING_SLAVE_PERIOD controls how often the master should
      transmit a heartbeat (PING) to its slaves.  This period, which defaults
      to 10, is measured in seconds.
      
      Redis 2.4 masters used to ping their slaves every ten seconds, just like
      it says on the tin.
      
      The Redis 2.6 masters I have been experimenting with, on the other hand,
      ping their slaves *every second*.  (master_last_io_seconds_ago never
      approaches 10.)  I think the ping period was inadvertently slashed to
      one-tenth of its nominal value around the time REDIS_HZ was introduced.
      This commit reintroduces correct ping schedule behaviour.
      0671d88c
  2. 03 Sep, 2012 1 commit
    • antirez's avatar
      Send an async PING before starting replication with master. · fd2a8951
      antirez authored
      During the first synchronization step of the replication process, a Redis
      slave connects with the master in a non blocking way. However once the
      connection is established the replication continues sending the REPLCONF
      command, and sometimes the AUTH command if needed. Those commands are
      send in a partially blocking way (blocking with timeout in the order of
      seconds).
      
      Because it is common for a blocked master to accept connections even if
      it is actually not able to reply to the slave requests, it was easy for
      a slave to block if the master had serious issues, but was still able to
      accept connections in the listening socket.
      
      For this reason we now send an asynchronous PING request just after the
      non blocking connection ended in a successful way, and wait for the
      reply before to continue with the replication process. It is very
      unlikely that a master replying to PING can't reply to the other
      commands.
      
      This solution was proposed by Didier Spezia (Thanks!) so that we don't
      need to turn all the replication process into a non blocking affair, but
      still the probability of a slave blocked is minimal even in the event of
      a failing master.
      
      Also we now use getsockopt(SO_ERROR) in order to check errors ASAP
      in the event handler, instead of waiting for actual I/O to return an
      error.
      
      This commit fixes issue #632.
      fd2a8951
  3. 28 Aug, 2012 1 commit
    • antirez's avatar
      Incrementally flush RDB on disk while loading it from a master. · 13732168
      antirez authored
      This fixes issue #539.
      
      Basically if there is enough free memory the OS may buffer the RDB file
      that the slave transfers on disk from the master. The file may
      actually be flused on disk at once by the operating system when it gets
      closed by Redis, causing the close system call to block for a long time.
      
      This patch is a modified version of one provided by yoav-steinberg of
      @garantiadata (the original version was posted in the issue #539
      comments), and tries to flush the OS buffers incrementally (every 8 MB
      of loaded data).
      13732168
  4. 07 Jul, 2012 2 commits
    • antirez's avatar
      Typo in comment. · d3d56742
      antirez authored
      d3d56742
    • antirez's avatar
      REPLCONF internal command introduced. · dbd8c753
      antirez authored
      The REPLCONF command is an internal command (not designed to be directly
      used by normal clients) that allows a slave to set some replication
      related state in the master before issuing SYNC to start the
      replication.
      
      The initial motivation for this command, and the only reason currently
      it is used by the implementation, is to let the slave instance
      communicate its listening port to the slave, so that the master can
      show all the slaves with their listening ports in the "replication"
      section of the INFO output.
      
      This allows clients to auto discover and query all the slaves attached
      into a master.
      
      Currently only a single option of the REPLCONF command is supported, and
      it is called "listening-port", so the slave now starts the replication
      process with something like the following chat:
      
          REPLCONF listening-prot 6380
          SYNC
      
      Note that this works even if the master is an older version of Redis and
      does not understand REPLCONF, because the slave ignores the REPLCONF
      error.
      
      In the future REPLCONF can be used for partial replication and other
      replication related features where there is the need to exchange
      information between master and slave.
      
      NOTE: This commit also fixes a bug: the INFO outout already carried
      information about slaves, but the port was broken, and was obtained
      with getpeername(2), so it was actually just the ephemeral port used
      by the slave to connect to the master as a client.
      dbd8c753
  5. 24 May, 2012 1 commit
    • antirez's avatar
      Dead code removed from replication.c. · 8152d0c0
      antirez authored
      The user @jokea noticed that the following line of code into
      replication.c made little sense:
      
          addReplySds(slave,sdsempty());
      
      Investigating a bit I found that this was introduced by commit 6208b3a7
      three years ago in the early stages of Redis. The code apparently is not
      useful at all, so I'm removing it.
      
      This change will not be backported into 2.4 so that in the rare case
      this should introduce a bug, we'll have a chance to detect it into the
      development branch. However following the code path it seems like the
      code is not useful at all, so the risk is truly small.
      8152d0c0
  6. 02 May, 2012 1 commit
  7. 27 Apr, 2012 1 commit
  8. 31 Mar, 2012 1 commit
  9. 30 Mar, 2012 2 commits
  10. 29 Mar, 2012 1 commit
  11. 27 Mar, 2012 1 commit
  12. 07 Mar, 2012 1 commit
  13. 29 Feb, 2012 1 commit
  14. 16 Jan, 2012 1 commit
  15. 30 Dec, 2011 1 commit
  16. 21 Dec, 2011 3 commits
  17. 15 Dec, 2011 1 commit
  18. 30 Nov, 2011 1 commit
  19. 31 Oct, 2011 1 commit
  20. 18 Oct, 2011 1 commit
  21. 09 Jun, 2011 1 commit
  22. 30 May, 2011 1 commit
  23. 22 May, 2011 2 commits
  24. 19 May, 2011 1 commit
  25. 21 Feb, 2011 1 commit
  26. 20 Jan, 2011 1 commit
  27. 14 Dec, 2010 1 commit
  28. 12 Nov, 2010 1 commit
  29. 04 Nov, 2010 4 commits
  30. 24 Oct, 2010 1 commit
  31. 02 Sep, 2010 1 commit
  32. 27 Aug, 2010 1 commit