- 10 Dec, 2014 12 commits
-
-
antirez authored
Slaves key expire is orchestrated by the master. Sometimes the master will send the synthesized DEL to expire keys on the slave with a non trivial delay (when the key is not accessed, only the incremental expiry algorithm will expire it in background). During that time, a key is logically expired, but slaves still return the key if you GET (or whatever) it. This is a bad behavior. However we can't simply trust the slave view of the key, since we need the master to be able to send write commands to update the slave data set, and DELs should only happen when the key is expired in the master in order to ensure consistency. However 99.99% of the issues with this behavior is when a client which is not a master sends a read only command. In this case we are safe and can consider the key as non existing. This commit does a few changes in order to make this sane: 1. lookupKeyRead() is modified in order to return NULL if the above conditions are met. 2. Calls to lookupKeyRead() in commands actually writing to the data set are repliaced with calls to lookupKeyWrite(). There are redundand checks, so for example, if in "2" something was overlooked, we should be still safe, since anyway, when the master writes the behavior is to don't care about what expireIfneeded() returns. This commit is related to #1768, #1770, #2131.
-
Salvatore Sanfilippo authored
override histfile from env - fixes #831 and copies #833
-
antirez authored
Changed in order to make them more review friendly, based on the experience of reviewing the code myself.
-
antirez authored
I guess the initial goal of the initialization was to suppress GCC warning, but if we have to initialize, we can do it with the base-case value instead of NULL which is never retained.
-
antirez authored
-
antirez authored
-
Salvatore Sanfilippo authored
Add SENTINEL INFO-CACHE [masters...]
-
antirez authored
-
Salvatore Sanfilippo authored
Update sds.c
-
antirez authored
-
antirez authored
-
Brochen authored
in the case (all chars of the string s found in 'cset' ), line[573] will no more do the same thing line[572] did. this will be more faster especially in the case that the string s is very long and all chars of string s found in 'cset'
-
- 09 Dec, 2014 11 commits
-
-
Salvatore Sanfilippo authored
zipmap.c: update comments above
-
Salvatore Sanfilippo authored
redis-benchmark AUTH command to be discarded after the first send #2150
-
Salvatore Sanfilippo authored
sds.c/sdscatvprintf: va_end needs to be fixed
-
antirez authored
-
Salvatore Sanfilippo authored
Fix implicit declaration of ioctl on Solaris
-
Salvatore Sanfilippo authored
bitops.c/redisPopcount: optimization in loop
-
Salvatore Sanfilippo authored
Silence _BSD_SOURCE warnings in glibc 2.20 and forward
-
antirez authored
-
Salvatore Sanfilippo authored
getting pid fixes
-
Salvatore Sanfilippo authored
sparkline.c: mov label-ini into the AddSample Function
-
Salvatore Sanfilippo authored
Only ignore sigpipe in interactive mode
-
- 08 Dec, 2014 3 commits
-
-
Jan-Erik Rediger authored
This allows shell pipes to correctly end redis-cli. Ref #2066
-
Sun He authored
-
Sun He authored
-
- 05 Dec, 2014 4 commits
-
-
Serghei Iakovlev authored
Improved getting pid
-
Serghei Iakovlev authored
```sh $ ~ pidof redis-server # nothing $ ~ ps aux | grep [r]edis redis 593 0.0 0.0 36900 5564 ? Ssl Dec02 1:37 /usr/bin/redis-server 127.0.0.1:6379 klay 15927 0.0 0.0 16772 6068 pts/6 S+ 13:58 0:00 redis-cli $ ~ uname -a Linux edge 3.17.4-1-ARCH #1 SMP PREEMPT Fri Nov 21 21:14:42 CET 2014 x86_64 GNU/Linux ```
-
antirez authored
Thanks to @badboy for the help in checking the build after the fix.
-
-
- 04 Dec, 2014 1 commit
-
-
antirez authored
-
- 03 Dec, 2014 5 commits
-
-
antirez authored
Track bandwidth used by clients and replication (but diskless replication is not tracked since the actual transfer happens in the child process). This includes a refactoring that makes tracking new instantaneous metrics simpler.
-
antirez authored
Closes issue #1935.
-
antirez authored
-
antirez authored
-
Sun He authored
-
- 02 Dec, 2014 4 commits
-
-
antirez authored
Ref: issue #2175
-
antirez authored
-
antirez authored
PFCOUNT is technically speaking a write command, since the cached value of the HLL is exposed in the data structure (design error, mea culpa), and can be modified by PFCOUNT. However if we flag PFCOUNT as "w", read only slaves can't execute the command, which is a problem since there are environments where slaves are used to scale PFCOUNT reads. Nor it is possible to just prevent PFCOUNT to modify the data structure in slaves, since without the cache we lose too much efficiency. So while this commit allows slaves to create a temporary inconsistency (the strings representing the HLLs in the master and slave can be different in certain moments) it is actually harmless. In the long run this should be probably fixed by turning the HLL into a more opaque representation, for example by storing the cached value in the part of the string which is not exposed (this should be possible with SDS strings).
-
antirez authored
-