- 31 Dec, 2019 1 commit
-
-
WuYunlong authored
Funcion adjustOpenFilesLimit() has an implicit parameter, which is server.maxclients. This function aims to ajust maximum file descriptor number according to server.maxclients by best effort, which is "bestlimit" could be lower than "maxfiles" but greater than "oldlimit". When we try to increase "maxclients" using CONFIG SET command, we could increase maximum file descriptor number to a bigger value without calling aeResizeSetSize the same time. When later more and more clients connect to server, the allocated fd could be bigger and bigger, and eventually exceeds events size of aeEventLoop.events. When new nodes joins the cluster, new link is created, together with new fd, but when calling aeCreateFileEvent, we did not check the return value. In this case, we have a non-null "link" but the associated fd is not registered. So when we dynamically set "maxclients" we could reach an inconsistency between maximum file descriptor number of the process and server.maxclients. And later could cause cluster link and link fd inconsistency. While setting "maxclients" dynamically, we consider it as failed when resulting "maxclients" is not the same as expected. We try to restore back the maximum file descriptor number when we failed to set "maxclients" to the specified value, so that server.maxclients could act as a guard as before.
-
- 29 Dec, 2019 5 commits
-
-
antirez authored
Happened when we set the name to "" to cancel the name. Was introduced during the RESP3 refactoring. See #6036.
-
antirez authored
-
antirez authored
This bug is from the first version of Redis. Probably the problem here is that before we used an SDS split function that created empty strings for additional spaces, like in "SET foo bar". AFAIK later we replaced it with the curretn sdssplitarg() API that has no such a problem. As a result, we introduced a bug, where it is no longer possible to do something like: SET foo "" Using the inline protocol. Now it is fixed.
-
Salvatore Sanfilippo authored
Stream: Handle streamID-related edge cases
-
Salvatore Sanfilippo authored
config.c adjust config limits and mutable
-
- 26 Dec, 2019 2 commits
-
-
Oran Agra authored
- make lua-replicate-commands mutable (it never was, but i don't see why) - make tcp-backlog immutable (fix a recent refactory mistake) - increase the max limit of a few configs to match what they were before the recent refactory
-
Guy Benoish authored
This commit solves several edge cases that are related to exhausting the streamID limits: We should correctly calculate the succeeding streamID instead of blindly incrementing 'seq' This affects both XREAD and XADD. Other (unrelated) changes: Reply with a better error message when trying to add an entry to a stream that has exhausted last_id
-
- 20 Dec, 2019 1 commit
-
-
antirez authored
-
- 19 Dec, 2019 3 commits
-
-
Salvatore Sanfilippo authored
Wrap also propagate as multi
-
Salvatore Sanfilippo authored
scripting: flag lua_client as CLIENT_MULTI after redis.replicate_command() immediately
-
Salvatore Sanfilippo authored
Better systemd integration v2
-
- 18 Dec, 2019 8 commits
-
-
antirez authored
-
Salvatore Sanfilippo authored
Add config and module API for AvoidReplicaTraffic
-
antirez authored
-
antirez authored
-
Salvatore Sanfilippo authored
Add a new SET option KEEPTTL and fix issue #5256
-
zhaozhao.zz authored
-
zhaozhao.zz authored
-
- 17 Dec, 2019 13 commits
-
-
Salvatore Sanfilippo authored
Add module APIs for custom authentication
-
antirez authored
-
Salvatore Sanfilippo authored
Add configuration option for allowing reads on cluster down
-
Madelyn Olson authored
-
Madelyn Olson authored
-
Madelyn Olson authored
-
Madelyn Olson authored
-
Madelyn Olson authored
-
Madelyn Olson authored
-
Madelyn Olson authored
-
Madelyn Olson authored
-
Madelyn Olson authored
-
Madelyn Olson authored
-
- 16 Dec, 2019 4 commits
-
-
Salvatore Sanfilippo authored
Fix outdated information on max memory policies
-
antirez authored
-
antirez authored
-
Salvatore Sanfilippo authored
init server.hz early to avoid div by 0 during config file loading
-
- 13 Dec, 2019 1 commit
-
-
antirez authored
-
- 12 Dec, 2019 2 commits
-
-
Salvatore Sanfilippo authored
Improve RM_ModuleTypeReplaceValue() API.
-
Yossi Gottlieb authored
With the previous API, a NULL return value was ambiguous and could represent either an old value of NULL or an error condition. The new API returns a status code and allows the old value to be returned by-reference. This commit also includes test coverage based on tests/modules/datatype.c which did not exist at the time of the original commit.
-