- 16 Apr, 2014 1 commit
-
-
antirez authored
Converts HyperLogLogs from sparse to dense. Used for testing.
-
- 15 Apr, 2014 2 commits
- 14 Apr, 2014 19 commits
-
-
antirez authored
-
antirez authored
After running a few benchmarks, 3000 looks like a reasonable value to keep HLLs with a few thousand elements small while the CPU cost is still not huge. This covers all the cases where the dense representation would use N orders of magnitude more space, like in the case of many HLLs with carinality of a few tens or hundreds. It is not impossible that in the future this gets user configurable, however it is easy to pick an unreasoable value just looking at savings in the space dimension without checking what happens in the time dimension.
-
antirez authored
-
antirez authored
-
antirez authored
It is safer since it is able to have side effects.
-
antirez authored
Even if it is a debugging command, make sure that when it forces a change in encoding, the command is propagated.
-
antirez authored
If we converted to dense, a register must be updated in the dense representation.
-
antirez authored
Mostly by reordering opcodes check conditional by frequency of opcodes in larger sparse-encoded HLLs.
-
antirez authored
-
antirez authored
Bottleneck found profiling. Big run time improvement found when testing after the change.
-
antirez authored
-
antirez authored
As more values are added splitting ZERO or XZERO opcodes, try to merge adjacent VAL opcodes if they have the same value.
-
antirez authored
Now the macros will work with arguments such as "ptr+1".
-
antirez authored
-
antirez authored
Bulk length for registers was emitted too early, so if there was a bug the reply looked like a long array with just one element, blocking the client as result.
-
antirez authored
-
antirez authored
We want to promote if the total string size exceeds the resulting size after the upgrade.
-
antirez authored
The function checks if all the HLL_REGISTERS were processed during the convertion from sparse to dense encoding, returning REDIS_OK or REDIS_ERR to signal a corruption problem. A bug in PFDEBUG GETREG was fixed: when the object is converted to the dense representation we need to reassign the new pointer to the header structure pointer.
-
antirez authored
Provides a human readable description of the opcodes composing a run-length encoded HLL (sparse encoding). The command is only useful for debugging / development tasks.
-
- 13 Apr, 2014 3 commits
- 12 Apr, 2014 10 commits
-
-
antirez authored
sdsIncrLen() must be called anyway even if we are replacing the last oppcode of the sparse representation.
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
Two vars initialized to wrong values in createHLLObject().
-
antirez authored
-
antirez authored
The function didn't considered the fact that each XZERO opcode is two bytes.
-
antirez authored
-
antirez authored
-
- 11 Apr, 2014 4 commits
-
-
antirez authored
Code never tested, but the basic layout is shaped in this commit. Also missing: 1) Sparse -> Dense conversion function. 2) New HLL object creation using the sparse representation. 3) Implementation of PFMERGE for the sparse representation.
-
antirez authored
-
antirez authored
Also dense representation access macro renamed accordingly.
-
antirez authored
Metadata are now placed at the start of the representation as an header. There is a proper structure to access the representation. Still work to do in order to truly abstract the implementation from the representation, commands still work assuming dense representation.
-
- 10 Apr, 2014 1 commit
-
-
antirez authored
After running a few simulations with different alternative encodings, it was found that the VAL opcode performs better using 5 bits for the value and 2 bits for the run length, at least for cardinalities in the range of interest.
-