1. 21 Jul, 2021 1 commit
  2. 10 May, 2019 1 commit
    • 唐权's avatar
      Update ziplist.c · d3c17c9d
      唐权 authored
      Hi, @antirez
      
      In the code, to get the size of ziplist, "unsigned int bytes = ZIPLIST_HEADER_SIZE+1;" is correct, 
      but why not make it more readable and easy to understand
      d3c17c9d
  3. 03 Jul, 2018 1 commit
  4. 12 Jun, 2018 1 commit
  5. 07 Jun, 2018 1 commit
  6. 23 Feb, 2018 1 commit
  7. 16 Jan, 2018 1 commit
  8. 01 Feb, 2017 2 commits
    • antirez's avatar
      Fix ziplist fix... · 0dbfb1d1
      antirez authored
      0dbfb1d1
    • antirez's avatar
      Ziplist: insertion bug under particular conditions fixed. · c495d095
      antirez authored
      Ziplists had a bug that was discovered while investigating a different
      issue, resulting in a corrupted ziplist representation, and a likely
      segmentation foult and/or data corruption of the last element of the
      ziplist, once the ziplist is accessed again.
      
      The bug happens when a specific set of insertions / deletions is
      performed so that an entry is encoded to have a "prevlen" field (the
      length of the previous entry) of 5 bytes but with a count that could be
      encoded in a "prevlen" field of a since byte. This could happen when the
      "cascading update" process called by ziplistInsert()/ziplistDelete() in
      certain contitious forces the prevlen to be bigger than necessary in
      order to avoid too much data moving around.
      
      Once such an entry is generated, inserting a very small entry
      immediately before it will result in a resizing of the ziplist for a
      count smaller than the current ziplist length (which is a violation,
      inserting code expects the ziplist to get bigger actually). So an FF
      byte is inserted in a misplaced position. Moreover a realloc() is
      performed with a count smaller than the ziplist current length so the
      final bytes could be trashed as well.
      
      SECURITY IMPLICATIONS:
      
      Currently it looks like an attacker can only crash a Redis server by
      providing specifically choosen commands. However a FF byte is written
      and there are other memory operations that depend on a wrong count, so
      even if it is not immediately apparent how to mount an attack in order
      to execute code remotely, it is not impossible at all that this could be
      done. Attacks always get better... and we did not spent enough time in
      order to think how to exploit this issue, but security researchers
      or malicious attackers could.
      c495d095
  9. 30 Jan, 2017 1 commit
  10. 13 Jan, 2017 1 commit
  11. 19 Dec, 2016 1 commit
  12. 16 Dec, 2016 2 commits
  13. 02 Jan, 2015 2 commits
    • Matt Stancliff's avatar
      Free ziplist test lists during tests · 0f15eb18
      Matt Stancliff authored
      Freeing our test lists helps keep valgrind output clean
      0f15eb18
    • Matt Stancliff's avatar
      Add ziplistMerge() · 9d2dc024
      Matt Stancliff authored
      This started out as #2158 by sunheehnus, but I kept rewriting it
      until I could understand things more easily and get a few more
      correctness guarantees out of the readability flow.
      
      The original commit created and returned a new ziplist with the contents of
      both input ziplists, but I prefer to grow one of the input ziplists
      and destroy the other one.
      
      So, instead of malloc+copy as in #2158, the merge now reallocs one of
      the existing ziplists and copies the other ziplist into the new space.
      
      Also added merge test cases to ziplistTest()
      9d2dc024
  14. 23 Dec, 2014 6 commits
    • Matt Stancliff's avatar
      Cleanup ziplist valgrind warnings · 9b786b12
      Matt Stancliff authored
      Valgrind can't detect 'memset' initializes things, so let's
      statically initialize them to remove some unnecessary warnings.
      9b786b12
    • Matt Stancliff's avatar
      Fix ziplist test for pop() · 1dfcd75a
      Matt Stancliff authored
      The previous test wasn't returning the new ziplist, so the test
      was invalid.  Now the test works properly.
      
      These problems were simultaenously discovered in #2154 and that
      PR also had an additional fix we included here.
      1dfcd75a
    • Matt Stancliff's avatar
      Fix ziplistDeleteRange index parameter · 53b1ee34
      Matt Stancliff authored
      It's valid to delete from negative offsets, so we *don't*
      want unsigned arguments here.
      53b1ee34
    • Matt Stancliff's avatar
      Fix how zipEntry returns values · fae53dea
      Matt Stancliff authored
      zipEntry was returning a struct, but that caused some
      problems with tests under 32 bit builds.
      
      The tests run better if we operate on structs allocated in the
      caller without worrying about copying on return.
      fae53dea
    • Matt Stancliff's avatar
      Allow all code tests to run using Redis args · 8febcffd
      Matt Stancliff authored
      Previously, many files had individual main() functions for testing,
      but each required being compiled with their own testing flags.
      That gets difficult when you have 8 different flags you need
      to set just to run all tests (plus, some test files required
      other files to be compiled aaginst them, and it seems some didn't
      build at all without including the rest of Redis).
      
      Now all individual test main() funcions are renamed to a test
      function for the file itself and one global REDIS_TEST define enables
      testing across the entire codebase.
      
      Tests can now be run with:
        - `./redis-server test <test>`
      
        e.g. ./redis-server test ziplist
      
      If REDIS_TEST is not defined, then no tests get included and no
      tests are included in the final redis-server binary.
      8febcffd
    • Matt Stancliff's avatar
      Remove ziplist compiler warnings · 8380655e
      Matt Stancliff authored
      Only happen when compiled with the test define.
      8380655e
  15. 29 Sep, 2014 2 commits
  16. 08 Aug, 2014 1 commit
  17. 19 Aug, 2013 1 commit
  18. 28 Jan, 2013 1 commit
  19. 19 Nov, 2012 1 commit
  20. 08 Nov, 2012 1 commit
  21. 13 Aug, 2012 2 commits
  22. 18 Jul, 2012 1 commit
    • antirez's avatar
      Don't assume that "char" is signed. · b62bdf1c
      antirez authored
      For the C standard char can be either signed or unsigned, it's up to the
      compiler, but Redis assumed that it was signed in a few places.
      
      The practical effect of this patch is that now Redis 2.6 will run
      correctly in every system where char is unsigned, notably the RaspBerry
      PI and other ARM systems with GCC.
      
      Thanks to Georgi Marinov (@eesn on twitter) that reported the problem
      and allowed me to use his RaspBerry via SSH to trace and fix the issue!
      b62bdf1c
  23. 14 Jun, 2012 1 commit
    • antirez's avatar
      ziplistFind(): don't assume that entries are comparable by encoding. · ba779119
      antirez authored
      Because Redis 2.6 introduced new integer encodings it is no longer true
      that if two entries have a different encoding they are not equal.
      
      An old ziplist can be loaded from an RDB file generated with Redis 2.4,
      in this case for instance a small unsigned integers is encoded with a
      16 bit encoding, while in Redis 2.6 a more specific 8 bit encoding
      format is used.
      
      Because of this bug hashes ended with duplicated values or fields lookup
      failed, causing many bad behaviors.
      This in turn caused a crash while converting the ziplist encoded hash into
      a real hash table because an assertion was raised on duplicated elements.
      
      This commit fixes issue #547.
      
      Many thanks to Pinterest's Marty Weiner and colleagues for discovering
      the problem and helping us in the debugging process.
      ba779119
  24. 06 May, 2012 1 commit
    • Pieter Noordhuis's avatar
      Compare integers in ziplist regardless of encoding · bf219416
      Pieter Noordhuis authored
      Because of the introduction of new integer encoding types for ziplists
      in the 2.6 tree, the same integer value may have a different encoding in
      different versions of the ziplist implementation. This means that the
      encoding can NOT be used as a fast path in comparing integers.
      bf219416
  25. 24 Apr, 2012 4 commits
  26. 23 Mar, 2012 1 commit
  27. 14 Feb, 2012 1 commit