1. 21 Jun, 2014 10 commits
  2. 09 Jun, 2014 4 commits
    • antirez's avatar
      Redis 2.9.55 (Redis 3.0.0 beta-6). · ea5335fb
      antirez authored
      ea5335fb
    • Matt Stancliff's avatar
      Fix lack of strtold under Cygwin · 726d343a
      Matt Stancliff authored
      Renaming strtold to strtod then casting
      the result is the standard way of dealing with
      no strtold in Cygwin.
      726d343a
    • Matt Stancliff's avatar
      Fix lack of SA_ONSTACK under Cygwin · 28fef5c5
      Matt Stancliff authored
      Fixes #232
      28fef5c5
    • Matt Stancliff's avatar
      Fix blocking operations from missing new lists · 7fc1fc8c
      Matt Stancliff authored
      Behrad Zari discovered [1] and Josiah reported [2]: if you block
      and wait for a list to exist, but the list creates from
      a non-push command, the blocked client never gets notified.
      
      This commit adds notification of blocked clients into
      the DB layer and away from individual commands.
      
      Lists can be created by [LR]PUSH, SORT..STORE, RENAME, MOVE,
      and RESTORE.  Previously, blocked client notifications were
      only triggered by [LR]PUSH.  Your client would never get
      notified if a list were created by SORT..STORE or RENAME or
      a RESTORE, etc.
      
      Blocked client notification now happens in one unified place:
        - dbAdd() triggers notification when adding a list to the DB
      
      Two new tests are added that fail prior to this commit.
      
      All test pass.
      
      Fixes #1668
      
      [1]: https://groups.google.com/forum/#!topic/redis-db/k4oWfMkN1NU
      [2]: #1668
      7fc1fc8c
  3. 07 Jun, 2014 2 commits
    • antirez's avatar
      Cluster: check that configEpoch never goes back. · 8b059f06
      antirez authored
      Since there are ways to alter the configEpoch outside of the failover
      procedure (for exampel CLUSTER SET-CONFIG-EPOCH and via the configEpoch
      collision resolution algorithm), make always sure, before replacing our
      configEpoch with a new one, that it is greater than the current one.
      8b059f06
    • antirez's avatar
      Cluster: SET-CONFIG-EPOCH should update currentEpoch. · 67029323
      antirez authored
      SET-CONFIG-EPOCH, used by redis-trib at cluster creation time, failed to
      update the currentEpoch, making it possible after a failover for a
      server to set its configEpoch to a value smaller than the current one
      (since configEpochs are obtained using currentEpoch).
      
      The bug totally break the Redis Cluster algorithms and protocols
      allowing for permanent split brain conditions about the slots
      configuration as shown in issue #1799.
      67029323
  4. 06 Jun, 2014 3 commits
  5. 05 Jun, 2014 1 commit
  6. 04 Jun, 2014 2 commits
    • antirez's avatar
      Fixed dbuf variable scope in luaRedisGenericCommand(). · 751c8698
      antirez authored
      I'm not sure if while the visibility is the inner block, the fact we
      point to 'dbuf' is a problem or not, probably the stack var isx
      guaranteed to live until the function returns. However obvious code is
      better anyway.
      751c8698
    • antirez's avatar
      Scripting: better Lua number -> string conversion in luaRedisGenericCommand(). · c3967f42
      antirez authored
      The lua_to*string() family of functions use a non optimal format
      specifier when converting integers to strings. This has both the problem
      of the number being converted in exponential notation, which we don't
      use as a Redis return value when floating point numbers are involed,
      and, moreover, there is a loss of precision since the default format
      specifier is not able to represent numbers that must be represented
      exactly in the IEEE 754 number mantissa.
      
      The new code handles it as a special case using a saner conversion.
      
      This fixes issue #1118.
      c3967f42
  7. 28 May, 2014 1 commit
  8. 26 May, 2014 3 commits
  9. 23 May, 2014 7 commits
  10. 20 May, 2014 7 commits
    • antirez's avatar
      Remove trailing spaces from scripting.c · d357e3ee
      antirez authored
      d357e3ee
    • antirez's avatar
      Remove trailing spaces from sentinel.c. · d0c84acc
      antirez authored
      d0c84acc
    • michael-grunder's avatar
      Fix LUA_OBJCACHE segfault. · 6f493951
      michael-grunder authored
      When scanning the argument list inside of a redis.call() invocation
      for pre-cached values, there was no check being done that the
      argument we were on was in fact within the bounds of the cache size.
      
      So if a redis.call() command was ever executed with more than 32
      arguments (current cache size #define setting) redis-server could
      segfault.
      6f493951
    • antirez's avatar
      Cluster: use clusterSetNodeAsMaster() during slave failover. · 8c6e8680
      antirez authored
      clusterHandleSlaveFailover() was reimplementing what
      clusterSetNodeAsMaster() without any good reason.
      8c6e8680
    • antirez's avatar
      Cluster: clear todo_before_sleep flags when executing actions. · 41a72416
      antirez authored
      Thanks to this change, when there is some code like:
      
          clusterDoBeforeSleep(CLUSTER_TODO_UPDATE_STATE|...);
          ... and later before returning to the event loop ...
          clusterUpdateState();
      
      The clusterUpdateState() function will clar the flag and will not be
      repeated in the clusterBeforeSleep() function. This especially important
      for config save/fsync flags which are slow to execute and not a good
      idea to repeat without a good reason.
      
      This is implemented for all the CLUSTER_TODO flags.
      41a72416
    • antirez's avatar
      Fixed typo in CLUSTER RESET implementation. · 5685d15a
      antirez authored
      5685d15a
    • antirez's avatar
      CLUSTER RESET implemented. · 5efa5501
      antirez authored
      The new command is able to reset a cluster node so that it starts again
      as a fresh node. By default the command performs a soft reset (the same
      as calling it as CLUSTER RESET SOFT), and the following steps are
      performed:
      
      1) All slots are set as unassigned.
      2) The list of known nodes is flushed.
      3) Node is set as master if it is a slave.
      
      When an hard reset is performed with CLUSTER RESET HARD the following
      additional operations are performed:
      
      4) A new Node ID is created at random.
      5) Epochs are set to 0.
      
      CLUSTER RESET is useful both when the sysadmin wants to reconfigure a
      node with a different role (for example turning a slave into a master)
      and for testing purposes.
      
      It also may play a role in automatically provisioned Redis Clusters,
      since it allows to reset a node back to the initial state in order to be
      reconfigured.
      5efa5501