- 20 Dec, 2016 2 commits
-
-
antirez authored
The same thing observed in #3551 by gnethercutt also fixed for GEOHASH as the original PR did.
-
antirez authored
There were two cases outlined in issue #3512 and PR #3551 where the Geo API returned unexpected results: empty strings where NULL replies were expected, or a single null reply where an array was expected. This violates the Redis principle that Redis replies for existing keys or elements should be indistinguishable. This is technically an API breakage so will be merged only into 4.0 and specified in the changelog in the list of breaking compatibilities, even if it is not very likely that actual code will be affected, hopefully, since with the past behavior basically there was to acconut for *both* the possibilities, and the new behavior is always one of the two, but in a consistent way.
-
- 19 Dec, 2016 7 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
You can still force the logo in the normal logs. For motivations, check issue #3112. For me the reason is that actually the logo is nice to have in interactive sessions, but inside the logs kinda loses its usefulness, but for the ability of users to recognize restarts easily: for this reason the new startup sequence shows a one liner ASCII "wave" so that there is still a bit of visual clue. Startup logging was modified in order to log events in more obvious ways, and to log more events. Also certain important informations are now more easy to parse/grep since they are printed in field=value style. The option --always-show-logo in redis.conf was added, defaulting to no.
-
antirez authored
-
Salvatore Sanfilippo authored
fix unsigned int overflow in adjustOpenFilesLimit
-
Salvatore Sanfilippo authored
Fixing typo in the usage of redis-benchmark
-
Salvatore Sanfilippo authored
Modify MIN->MAX
-
- 16 Dec, 2016 10 commits
-
-
antirez authored
This commit also contains other changes in order to conform the code to the Redis core style, specifically 80 chars max per line, smart conditionals in the same line: if (that) do_this();
-
Salvatore Sanfilippo authored
CoW improvement, stop AOFRW before flushing and parsing slave RDB
-
Salvatore Sanfilippo authored
Corrects a couple of omissions in the modules docs
-
antirez authored
The new algorithm provides the same speed with a smaller error for cardinalities in the range 0-100k. Before switching, the new and old algorithm behavior was studied in details in the context of issue #3677. You can find a few graphs and motivations there.
-
antirez authored
Otherwise for small cardinalities the algorithm will output something like, for example, 4.99 for a candinality of 5, that will be converted to 4 producing a huge error.
-
antirez authored
The PFADD now takes an array and has mandatory two arguments.
-
Harish Murthy authored
Config option to use LogLog-Beta Algorithm for Cardinality
-
Salvatore Sanfilippo authored
fixed stop condition in RM_ZsetRangeNext and RM_ZsetRangePrev
-
antirez authored
-
antirez authored
The commit improves ziplistRepr() and adds a new debugging subcommand so that we can trigger the dump directly from the Redis API. This command capability was used while investigating issue #3684.
-
- 14 Dec, 2016 3 commits
-
-
Dvir Volk authored
-
antirez authored
After the fix for #3673 the ttl var is always initialized inside the loop itself, so the early initialization is not needed. Variables declaration also moved to a more local scope.
-
Salvatore Sanfilippo authored
Reset the ttl for additional keys
-
- 13 Dec, 2016 5 commits
-
-
antirez authored
-
antirez authored
We need to use a dictionary type that frees the key, since we copy the keys in the dictionary we use to track expires created in the slave side.
-
antirez authored
-
antirez authored
-
antirez authored
BACKGROUND AND USE CASEj Redis slaves are normally write only, however the supprot a "writable" mode which is very handy when scaling reads on slaves, that actually need write operations in order to access data. For instance imagine having slaves replicating certain Sets keys from the master. When accessing the data on the slave, we want to peform intersections between such Sets values. However we don't want to intersect each time: to cache the intersection for some time often is a good idea. To do so, it is possible to setup a slave as a writable slave, and perform the intersection on the slave side, perhaps setting a TTL on the resulting key so that it will expire after some time. THE BUG Problem: in order to have a consistent replication, expiring of keys in Redis replication is up to the master, that synthesize DEL operations to send in the replication stream. However slaves logically expire keys by hiding them from read attempts from clients so that if the master did not promptly sent a DEL, the client still see logically expired keys as non existing. Because slaves don't actively expire keys by actually evicting them but just masking from the POV of read operations, if a key is created in a writable slave, and an expire is set, the key will be leaked forever: 1. No DEL will be received from the master, which does not know about such a key at all. 2. No eviction will be performed by the slave, since it needs to disable eviction because it's up to masters, otherwise consistency of data is lost. THE FIX In order to fix the problem, the slave should be able to tag keys that were created in the slave side and have an expire set in some way. My solution involved using an unique additional dictionary created by the writable slave only if needed. The dictionary is obviously keyed by the key name that we need to track: all the keys that are set with an expire directly by a client writing to the slave are tracked. The value in the dictionary is a bitmap of all the DBs where such a key name need to be tracked, so that we can use a single dictionary to track keys in all the DBs used by the slave (actually this limits the solution to the first 64 DBs, but the default with Redis is to use 16 DBs). This solution allows to pay both a small complexity and CPU penalty, which is zero when the feature is not used, actually. The slave-side eviction is encapsulated in code which is not coupled with the rest of the Redis core, if not for the hook to track the keys. TODO I'm doing the first smoke tests to see if the feature works as expected: so far so good. Unit tests should be added before merging into the 4.0 branch.
-
- 12 Dec, 2016 2 commits
-
-
Salvatore Sanfilippo authored
Fix redis-cli rare crash.
-
Yossi Gottlieb authored
This happens if the server (mysteriously) returns an unexpected response to the COMMAND command.
-
- 08 Dec, 2016 1 commit
-
-
Jan-Erik Rediger authored
Before, if a previous key had a TTL set but the current one didn't, the TTL was reused and thus resulted in wrong expirations set. This behaviour was experienced, when `MigrateDefaultPipeline` in redis-trib was set to >1 Fixes #3655
-
- 06 Dec, 2016 2 commits
-
-
Salvatore Sanfilippo authored
Add '\n' to MEMORY DOCTOR command output message
-
wangshaonan authored
is 0 or empty is 1
-
- 05 Dec, 2016 6 commits
-
-
itamar authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
The test now uses more diverse radius sizes, especially sizes near or greater the whole earth surface are used, that are known to trigger edge cases. Moreover the PRNG seeding was probably resulting into the same sequence tested over and over again, now seeding unsing the current unix time in milliseconds. Related to #3631.
-
antirez authored
A bug was reported in the context in issue #3631. The root cause of the bug was that certain neighbor boxes were zeroed after the "inside the bounding box or not" check, simply because the bounding box computation function was wrong. A few debugging infos where enhanced and moved in other parts of the code. A check to avoid steps=0 was added, but is unrelated to this issue and I did not verified it was an actual bug in practice.
-
- 02 Dec, 2016 1 commit
-
-
antirez authored
No longer makes sense since writable slaves only do local writes now: writes are no longer passed to sub-slaves in the stream.
-
- 01 Dec, 2016 1 commit
-
-
Chris Lamb authored
-