1. 01 Apr, 2020 1 commit
  2. 31 Mar, 2020 2 commits
    • Guy Benoish's avatar
      Modules: Test MULTI/EXEC replication of RM_Replicate · d6eb3afd
      Guy Benoish authored
      Makse sure call() doesn't wrap replicated commands with
      a redundant MULTI/EXEC
      
      Other, unrelated changes:
      1. Formatting compiler warning in INFO CLIENTS
      2. Use CLIENT_ID_AOF instead of UINT64_MAX
      d6eb3afd
    • antirez's avatar
      Fix module commands propagation double MULTI bug. · 9dcf878f
      antirez authored
      37a10cef introduced automatic wrapping of MULTI/EXEC for the
      alsoPropagate API. However this collides with the built-in mechanism
      already present in module.c. To avoid complex changes near Redis 6 GA
      this commit introduces the ability to exclude call() MUTLI/EXEC wrapping
      for also propagate in order to continue to use the old code paths in
      module.c.
      9dcf878f
  3. 27 Mar, 2020 6 commits
  4. 25 Mar, 2020 1 commit
    • antirez's avatar
      PSYNC2: meaningful offset implemented. · 57fa355e
      antirez authored
      A very commonly signaled operational problem with Redis master-replicas
      sets is that, once the master becomes unavailable for some reason,
      especially because of network problems, many times it wont be able to
      perform a partial resynchronization with the new master, once it rejoins
      the partition, for the following reason:
      
      1. The master becomes isolated, however it keeps sending PINGs to the
      replicas. Such PINGs will never be received since the link connection is
      actually already severed.
      2. On the other side, one of the replicas will turn into the new master,
      setting its secondary replication ID offset to the one of the last
      command received from the old master: this offset will not include the
      PINGs sent by the master once the link was already disconnected.
      3. When the master rejoins the partion and is turned into a replica, its
      offset will be too advanced because of the PINGs, so a PSYNC will fail,
      and a full synchronization will be required.
      
      Related to issue #7002 and other discussion we had in the past around
      this problem.
      57fa355e
  5. 18 Mar, 2020 1 commit
    • WuYunlong's avatar
      Fix master replica inconsistency for upgrading scenario. · f6029fb9
      WuYunlong authored
      Before this commit, when upgrading a replica, expired keys will not
      be loaded, thus causing replica having less keys in db. To this point,
      master and replica's keys is logically consistent. However, before
      the keys in master and replica are physically consistent, that is,
      they have the same dbsize, if master got a problem and the replica
      got promoted and becomes new master of that partition, and master
      updates a key which does not exist on master, but physically exists
      on the old master(new replica), the old master would refuse to update
      the key, thus causing master and replica data inconsistent.
      
      How could this happen?
      That's all because of the wrong judgement of roles while starting up
      the server. We can not use server.masterhost to judge if the server
      is master or replica, since it fails in cluster mode.
      
      When we start the server, we load rdb and do want to load expired keys,
      and do not want to have the ability to active expire keys, if it is
      a replica.
      f6029fb9
  6. 16 Mar, 2020 1 commit
  7. 04 Mar, 2020 2 commits
  8. 03 Mar, 2020 1 commit
  9. 24 Feb, 2020 1 commit
  10. 19 Feb, 2020 1 commit
  11. 11 Feb, 2020 2 commits
  12. 10 Feb, 2020 1 commit
  13. 07 Feb, 2020 2 commits
  14. 06 Feb, 2020 1 commit
    • Guy Benoish's avatar
      Diskless-load emptyDb-related fixes · 92dc5e1f
      Guy Benoish authored
      1. Call emptyDb even in case of diskless-load: We want modules
         to get the same FLUSHDB event as disk-based replication.
      2. Do not fire any module events when flushing the backups array.
      3. Delete redundant call to signalFlushedDb (Called from emptyDb).
      92dc5e1f
  15. 05 Feb, 2020 1 commit
  16. 04 Feb, 2020 2 commits
  17. 03 Feb, 2020 1 commit
    • Guy Benoish's avatar
      Exclude "keymiss" notification from NOTIFY_ALL · 2fda5f5c
      Guy Benoish authored
      Because "keymiss" is "special" compared to the rest of
      the notifications (Trying not to break existing apps
      using the 'A' format for notifications)
      
      Also updated redis.conf and module.c docs
      2fda5f5c
  18. 02 Feb, 2020 1 commit
  19. 28 Jan, 2020 1 commit
  20. 27 Jan, 2020 1 commit
  21. 18 Dec, 2019 2 commits
  22. 17 Dec, 2019 3 commits
  23. 09 Dec, 2019 1 commit
  24. 28 Nov, 2019 1 commit
    • Oran Agra's avatar
      Converting more configs to use generic infra, and moving defaults to config.c · 18e72c5c
      Oran Agra authored
      Changes in behavior:
      - Change server.stream_node_max_entries from int64_t to long long, so that it can be used by the generic infra
      - standard error reply instead of "repl-backlog-size must be 1 or greater" and such
      - tls-port and a few TLS booleans were readable (config get) even when USE_OPENSSL was off (now they aren't)
      - syslog-enabled, syslog-ident, cluster-enabled, appendfilename, and supervised didn't have a get (now they do)
      - pidfile was initialized to NULL in InitServerConfig but had CONFIG_DEFAULT_PID_FILE in rewriteConfig (so the real default was "", but rewrite would cause it to be set), fixed the rewrite.
      - TLS config in server.h was uninitialized (if no tls config args were provided)
      
      Adding test for sanity and coverage
      18e72c5c
  25. 26 Nov, 2019 1 commit
    • Oran Agra's avatar
      Additional config.c refactory and bugfixes · e0cc3c99
      Oran Agra authored
      - add capability for each config to have a callback to check if value is valid and return error string
        will enable converting many of the remaining custom configs into generic ones (reducing the x4 repetition for set,get,config,rewrite)
      - add capability for each config to  to run some update code after config is changed (only for CONFIG SET)
        will also enable converting many of the remaining custom configs into generic ones
      - add capability to move default values from server.h and server.c to config.c
        will reduce many excess lines in server.h and server.c (plus, no need to rebuild the entire code base when a default change 8-))
      
      other behavior changes:
      - fix bug in bool config get (always returning 'yes')
      - fix a bug in modifying jemalloc-bg-thread at runtime (didn't call set_jemalloc_bg_thread, due to bad merge conflict resolution (my fault))
      - side effect when a failed attempt to enable activedefrag at runtime, we now respond with -ERR and not with -DISABLED
      e0cc3c99
  26. 22 Nov, 2019 2 commits