1. 27 Mar, 2020 7 commits
  2. 25 Mar, 2020 3 commits
    • Oran Agra's avatar
      AOFRW on an empty stream created with MKSTREAM loads badkly · 3b29556a
      Oran Agra authored
      the AOF will be loaded successfully, but the stream will be missing,
      i.e inconsistencies with the original db.
      
      this was because XADD with id of 0-0 would error.
      
      add a test to reproduce.
      3b29556a
    • antirez's avatar
      PSYNC2: meaningful offset implemented. · 57fa355e
      antirez authored
      A very commonly signaled operational problem with Redis master-replicas
      sets is that, once the master becomes unavailable for some reason,
      especially because of network problems, many times it wont be able to
      perform a partial resynchronization with the new master, once it rejoins
      the partition, for the following reason:
      
      1. The master becomes isolated, however it keeps sending PINGs to the
      replicas. Such PINGs will never be received since the link connection is
      actually already severed.
      2. On the other side, one of the replicas will turn into the new master,
      setting its secondary replication ID offset to the one of the last
      command received from the old master: this offset will not include the
      PINGs sent by the master once the link was already disconnected.
      3. When the master rejoins the partion and is turned into a replica, its
      offset will be too advanced because of the PINGs, so a PSYNC will fail,
      and a full synchronization will be required.
      
      Related to issue #7002 and other discussion we had in the past around
      this problem.
      57fa355e
    • antirez's avatar
      Explain why we allow transactions in -BUSY state. · f15042db
      antirez authored
      Related to #7022.
      f15042db
  3. 23 Mar, 2020 8 commits
  4. 22 Mar, 2020 3 commits
  5. 20 Mar, 2020 2 commits
  6. 18 Mar, 2020 3 commits
    • hwware's avatar
      fix potentical memory leak in redis-cli · 86691ccf
      hwware authored
      86691ccf
    • Guy Benoish's avatar
      f16eaadd
    • WuYunlong's avatar
      Fix master replica inconsistency for upgrading scenario. · f6029fb9
      WuYunlong authored
      Before this commit, when upgrading a replica, expired keys will not
      be loaded, thus causing replica having less keys in db. To this point,
      master and replica's keys is logically consistent. However, before
      the keys in master and replica are physically consistent, that is,
      they have the same dbsize, if master got a problem and the replica
      got promoted and becomes new master of that partition, and master
      updates a key which does not exist on master, but physically exists
      on the old master(new replica), the old master would refuse to update
      the key, thus causing master and replica data inconsistent.
      
      How could this happen?
      That's all because of the wrong judgement of roles while starting up
      the server. We can not use server.masterhost to judge if the server
      is master or replica, since it fails in cluster mode.
      
      When we start the server, we load rdb and do want to load expired keys,
      and do not want to have the ability to active expire keys, if it is
      a replica.
      f6029fb9
  7. 16 Mar, 2020 4 commits
  8. 15 Mar, 2020 3 commits
  9. 13 Mar, 2020 1 commit
  10. 12 Mar, 2020 3 commits
  11. 11 Mar, 2020 1 commit
  12. 07 Mar, 2020 1 commit
  13. 05 Mar, 2020 1 commit