- 04 May, 2021 1 commit
-
-
yoav-steinberg authored
When client breached the output buffer soft limit but then went idle, we didn't disconnect on soft limit timeout, now we do. Note this also resolves some sporadic test failures in due to Linux buffering data which caused tests to fail if during the test we went back under the soft COB limit. Co-authored-by:
Oran Agra <oran@redislabs.com> Co-authored-by:
sundb <sundbcn@gmail.com>
-
- 03 May, 2021 6 commits
-
-
Oran Agra authored
-
Oran Agra authored
An integer overflow bug in Redis version 6.0 or newer could be exploited using the STRALGO LCS command to corrupt the heap and potentially result with remote code execution.
-
Oran Agra authored
An integer overflow bug in Redis 6.2 could be exploited to corrupt the heap and potentially result with remote code execution. The vulnerability involves changing the default set-max-intset-entries configuration value, creating a large set key that consists of integer values and using the COPY command to duplicate it. The integer overflow bug exists in all versions of Redis starting with 2.6, where it could result with a corrupted RDB or DUMP payload, but not exploited through COPY (which did not exist before 6.2).
-
Wen Hui authored
-
Uri Shachar authored
-
Binbin authored
This fix is in dead code. see redisOutOfMemoryHandler an allocation can't fail. but maybe someone will copy this code to a different project some day, better have this fixed Co-authored-by:
Oran Agra <oran@redislabs.com>
-
- 02 May, 2021 1 commit
-
-
sundb authored
-
- 29 Apr, 2021 2 commits
- 28 Apr, 2021 3 commits
-
-
Binbin authored
missing zfree(data) in redis-benchmark. And also correct the wrong size in lrange. the text mentioned 500, but size was 450, changed to 500
-
Binbin authored
When redis-cli was used with both -c (cluster) and -s (unix socket), it would have kept trying to use that unix socket, even if it got redirected by the cluster (resulting in an infinite loop).
-
filipe oliveira authored
- Immediately exit on errors that are not related to topology updates. - Deprecates the `-e` option ( retro compatible ) and warns that we now exit immediately on errors that are not related to topology updates. - Fixed wrongfully failing on config fetch error (warning only). This only affects RE. Bottom line: - MOVED and ASK errors will not show any warning (unlike the throttled error with `-e` before). - CLUSTERDOWN still prints an error unconditionally and sleeps for 1 second. - other errors are fatal.
-
- 27 Apr, 2021 3 commits
-
-
Andy Pan authored
-
avimredis authored
-
Oran Agra authored
This solves an issue reported in #8712 in which a replica would bypass the client write pause check and cause an assertion due to executing a write command during failover. The fact is that we don't expect replicas to execute any command other than maybe REPLCONF and PING, etc. but matching against the ADMIN command flag is insufficient, so instead i just block keyspace access for now.
-
- 26 Apr, 2021 6 commits
-
-
sundb authored
-
avimredis authored
When [WITHCOORD] [WITHDIST] [WITHHASH] are used, the error mentioned GEORADIUS command
-
Yossi Gottlieb authored
-
sundb authored
-
Andy Pan authored
Most of the ae.c backends didn't explicitly handle errors, and instead ignored all errors and did an implicit retry. This is desired for EAGAIN and EINTER, but in case of other systematic errors, we prefer to fail and log the error we got rather than get into a busy loop.
-
Huang Zhw authored
Fix clusterProcessPacket log don't distinguish between pong and meet. Additionally log node name instead of pointer and delete a redundant log.
-
- 25 Apr, 2021 5 commits
-
-
Huang Zhw authored
-
Yang Bodong authored
-
ZheNing Hu authored
After sorting, each item in picks is sorted according to its index. In the original code logic, we traverse from the first element of ziplist until `zipindex == picks[pickindex].index`. We may be able to start directly in `picks[0].index`, this will bring small performance improvement. Signed-off-by:
ZheNing Hu <adlternative@gmail.com>
-
sundb authored
This change does not fix any bugs. 1. ```moduleUnload``` should return ```C_OK``` or ```C_ERR```, not ```REDISMODULE_ERR``` or ```REDISMODULE_OK```. 2. The ```where``` parameter of ```listTypePush``` and ```listTypePop``` should be ```LIST_HEAD``` or ```LIST_TAIL```
-
Istemi Ekin Akkus authored
-
- 24 Apr, 2021 1 commit
-
-
bugwz authored
-
- 22 Apr, 2021 2 commits
-
-
zyxwvu Shi authored
This prevents a case where NTP moves the system clock forward resulting in a false detection of a busy script. Signed-off-by:
zyxwvu Shi <i@shiyc.cn>
-
Wang Yuan authored
Modules event subscribers may get wrong things in notifyKeyspaceEvent callback, such as wrong number of keys, or be able to lookup this key. This commit changes the order to be like the one in evict.c. Cleanup: Since we know the key exists (it expires now), db*Delete is sure to return 1, so there's no need to check it's output (misleading).
-
- 21 Apr, 2021 6 commits
-
-
Ikko Ashimine authored
-
xsddz authored
-
Uri Shachar authored
-
Seunghyun Lee authored
-
Oran Agra authored
the anetGenericAccept return ANET_ERR but outside use constant -1 Co-authored-by:
libo <buaa_libo@126.com>
-
Andy Pan authored
code cleanup in anetGenericAccept
-
- 20 Apr, 2021 4 commits
-
-
bugwz authored
When redis-check-aof finds an error, it prints the line number for faster troubleshooting.
-
Huang Zhw authored
This scene is hard to happen. When first attempt some keys expired, only kv position is updated not ov. Then socket err happens, second attempt is taken. This time kv items may be mismatching with ov items.
-
Madelyn Olson authored
Interior rax pointers were not being freed
-
Bonsai authored
-