- 04 Jun, 2021 1 commit
-
-
Wen Hui authored
-
- 03 Jun, 2021 2 commits
- 02 Jun, 2021 2 commits
-
-
Huang Zhw authored
In clusterManagerCommandImport strcat was used to concat COPY and REPLACE, the space maybe not enough. If we use --cluster-replace but not --cluster-copy, the MIGRATE command contained COPY instead of REPLACE.
-
pgxiaolianzi authored
-
- 01 Jun, 2021 6 commits
-
-
Oran Agra authored
-
zhaozhao.zz authored
-
zhaozhao.zz authored
-
zhaozhao.zz authored
-
Oran Agra authored
An integer overflow bug in Redis version 6.0 or newer can be exploited using the STRALGO LCS command to corrupt the heap and potentially result with remote code execution. This is a result of an incomplete fix by CVE-2021-29477.
-
Oran Agra authored
The test that was merged yesterday fails with valgrind and freebsd CI that are too slow, and 10 seconds apparently passed between the time the command was sent to redis and the time it was actually executed. ``` *** [err]: All TTL in commands are propagated as absolute timestamp in replication stream in tests/unit/expire.tcl Expected 'del a' to match 'set foo1 bar PXAT *' (context: type source line 778 file /home/runner/work/redis/redis/tests/test_helper.tcl cmd {assert_match [lindex $patterns $j] [read_from_replication_stream $s]} proc ::assert_replication_stream level 1) ```
-
- 30 May, 2021 3 commits
-
-
Binbin authored
Without this fix, FLUSHALL ASYNC would have freed these in a background thread, even if they didn't contain many elements (unlike how it works with other structures), which could be inefficient.
-
Wang Yuan authored
Make aof rewrite buffer memory size more accurate, before, there may be 20% deviation with its real memory usage. The implication are both lower memory usage, and also a more accurate INFO.
-
ny0312 authored
Till now, on replica full-sync we used to transfer absolute time for TTL, however when a command arrived (EXPIRE or EXPIREAT), we used to propagate it as is to replicas (possibly with relative time), but always translate it to EXPIREAT (absolute time) to AOF. This commit changes that and will always use absolute time for propagation. see discussion in #8433 Furthermore, we Introduce new commands: `EXPIRETIME/PEXPIRETIME` that allow extracting the absolute TTL time from a key.
-
- 26 May, 2021 1 commit
-
-
YaacovHazan authored
In diskless replication, we create a read pipe for the RDB, between the child and the parent. When we close this pipe (fd), the read handler also needs to be removed from the event loop (if it still registered). Otherwise, next time we will use the same fd, the registration will be fail (panic), because we will use EPOLL_CTL_MOD (the fd still register in the event loop), on fd that already removed from epoll_ctl
-
- 24 May, 2021 1 commit
-
-
Wen Hui authored
fix for recent breakage from #8958, did a mistake when updating the pr.
-
- 23 May, 2021 1 commit
-
-
Wen Hui authored
-
- 22 May, 2021 1 commit
-
-
wuYin authored
Already verified that start < len, so if end >= len, then start cannot be > len.
-
- 20 May, 2021 3 commits
-
-
YaacovHazan authored
When test stop 'load handler' by killing the process that generating the load, some commands that already in the input buffer, still might be processed by the server. This may cause some instability in tests, that count on that no more commands processed after we stop the `load handler' In this commit, new proc 'wait_load_handlers_disconnected' added, to verify that no more cammands from any 'load handler' prossesed, by checking that the clients who genreate the load is disconnceted. Also, replacing check of dbsize with wait_for_ofs_sync before comparing debug digest, as it would fail in case the last key the workload wrote was an overridden key (not a new one). Affected tests Race fix: - failover command to specific replica works - Connect multiple replicas at the same time (issue #141), master diskless=$mdl, replica diskless=$sdl - AOF rewrite during write load: RDB preamble=$rdbpre Cleanup and speedup: - Test replication with blocking lists and sorted sets operations - Test replication with parallel clients writing in different DBs - Test replication partial resync: $descr (diskless: $mdl, $sdl, reconnect: $reconnect
-
Wang Yuan authored
In theory we should have used zmalloc_usable_size, but it may be slower, and now after #7875, there's no actual difference. So this change isn't making a dramatic change. Co-authored-by:
Oran Agra <oran@redislabs.com>
-
Wang Yuan authored
According jemalloc size classes, we may allocate much more memory than our setting of repl_backlog_size, but we don't make full use of it.
-
- 19 May, 2021 5 commits
-
-
Madelyn Olson authored
Redact commands that include sensitive data from slowlog and monitor
-
Oran Agra authored
I recently saw this failure: [err]: lazy free a stream with all types of metadata in tests/unit/lazyfree.tcl Expected '2' to be equal to '1' (context: type eval line 23 cmd {assert_equal [s lazyfreed_objects] 1} proc ::test) The only explanation for such a thing is that the async flushdb wasn't done before we did the resetstat
-
Huang Zhw authored
which make interleaved_len bigger and may access array out of range.
-
Bonsai authored
-
DarrenJiang13 authored
when string2ll was made to replace isStringRepresentableAsLongLong (which was similar to what rdbTryIntegerEncoding does), rdbTryIntegerEncoding was probably forgotten.
-
- 18 May, 2021 8 commits
-
-
Binbin authored
incrementing the defragged hits counter twice in activeDefragSdsListAndDict
-
Eduardo Felipe authored
Add documentation for `firstkey`, `lastkey` and `keystep` parameters of `RedisModule_CreateCommand` (#8883) These parameters of RedisModule_CreateCommand were previously undocumented but they are needed for ACL to check permission on keys and by Redis Cluster to figure our how to route the command. Co-authored-by:
Eduardo Felipe Castegnaro <edufelipe@onsign.tv> Co-authored-by:
Oran Agra <oran@redislabs.com>
-
Guy Korland authored
This parameter of type GeoHashRadius is 192 bytes - passing a `const` pointer instead.
-
Oran Agra authored
the test normally passes. but we saw one failure in a valgrind run in github actions
-
Oran Agra authored
As far as i can tell it shows up in redis-cli in both HELP, e.g. `help client list`, and also in the command completion tips, but it is unclear what it was needed for. It exists since the very first commit that added this mechanism.
-
Oran Agra authored
-
Huang Zhw authored
Currently in redis-cli only AUTH and ACL SETUSER bypass history file. We add CONFIG SET masterauth/masteruser/requirepass, HELLO with AUTH, MIGRATE with AUTH or AUTH2 to bypass history file too. The drawback is HELLO and MIGRATE's code is a mess. Someday if we change these commands, we have to change here too.
-
Binbin authored
There's an infinite loop when redis-cli fails to connect in cluster mode. This commit adds a 1 second sleep to prevent flooding the console with errors. It also adds a specific error print in a few places that could have error without printing anything. Co-authored-by:
Oran Agra <oran@redislabs.com>
-
- 17 May, 2021 3 commits
-
-
zhaozhao.zz authored
Improve performance by avoiding inefficiencies in the parent process during AOFRW. * AOF: record the latency of aofChildWriteDiffData * AOF: avoid memmove in aofChildWriteDiffData
-
Oran Agra authored
And also add tests to cover lazy free of streams with various types of metadata (see #8932)
-
Huang Zhw authored
There are two bugs in redis-cli hints: * The hints of commands with subcommands lack first params. * When search matching command of currently input, we should find the command with longest matching prefix. If not COMMAND INFO will always match COMMAND and display no hints.
-
- 15 May, 2021 1 commit
-
-
patpatbear authored
this patch fixes sinterstore by add missing keyspace del event when any source set not exists. Co-authored-by:
srzhao <srzhao@sysnew.com>
-
- 14 May, 2021 1 commit
-
-
Madelyn Olson authored
Moved security bugs and vulnerability policy to SECURITY.MD and extended security policy. Co-authored-by:
Yossi Gottlieb <yossigo@gmail.com>
-
- 13 May, 2021 1 commit
-
-
Raghav Muddur authored
* EVALSHA_RO and EVAL_RO Commands Added new readonly versions of EVAL and EVALSHA.
-