- 10 Jul, 2018 3 commits
-
-
antirez authored
To simplify the semantics of blocking for a group, this commit changes the implementation to better match the description we provide of conusmer groups: blocking for > will make the consumer waiting for new elements in the group. However blocking for any other ID will always serve the local history of the consumer. However it must be noted that the > ID is actually an alias for the special ID ms/seq of UINT64_MAX,UINT64_MAX.
-
antirez authored
To detect when the group (or the whole key) is destroyed to send an error to the consumers blocked in such group is a problem, so we leave the consumers listening, the sysadmin is free to create or destroy groups assuming she/he knows what to do. However a client may be blocked in a given consumer group, that is later destroyed. Then the stream receives new elements. In that case there is no sane behavior to serve the consumer... but to report an error about the group no longer existing. More about detecting this synchronously and why it is not done: 1. Normally we don't do that, we leave clients blocked for other data types such as lists. 2. When we free a stream object there is no longer information about what was the key it was associated with, so while destroying the consumer groups we miss the info to unblock the clients in that moment. 3. Objects can be reclaimed in other threads where it is no longer safe to do client operations.
-
antirez authored
When a client blocks for a consumer group, we don't know the actual ID we want to be served: other clients blocked in the same consumer group may be served first, so the consumer group latest delivered ID changes. This was not handled correctly, all the clients in the consumer group were unblocked without data but the first.
-
- 09 Jul, 2018 7 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
We need CC_QUIET in order to fix #5096 by silently failing if needed.
-
Amit Dey authored
http://help.github.com/send-pull-requests/ is no longer supported this change modifies the link to the working one https://help.github.com/articles/creating-a-pull-request/
-
dejun.xdj authored
-
minkikim89 authored
-
WuYunlong authored
-
- 04 Jul, 2018 12 commits
-
-
antirez authored
-
antirez authored
With such information will be able to use a private localtime() implementation serverLog(), which does not use any locking and is both thread and fork() safe.
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
- 03 Jul, 2018 7 commits
-
-
Jack Drogon authored
-
antirez authored
-
antirez authored
-
Salvatore Sanfilippo authored
limit the size of pending-querybuf in masterclient
-
antirez authored
PR #5081 fixes an "interesting" bug about Redis Cluster failover but in general about the updating of repl_down_since, that is used in order to count the time a slave was left disconnected from its master. While the fix provided resolves the specific issue, in general the validity of repl_down_since is limited to states that are different than the state CONNECTED, and the disconnected time is set when the state is DISCONNECTED. However from CONNECTED to other states, the state machine must always go to DISCONNECTED first. So it makes sense to set the field to zero (since it is meaningless in that context) when the state is set to CONNECTED.
-
Salvatore Sanfilippo authored
cluster failover bug
-
chendianqiang authored
-
- 02 Jul, 2018 6 commits
-
-
antirez authored
-
Salvatore Sanfilippo authored
Module command help
-
Salvatore Sanfilippo authored
Added link to Google Group
-
Salvatore Sanfilippo authored
fix empty string for sentinel rename-command
-
Salvatore Sanfilippo authored
fix tests/test_helper.tcl with --wait-server option.
-
WuYunlong authored
Issue #5063 added --wait-server option, but can not work.
-
- 01 Jul, 2018 1 commit
-
-
chendianqiang authored
-
- 30 Jun, 2018 2 commits
- 29 Jun, 2018 2 commits
-
-
antirez authored
Making it more similar to KILL.
-
Salvatore Sanfilippo authored
FEATURE: implements client list type option
-