1. 26 Jan, 2021 1 commit
    • Wen Hui's avatar
      Sentinel: Fix Config Dependency and Rewrite Sequence (#8271) · 1aad55b6
      Wen Hui authored
      This commit fixes a well known and an annoying issue in Sentinel mode.
      
      Cause of this issue:
      Currently, Redis rewrite process works well in server mode, however in sentinel mode,
      the sentinel config has variant semantics for different configurations, in example configuration
      https://github.com/redis/redis/blob/unstable/sentinel.conf, we put comments on these.
      However the rewrite process only treat the sentinel config as a single option. During rewrite
      process, it will mess up with the lines and comments.
      
      Approaches:
      In order to solve this issue, we need to differentiate different subconfig options in sentinel separately,
      for example, sentinel monitor <master-name> <ip> <redis-port> <quorum>
      we can treat it as sentinel monitor option, instead of the sentinel option.
      
      This commit also fixes the dependency issue when putting configurations in sentinel.conf.
      For example before this commit,we must put
      `sentinel monitor <master-name> <ip> <redis-port> <quorum>` before
      `sentinel auth-pass <master-name> <password>` for a single master,
      otherwise the server cannot start and will return error. This commit fixes this issue, as long as
      the monitoring master was configured, no matter the sequence is, the sentinel can start and run properly.
      1aad55b6
  2. 19 Jan, 2021 1 commit
  3. 07 Oct, 2019 1 commit
  4. 30 Mar, 2015 1 commit
  5. 29 Sep, 2014 1 commit
  6. 18 Jun, 2014 1 commit
  7. 29 Apr, 2014 1 commit
  8. 24 Apr, 2014 1 commit
    • antirez's avatar
      Sentinel test files / directories layout improved. · 897adc1c
      antirez authored
      The test now runs in a self-contained directory.
      The general abstractions to run the tests in an environment where
      mutliple instances are executed at the same time was extrapolated into
      instances.tcl, that will be reused to test Redis Cluster.
      897adc1c