1. 26 Sep, 2018 1 commit
  2. 25 Sep, 2018 5 commits
  3. 24 Sep, 2018 4 commits
  4. 21 Sep, 2018 1 commit
  5. 19 Sep, 2018 2 commits
  6. 18 Sep, 2018 3 commits
  7. 17 Sep, 2018 2 commits
  8. 30 Jul, 2018 1 commit
  9. 16 Jul, 2018 1 commit
    • Oran Agra's avatar
      slave buffers were wasteful and incorrectly counted causing eviction · bf680b6f
      Oran Agra authored
      A) slave buffers didn't count internal fragmentation and sds unused space,
         this caused them to induce eviction although we didn't mean for it.
      
      B) slave buffers were consuming about twice the memory of what they actually needed.
      - this was mainly due to sdsMakeRoomFor growing to twice as much as needed each time
        but networking.c not storing more than 16k (partially fixed recently in 237a38737).
      - besides it wasn't able to store half of the new string into one buffer and the
        other half into the next (so the above mentioned fix helped mainly for small items).
      - lastly, the sds buffers had up to 30% internal fragmentation that was wasted,
        consumed but not used.
      
      C) inefficient performance due to starting from a small string and reallocing many times.
      
      what i changed:
      - creating dedicated buffers for reply list, counting their size with zmalloc_size
      - when creating a new reply node from, preallocate it to at least 16k.
      - when appending a new reply to the buffer, first fill all the unused space of the
        previous node before starting a new one.
      
      other changes:
      - expose mem_not_counted_for_evict info field for the benefit of the test suite
      - add a test to make sure slave buffers are counted correctly and that they don't cause eviction
      bf680b6f
  10. 03 Jul, 2018 1 commit
  11. 02 Jul, 2018 1 commit
  12. 21 Jun, 2018 1 commit
  13. 19 Jun, 2018 1 commit
  14. 09 Jun, 2018 1 commit
  15. 07 Jun, 2018 1 commit
  16. 13 Apr, 2018 3 commits
  17. 12 Apr, 2018 1 commit
  18. 11 Apr, 2018 3 commits
  19. 09 Apr, 2018 3 commits
  20. 05 Apr, 2018 1 commit
  21. 01 Apr, 2018 2 commits
  22. 31 Mar, 2018 1 commit