1. 28 Apr, 2021 3 commits
    • Binbin's avatar
      redis-benchmark: Add zfree(data) and fix lrange size / text mismatch (#8872) · 1eff8564
      Binbin authored
      missing zfree(data) in redis-benchmark.
      
      And also correct the wrong size in lrange.
      the text mentioned 500, but size was 450, changed to 500
      1eff8564
    • Binbin's avatar
      redis-cli: Do not use hostsocket when we got redirected in cluster mode (#8870) · 416f2773
      Binbin authored
      When redis-cli was used with both -c (cluster) and -s (unix socket),
      it would have kept trying to use that unix socket, even if it got
      redirected by the cluster (resulting in an infinite loop).
      416f2773
    • filipe oliveira's avatar
      redis-benchmark: Error/Warning handling updates. (#8869) · ef6f9023
      filipe oliveira authored
      - Immediately exit on errors that are not related to topology updates.
      - Deprecates the `-e` option ( retro compatible ) and warns that we now
        exit immediately on errors that are not related to topology updates.
      - Fixed wrongfully failing on config fetch error (warning only). This only affects RE.
      
      Bottom line:
      - MOVED and ASK errors will not show any warning (unlike the throttled error with `-e` before).
      - CLUSTERDOWN still prints an error unconditionally and sleeps for 1 second.
      - other errors are fatal.
      ef6f9023
  2. 27 Apr, 2021 3 commits
  3. 26 Apr, 2021 6 commits
  4. 25 Apr, 2021 5 commits
  5. 24 Apr, 2021 1 commit
  6. 22 Apr, 2021 2 commits
  7. 21 Apr, 2021 6 commits
  8. 20 Apr, 2021 4 commits
  9. 19 Apr, 2021 5 commits
    • Viktor Söderqvist's avatar
    • Hanna Fadida's avatar
      Modules: adding a module type for key space notification (#8759) · 53a4d6c3
      Hanna Fadida authored
      Adding a new type mask ​for key space notification, REDISMODULE_NOTIFY_MODULE, to enable unique notifications from commands on REDISMODULE_KEYTYPE_MODULE type keys (which is currently unsupported).
      
      Modules can subscribe to a module key keyspace notification by RM_SubscribeToKeyspaceEvents,
      and clients by notify-keyspace-events of redis.conf or via the CONFIG SET, with the characters 'd' or 'A' 
      (REDISMODULE_NOTIFY_MODULE type mask is part of the '**A**ll' notation for key space notifications).
      
      Refactor: move some pubsub test infra from pubsub.tcl to util.tcl to be re-used by other tests.
      53a4d6c3
    • guybe7's avatar
      Modules: Replicate lazy-expire even if replication is not allowed (#8816) · f40ca9cb
      guybe7 authored
      Before this commit using RM_Call without "!" could cause the master
      to lazy-expire a key (delete it) but without replicating to replicas.
      This could cause the replica's memory usage to gradually grow and
      could also cause consistency issues if the master and replica have
      a clock diff.
      This bug was introduced in #8617
      
      Added a test which demonstrates that scenario.
      f40ca9cb
    • Harkrishn Patro's avatar
      ACL channels permission handling for save/load scenario. (#8794) · 7a3d1487
      Harkrishn Patro authored
      
      
      In the initial release of Redis 6.2 setting a user to only allow pubsub access to
      a specific channel, and doing ACL SAVE, resulted in an assertion when
      ACL LOAD was used. This was later changed by #8723 (not yet released),
      but still not properly resolved (now it errors instead of crash).
      
      The problem is that the server that generates an ACL file, doesn't know what
      would be the setting of the acl-pubsub-default config in the server that will load it.
      so ACL SAVE needs to always start with resetchannels directive.
      
      This should still be compatible with old acl files (from redis 6.0), and ones from earlier
      versions of 6.2 that didn't mess with channels.
      Co-authored-by: default avatarHarkrishn Patro <harkrisp@amazon.com>
      Co-authored-by: default avatarOran Agra <oran@redislabs.com>
      7a3d1487
    • Wen Hui's avatar
      fix invalid master_link_down_since_seconds in info repication (#8785) · 0413fbc7
      Wen Hui authored
      When replica never successfully connect to master, server.repl_down_since
      will be initialized to 0, therefore, the info master_link_down_since_seconds
      was showing the current unix timestamp, which does not make much sense.
      
      This commit fixes the issue by showing master_link_down_since_seconds to -1.
      means the replica never connect to master before.
      
      This commit also resets this variable back to 0 when a replica is turned into
      a master, so that it'll behave the same if the master is later turned into a
      replica again.
      
      The implication of this change is that if some app is checking if the value is > 60
      do something, like conclude the replica is stale, this could case harm (changing
      a big positive number with a small one).
      0413fbc7
  10. 16 Apr, 2021 1 commit
  11. 15 Apr, 2021 4 commits