- 25 Jan, 2014 1 commit
- 
- 
antirez authored
 
- 
- 24 Jan, 2014 1 commit
- 
- 
antirez authored
 
- 
- 22 Jan, 2014 6 commits
- 
- 
antirez authored
- 
antirez authored
- 
antirez authored
- 
antirez authored
- 
antirez authored
- 
antirez authoredIncremental flushing in rio.c is only used to avoid huge kernel buffers synched to slow disks creating big latency spikes, so this fix has no durability implications, however it is certainly more correct to make sure that the FILE buffers are flushed to the kernel before calling fsync on the file descriptor. Thanks to Li Shao Kai for reporting this issue in the Redis mailing list. 
 
- 
- 20 Jan, 2014 4 commits
- 
- 
antirez authoredOne of the simple heuristics used by Redis Cluster in order to avoid losing data in the typical failure modes created by the asynchronous replication with the slaves (a master is unable, when accepting a write, to immediately tell if it should be really accepted or refused because of a configuration change), is to wait some time before to rejoin the cluster after being partitioned away from the majority of instances. A similar condition happens when a master is restarted. It does not know if it was already failed over, nor if all the clients have already an updated configuration about the cluster map, so it is possible that clients will try to write to stale masters that were restarted. In a similar way this commit changes masters behavior so they wait 2000 milliseconds before accepting writes after a reboot. There is nothing special about 2 seconds if not to be a value supposedly larger a few orders of magnitude compared to the cluster bus communication latencies. 
- 
antirez authoredThese were committed for error after being inserted in order to fix an issue. 
- 
antirez authored
- 
antirez authored
 
- 
- 17 Jan, 2014 7 commits
- 
- 
antirez authoredThe code was doing checks for slaves that should be done only when the instance is currently a master. Switching a slave from a master to another one should just work. 
- 
antirez authoredWhen an instance is potentially set to replicate with another master, it is conceptually disconnected forever, since we have no old copy of the dataset for this master in memory. 
- 
antirez authored
- 
antirez authored
- 
antirez authoredAlso the :replicates info field in the node object is now correctly populated. This also fixes the :replicas field computation. 
- 
antirez authored
- 
antirez authored
 
- 
- 16 Jan, 2014 4 commits
- 15 Jan, 2014 9 commits
- 
- 
antirez authoredCLUSTER FORGET is not useful if we can't remove a node from all the nodes of our cluster because of the Gossip protocol that keeps adding a given node to nodes where we already tried to remove it. So now CLUSTER FORGET implements a nodes blacklist that is set and checked by the Gossip section processing function. This way before a node is re-added at least 60 seconds must elapse since the FORGET execution. This means that redis-trib has some time to remove a node from a whole cluster. It is possible that in the future it will be uesful to raise the 60 sec figure to something bigger. 
- 
antirez authoredThe hash table value should be set to now + 60 seconds otherwise it expires immediately. 
- 
antirez authoredWe can't lookup by node->name that's not an SDS string but a plain C array in the node structure. 
- 
antirez authored
- 
antirez authoredThe rejoin delay usually is the node timeout. However if the node timeout is too small, we set it to 500 milliseconds, that is a value chosen to be greater than most setups RTT / instances latency figures so that likely communication with other nodes happen before rejoining. 
- 
antirez authoredUsually we update the cluster state (to understand if we should accept queries or reply with an error) only when there is a change in the state of the nodes. However for the "delayed rejoin" feature to work, that is, for a master to wait some time before accepting queries again after it rejoins the majority, we need to periodically update the last time when the node was partitioned away from the majority. With this commit if the cluster is down we update the state ten times per second. 
- 
antirez authoredSee issue #1426 on Github. 
- 
antirez authoredEven without the user messing manually with the file, it is still possible to have blank lines (just a single "\n" per line) because of how the nodes.conf update/write process works. 
- 
antirez authoredThe way the file was generated was unsafe and leaded to nodes.conf file corruption (zero length file) on server stop/crash during the creation of the file. The previous file update method was as simple as open with O_TRUNC followed by the write call. While the write call was a single one with the full payload, ensuring no half-written files for POSIX semantics, stopping the server just after the open call resulted into a zero-length file (all the nodes information lost!). 
 
- 
- 14 Jan, 2014 4 commits
- 
- 
antirez authoredA client can enter a special cluster read-only mode using the READONLY command: if the client read from a slave instance after this command, for slots that are actually served by the instance's master, the queries will be processed without redirection, allowing clients to read from slaves (but without any kind fo read-after-write guarantee). The READWRITE command can be used in order to exit the readonly state. 
- 
antirez authored
- 
antirez authored64mb is the default value in redis.conf. For some reason instead the hard-coded default was 1mb that is too small. 
- 
antirez authored
 
- 
- 13 Jan, 2014 3 commits
- 10 Jan, 2014 1 commit
- 
- 
antirez authoredThe command totally removes a monitored master. 
 
-