1. 18 Dec, 2019 1 commit
  2. 17 Dec, 2019 11 commits
  3. 16 Dec, 2019 1 commit
  4. 13 Dec, 2019 1 commit
  5. 12 Dec, 2019 4 commits
  6. 11 Dec, 2019 2 commits
  7. 09 Dec, 2019 2 commits
  8. 05 Dec, 2019 2 commits
    • Eran Liberty's avatar
      - memcpy(&id,ri.key,ri.key_len); · 08c3fe80
      Eran Liberty authored
      +        memcpy(&id,ri.key,sizeof(id));
      
      The memcpy from the key to the id reliease on the fact that this key
      *should* be 8 bytes long as it was entered as such a few lines up the
      code.
      
      BUT if someone will change the code to the point this is no longer true,
      current code can trash the stack which makes debugging very hard
      while this fix will result in some garbage id, or even page fault.
      Both are preferable to stack mangaling.
      08c3fe80
    • antirez's avatar
      2271cf03
  9. 03 Dec, 2019 1 commit
  10. 02 Dec, 2019 2 commits
  11. 01 Dec, 2019 1 commit
  12. 29 Nov, 2019 1 commit
  13. 28 Nov, 2019 2 commits
    • Oran Agra's avatar
      Converting more configs to use generic infra, and moving defaults to config.c · 18e72c5c
      Oran Agra authored
      Changes in behavior:
      - Change server.stream_node_max_entries from int64_t to long long, so that it can be used by the generic infra
      - standard error reply instead of "repl-backlog-size must be 1 or greater" and such
      - tls-port and a few TLS booleans were readable (config get) even when USE_OPENSSL was off (now they aren't)
      - syslog-enabled, syslog-ident, cluster-enabled, appendfilename, and supervised didn't have a get (now they do)
      - pidfile was initialized to NULL in InitServerConfig but had CONFIG_DEFAULT_PID_FILE in rewriteConfig (so the real default was "", but rewrite would cause it to be set), fixed the rewrite.
      - TLS config in server.h was uninitialized (if no tls config args were provided)
      
      Adding test for sanity and coverage
      18e72c5c
    • Oran Agra's avatar
      More improvements and fixes to generic config infra · 28beb05a
      Oran Agra authored
      - Adding is_valid_fn and update_fn, both return 1 for success and 0 for failure with an optional error message.
      - Bugfix in handling boundary check of unsigned numeric types (was boundaries as signed)
      - Adding more numeric types to generic mechanism: uint, ulonglong, long, time_t, off_t
      - More verbose error replies ("argument must be between" in out of range CONFIG SET (like config file parsing)
      28beb05a
  14. 26 Nov, 2019 1 commit
    • Oran Agra's avatar
      Additional config.c refactory and bugfixes · e0cc3c99
      Oran Agra authored
      - add capability for each config to have a callback to check if value is valid and return error string
        will enable converting many of the remaining custom configs into generic ones (reducing the x4 repetition for set,get,config,rewrite)
      - add capability for each config to  to run some update code after config is changed (only for CONFIG SET)
        will also enable converting many of the remaining custom configs into generic ones
      - add capability to move default values from server.h and server.c to config.c
        will reduce many excess lines in server.h and server.c (plus, no need to rebuild the entire code base when a default change 8-))
      
      other behavior changes:
      - fix bug in bool config get (always returning 'yes')
      - fix a bug in modifying jemalloc-bg-thread at runtime (didn't call set_jemalloc_bg_thread, due to bad merge conflict resolution (my fault))
      - side effect when a failed attempt to enable activedefrag at runtime, we now respond with -ERR and not with -DISABLED
      e0cc3c99
  15. 22 Nov, 2019 5 commits
  16. 21 Nov, 2019 2 commits
  17. 20 Nov, 2019 1 commit