1. 22 Jan, 2014 1 commit
    • antirez's avatar
      Use fflush() before fsync() in rio.c. · 248e9165
      antirez authored
      Incremental flushing in rio.c is only used to avoid huge kernel buffers
      synched to slow disks creating big latency spikes, so this fix has no
      durability implications, however it is certainly more correct to make
      sure that the FILE buffers are flushed to the kernel before calling
      fsync on the file descriptor.
      
      Thanks to Li Shao Kai for reporting this issue in the Redis mailing
      list.
      248e9165
  2. 14 Jan, 2014 2 commits
  3. 13 Jan, 2014 13 commits
  4. 09 Jan, 2014 1 commit
  5. 08 Jan, 2014 3 commits
  6. 25 Dec, 2013 5 commits
  7. 23 Dec, 2013 2 commits
    • antirez's avatar
      Fix CONFIG REWRITE handling of unknown options. · 4ad219ad
      antirez authored
      There were two problems with the implementation.
      
      1) "save" was not correctly processed when no save point was configured,
         as reported in issue #1416.
      2) The way the code checked if an option existed in the "processed"
         dictionary was wrong, as we add the element with as a key associated
         with a NULL value, so dictFetchValue() can't be used to check for
         existance, but dictFind() must be used, that returns NULL only if the
         entry does not exist at all.
      4ad219ad
    • antirez's avatar
      Configuring port to 0 disables IP socket as specified. · c6db326d
      antirez authored
      This was no longer the case with 2.8 becuase of a bug introduced with
      the IPv6 support. Now it is fixed.
      
      This fixes issue #1287 and #1477.
      c6db326d
  8. 22 Dec, 2013 2 commits
    • antirez's avatar
      Make new masters inherit replication offsets. · 4456ee11
      antirez authored
      Currently replication offsets could be used into a limited way in order
      to understand, out of a set of slaves, what is the one with the most
      updated data. For example this comparison is possible of N slaves
      were replicating all with the same master.
      
      However the replication offset was not transferred from master to slaves
      (that are later promoted as masters) in any way, so for instance if
      there were three instances A, B, C, with A master and B and C
      replication from A, the following could happen:
      
      C disconnects from A.
      B is turned into master.
      A is switched to master of B.
      B receives some write.
      
      In this context there was no way to compare the offset of A and C,
      because B would use its own local master replication offset as
      replication offset to initialize the replication with A.
      
      With this commit what happens is that when B is turned into master it
      inherits the replication offset from A, making A and C comparable.
      In the above case assuming no inconsistencies are created during the
      disconnection and failover process, A will show to have a replication
      offset greater than C.
      
      Note that this does not mean offsets are always comparable to understand
      what is, in a set of instances, since in more complex examples the
      replica with the higher replication offset could be partitioned away
      when picking the instance to elect as new master. However this in
      general improves the ability of a system to try to pick a good replica
      to promote to master.
      4456ee11
    • antirez's avatar
      Slave disconnection is an event worth logging. · 5fa937d9
      antirez authored
      5fa937d9
  9. 20 Dec, 2013 1 commit
  10. 19 Dec, 2013 4 commits
  11. 13 Dec, 2013 3 commits
    • antirez's avatar
      Makefile.dep updated. · 33f6f35f
      antirez authored
      33f6f35f
    • antirez's avatar
      SDIFF iterator misuse fixed in diff algorithm #1. · 993e0ede
      antirez authored
      The bug could be easily triggered by:
      
          SADD foo a b c 1 2 3 4 5 6
          SDIFF foo foo
      
      When the key was the same in two sets, an unsafe iterator was used to
      check existence of elements in the same set we were iterating.
      Usually this would just result into a wrong output, however with the
      dict.c API misuse protection we have in place, the result was actually
      an assertion failed that was triggered by the CI test, while creating
      random datasets for the "MASTER and SLAVE consistency" test.
      993e0ede
    • antirez's avatar
      Sentinel: dead code removed. · 2507e366
      antirez authored
      2507e366
  12. 12 Dec, 2013 2 commits
  13. 11 Dec, 2013 1 commit