1. 18 Mar, 2019 1 commit
  2. 13 Mar, 2019 2 commits
  3. 21 Dec, 2018 1 commit
  4. 11 Dec, 2018 3 commits
  5. 20 Nov, 2018 2 commits
  6. 17 Oct, 2018 5 commits
  7. 15 Oct, 2018 3 commits
  8. 09 Oct, 2018 1 commit
  9. 03 Oct, 2018 1 commit
  10. 14 Sep, 2018 2 commits
  11. 05 Sep, 2018 1 commit
  12. 04 Sep, 2018 2 commits
  13. 29 Aug, 2018 2 commits
    • Oran Agra's avatar
      Fix unstable tests on slow machines. · af675f0a
      Oran Agra authored
      Few tests had borderline thresholds that were adjusted.
      
      The slave buffers test had two issues, preventing the slave buffer from growing:
      1) the slave didn't necessarily go to sleep on time, or woke up too early,
         now using SIGSTOP to make sure it goes to sleep exactly when we want.
      2) the master disconnected the slave on timeout
      af675f0a
    • zhaozhao.zz's avatar
      1203a04f
  14. 03 Aug, 2018 2 commits
  15. 02 Aug, 2018 3 commits
    • antirez's avatar
      Test: new sorted set skiplist order consistency. · 70c4bcb7
      antirez authored
      This should be able to find new bugs and regressions about the new
      sorted set update function when ZADD is used to update an element
      already existing.
      
      The test is able to find the bug fixed at 2f282aee immediately.
      70c4bcb7
    • antirez's avatar
      Minor improvements to PR #5187. · ab237a8e
      antirez authored
      ab237a8e
    • Oran Agra's avatar
      test suite conveniency improvements · 1ce3cf7a
      Oran Agra authored
      * allowing --single to be repeated
      * adding --only so that only a specific test inside a unit can be run
      * adding --skiptill useful to resume a test that crashed passed the problematic unit.
        useful together with --clients 1
      * adding --skipfile to use a file containing list of tests names to skip
      * printing the names of the tests that are skiped by skipfile or denytags
      * adding --config to add config file options from command line
      1ce3cf7a
  16. 24 Jul, 2018 1 commit
    • Oran Agra's avatar
      fix slave buffer test suite false positives · 4b79fdf1
      Oran Agra authored
      it looks like on slow machines we're getting:
      [err]: slave buffer are counted correctly in tests/unit/maxmemory.tcl
      Expected condition '$slave_buf > 2*1024*1024' to be true (16914 > 2*1024*1024)
      
      this is a result of the slave waking up too early and eating the
      slave buffer before the traffic and the test ends.
      4b79fdf1
  17. 18 Jul, 2018 1 commit
    • Oran Agra's avatar
      make active defrag test more stable · f89c93c8
      Oran Agra authored
      on slower machines, the active defrag test tended to fail.
      although the fragmentation ratio was below the treshold, the defragger was
      still in the middle of a scan cycle.
      
      this commit changes:
      - the defragger uses the current fragmentation state, rather than the cache one
        that is updated by server cron every 100ms. this actually fixes a bug of
        starting one excess scan cycle
      - the test lets the defragger use more CPU cycles, in hope that the defrag
        will be faster, but also give it more time before we give up.
      f89c93c8
  18. 16 Jul, 2018 1 commit
    • Oran Agra's avatar
      slave buffers were wasteful and incorrectly counted causing eviction · bf680b6f
      Oran Agra authored
      A) slave buffers didn't count internal fragmentation and sds unused space,
         this caused them to induce eviction although we didn't mean for it.
      
      B) slave buffers were consuming about twice the memory of what they actually needed.
      - this was mainly due to sdsMakeRoomFor growing to twice as much as needed each time
        but networking.c not storing more than 16k (partially fixed recently in 237a38737).
      - besides it wasn't able to store half of the new string into one buffer and the
        other half into the next (so the above mentioned fix helped mainly for small items).
      - lastly, the sds buffers had up to 30% internal fragmentation that was wasted,
        consumed but not used.
      
      C) inefficient performance due to starting from a small string and reallocing many times.
      
      what i changed:
      - creating dedicated buffers for reply list, counting their size with zmalloc_size
      - when creating a new reply node from, preallocate it to at least 16k.
      - when appending a new reply to the buffer, first fill all the unused space of the
        previous node before starting a new one.
      
      other changes:
      - expose mem_not_counted_for_evict info field for the benefit of the test suite
      - add a test to make sure slave buffers are counted correctly and that they don't cause eviction
      bf680b6f
  19. 13 Jul, 2018 6 commits