1. 20 Mar, 2015 1 commit
    • antirez's avatar
      Cluster: better cluster state transiction handling. · 25c0f5ac
      antirez authored
      Before we relied on the global cluster state to make sure all the hash
      slots are linked to some node, when getNodeByQuery() is called. So
      finding the hash slot unbound was checked with an assertion. However
      this is fragile. The cluster state is often updated in the
      clusterBeforeSleep() function, and not ASAP on state change, so it may
      happen to process clients with a cluster state that is 'ok' but yet
      certain hash slots set to NULL.
      
      With this commit the condition is also checked in getNodeByQuery() and
      reported with a identical error code of -CLUSTERDOWN but slightly
      different error message so that we have more debugging clue in the
      future.
      
      Root cause of issue #2288.
      25c0f5ac
  2. 18 Mar, 2015 1 commit
  3. 13 Mar, 2015 2 commits
  4. 10 Mar, 2015 1 commit
  5. 27 Feb, 2015 1 commit
  6. 26 Feb, 2015 2 commits
    • antirez's avatar
      Improvements to PR #2425 · 832b0c7c
      antirez authored
      1. Remove useless "cs" initialization.
      2. Add a "select" var to capture a condition checked multiple times.
      3. Avoid duplication of the same if (!copy) conditional.
      4. Don't increment dirty if copy is given (no deletion is performed),
         otherwise we propagate MIGRATE when not needed.
      832b0c7c
    • Tommy Wang's avatar
      Add last_dbid to migrateCachedSocket to avoid redundant SELECT · 7fda935a
      Tommy Wang authored
      Avoid redundant SELECT calls when continuously migrating keys to
      the same dbid within a target Redis instance.
      7fda935a
  7. 30 Jan, 2015 2 commits
  8. 29 Jan, 2015 3 commits
  9. 24 Jan, 2015 1 commit
    • antirez's avatar
      Cluster: initialized not used fileds in gossip section. · 9802ec3c
      antirez authored
      Otherwise we risk sending not initialized data to other nodes, that may
      contain anything. This was actually not possible only because the
      initialization of the buffer where the cluster packets header is created
      was larger than the 3 gossip sections we use, so the memory was already
      all filled with zeroes by the memset().
      9802ec3c
  10. 21 Jan, 2015 6 commits
    • Matt Stancliff's avatar
      Fix cluster migrate memory leak · 051a43e0
      Matt Stancliff authored
      Fixes valgrind error:
      48 bytes in 1 blocks are definitely lost in loss record 196 of 373
         at 0x4910D3: je_malloc (jemalloc.c:944)
         by 0x42807D: zmalloc (zmalloc.c:125)
         by 0x41FA0D: dictGetIterator (dict.c:543)
         by 0x41FA48: dictGetSafeIterator (dict.c:555)
         by 0x459B73: clusterHandleSlaveMigration (cluster.c:2776)
         by 0x45BF27: clusterCron (cluster.c:3123)
         by 0x423344: serverCron (redis.c:1239)
         by 0x41D6CD: aeProcessEvents (ae.c:311)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
      051a43e0
    • Matt Stancliff's avatar
      Fix potential invalid read past end of array · 29049507
      Matt Stancliff authored
      If array has N elements, we can't read +1 if we are already at N.
      
      Also, we need to move elements by their storage size in the array,
      not just by individual bytes.
      29049507
    • Matt Stancliff's avatar
      Fix cluster reset memory leak · 30152554
      Matt Stancliff authored
      [maybe] Fixes valgrind errors:
      32 bytes in 4 blocks are definitely lost in loss record 107 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80A9AFC: clusterSetMaster (cluster.c:801)
         by 0x80AEDC9: clusterCommand (cluster.c:3994)
         by 0x80682A5: call (redis.c:2049)
         by 0x8068A20: processCommand (redis.c:2309)
         by 0x8076497: processInputBuffer (networking.c:1143)
         by 0x8073BAF: readQueryFromClient (networking.c:1208)
         by 0x8060E98: aeProcessEvents (ae.c:412)
         by 0x806123B: aeMain (ae.c:455)
         by 0x806C3DB: main (redis.c:3832)
      
      64 bytes in 8 blocks are definitely lost in loss record 143 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80AAB40: clusterProcessPacket (cluster.c:801)
         by 0x80A847F: clusterReadHandler (cluster.c:1975)
         by 0x30000FF: ???
      
      80 bytes in 10 blocks are definitely lost in loss record 148 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80AAB40: clusterProcessPacket (cluster.c:801)
         by 0x80A847F: clusterReadHandler (cluster.c:1975)
         by 0x2FFFFFF: ???
      30152554
    • Matt Stancliff's avatar
      Fix sending uninitialized bytes · 72b8574c
      Matt Stancliff authored
      Fixes valgrind error:
      Syscall param write(buf) points to uninitialised byte(s)
         at 0x514C35D: ??? (syscall-template.S:81)
         by 0x456B81: clusterWriteHandler (cluster.c:1907)
         by 0x41D596: aeProcessEvents (ae.c:416)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
       Address 0x5f268e2 is 2,274 bytes inside a block of size 8,192 alloc'd
         at 0x4932D1: je_realloc (jemalloc.c:1297)
         by 0x428185: zrealloc (zmalloc.c:162)
         by 0x4269E0: sdsMakeRoomFor.part.0 (sds.c:142)
         by 0x426CD7: sdscatlen (sds.c:251)
         by 0x4579E7: clusterSendMessage (cluster.c:1995)
         by 0x45805A: clusterSendPing (cluster.c:2140)
         by 0x45BB03: clusterCron (cluster.c:2944)
         by 0x423344: serverCron (redis.c:1239)
         by 0x41D6CD: aeProcessEvents (ae.c:311)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
       Uninitialised value was created by a stack allocation
         at 0x457810: nodeUpdateAddressIfNeeded (cluster.c:1236)
      72b8574c
    • antirez's avatar
      Cluster: node deletion cleanup / centralization. · 2601e3e4
      antirez authored
      2601e3e4
    • antirez's avatar
      Cluster: set the slaves->slaveof filed to NULL when master is freed. · 59ad6ac5
      antirez authored
      Related to issue #2289.
      59ad6ac5
  11. 19 Jan, 2015 1 commit
    • Matt Stancliff's avatar
      Improve networking type correctness · 53c082ec
      Matt Stancliff authored
      read() and write() return ssize_t (signed long), not int.
      
      For other offsets, we can use the unsigned size_t type instead
      of a signed offset (since our replication offsets and buffer
      positions are never negative).
      53c082ec
  12. 13 Jan, 2015 3 commits
    • antirez's avatar
      Cluster: fetch my IP even if msg is not MEET for the first time. · cf76af6b
      antirez authored
      In order to avoid that misconfigured cluster nodes at some time may
      force an IP update on other nodes, it is required that nodes update
      their own address only on MEET messages. However it does not make sense
      to do this the first time a node is contacted and yet does not have an
      IP, we just risk that myself->ip remains not assigned if there are
      messages lost or cluster creation procedures that don't make sure
      everybody is targeted by at least one incoming MEET message.
      
      Also fix the logging of the IP switch avoiding the :-1 tail.
      cf76af6b
    • antirez's avatar
      Cluster: clusterMsgDataGossip structure, explict padding + minor stuff. · 5b0f4a83
      antirez authored
      Also explicitly set version to 0, add a protocol version define, improve
      comments in the gossip structure.
      
      Note that the structure layout is the same after the change, we are just
      making the padding explicit with an additional not used 16 bits field.
      So this commit is still able to talk with the previous versions of
      cluster nodes.
      5b0f4a83
    • antirez's avatar
      Suppress valgrind error about write sending uninitialized data. · 237ab727
      antirez authored
      Valgrind checks that the buffers we transfer via syscalls are all
      composed of bytes actually initialized. This is useful, it makes we able
      to avoid leaking informations in non initialized parts fo messages
      transferred to other hosts. This commit fixes one of such issues.
      237ab727
  13. 12 Jan, 2015 1 commit
    • antirez's avatar
      Cluster: initialize mf_end. · 6274a678
      antirez authored
      Can't be initialized by resetManualFailover() since it's actual state
      the function uses, so we need to initialize it at startup time. Not
      really a bug in practical terms, but showed up into valgrind and is not
      technically correct anyway.
      6274a678
  14. 23 Dec, 2014 1 commit
  15. 17 Dec, 2014 1 commit
    • Matt Stancliff's avatar
      Cluster: Notify user on accept error · a772747f
      Matt Stancliff authored
      If we woke up to accept a connection, but we can't
      accept it, inform the user of the error going on
      with their networking.
      
      (The previous message was the same for success or error!)
      a772747f
  16. 16 Dec, 2014 1 commit
  17. 15 Dec, 2014 1 commit
  18. 11 Dec, 2014 2 commits
  19. 10 Dec, 2014 1 commit
    • antirez's avatar
      Better read-only behavior for expired keys in slaves. · 06e76bc3
      antirez authored
      Slaves key expire is orchestrated by the master. Sometimes the master
      will send the synthesized DEL to expire keys on the slave with a non
      trivial delay (when the key is not accessed, only the incremental expiry
      algorithm will expire it in background).
      
      During that time, a key is logically expired, but slaves still return
      the key if you GET (or whatever) it. This is a bad behavior.
      
      However we can't simply trust the slave view of the key, since we need
      the master to be able to send write commands to update the slave data
      set, and DELs should only happen when the key is expired in the master
      in order to ensure consistency.
      
      However 99.99% of the issues with this behavior is when a client which
      is not a master sends a read only command. In this case we are safe and
      can consider the key as non existing.
      
      This commit does a few changes in order to make this sane:
      
      1. lookupKeyRead() is modified in order to return NULL if the above
      conditions are met.
      2. Calls to lookupKeyRead() in commands actually writing to the data set
      are repliaced with calls to lookupKeyWrite().
      
      There are redundand checks, so for example, if in "2" something was
      overlooked, we should be still safe, since anyway, when the master
      writes the behavior is to don't care about what expireIfneeded()
      returns.
      
      This commit is related to  #1768, #1770, #2131.
      06e76bc3
  20. 28 Nov, 2014 1 commit
    • antirez's avatar
      Cluster PUBLISH message: fix totlen count. · 669aa2a2
      antirez authored
      bulk_data field size was not removed from the count. It is not possible
      to declare it simply as 'char bulk_data[]' since the structure is nested
      into another structure.
      669aa2a2
  21. 29 Oct, 2014 2 commits
    • Matt Stancliff's avatar
      Networking: add more outbound IP binding fixes · 0014966c
      Matt Stancliff authored
      Same as the original bind fixes (we just missed these the
      first time around).
      
      This helps Redis not automatically send
      connections from the first IP on an interface if we are bound
      to a specific IP address (e.g. with multiple IP aliases on one
      interface, you want to send from _your_ IP, not from the first IP
      on the interface).
      0014966c
    • Matt Stancliff's avatar
      Parse cluster state file in IPv6 compatible way · daca1edb
      Matt Stancliff authored
      We need to pick the port based on the _last_ colon, not the first one.
      daca1edb
  22. 08 Oct, 2014 2 commits
    • antirez's avatar
      Cluster: process gossip section only for known nodes. · 5f6950ca
      antirez authored
      With the exception of nodes sending MEET packets: we have to trust them
      since they can send us MEET packets only when the cluster is initially
      created or because sysadmin manual action.
      5f6950ca
    • antirez's avatar
      Cluster: fix logic to detect we are among a minority. · 36e34a65
      antirez authored
      In the cluster evaluation function we are supposed to set the cluster
      state as "fail" if we are among a minority, however the code was not
      detecting to be into a minority partition if exactly half the masters
      were reachable, which is a minority.
      36e34a65
  23. 07 Oct, 2014 1 commit
  24. 29 Sep, 2014 1 commit
    • Matt Stancliff's avatar
      Clean up text throughout project · 12d0195b
      Matt Stancliff authored
        - Remove trailing newlines from redis.conf
        - Fix comment misspelling
        - Clarifies zipEncodeLength usage and a C API mention (#1243, #1242)
        - Fix cluster typos (inspired by @papanikge #1507)
        - Fix rewite -> rewrite in a few places (inspired by #682)
      
      Closes #1243, #1242, #1507
      12d0195b
  25. 17 Sep, 2014 1 commit
    • antirez's avatar
      Cluster: claim ping_sent time even if we can't connect. · 23744967
      antirez authored
      This fixes a potential bug that was never observed in practice since
      what happens is that the asynchronous connect returns ok (to fail later,
      calling the handler) every time, so a ping is queued, and sent_ping
      happens to always be populated.
      
      Howver technically connect(2) with a non blocking socket may return an
      error synchronously, so before this fix the code was not correct.
      23744967