1. 23 May, 2012 4 commits
    • antirez's avatar
      Use comments to split aof.c into sections. · 27fc5bf5
      antirez authored
      This makes the code more readable, it is still not the case to split the
      file itself into three different files, but the logical separation
      improves the readability especially since new commits are going to
      introduce an additional section.
      27fc5bf5
    • antirez's avatar
      Redis test: include bug report on crash. · dfa90b59
      antirez authored
      Due to a change in the format of the bug report in case of crash of
      failed assertion the test suite was no longer able to properly log it.
      Instead just a protocol error was logged by the Redis TCL client that
      provided no clue about the actual problem.
      
      This commit resolves the issue by logging everything from the first line
      of the log including the string REDIS BUG REPORT, till the end of the
      file.
      dfa90b59
    • jokea's avatar
    • antirez's avatar
      Fixed issue #516 (ZINTERSTORE mixing sets and zsets). · 4dada1b5
      antirez authored
      Weeks ago trying to fix an harmless GCC warning I introduced a bug in
      the ziplist-encoded implementations of sorted sets.
      
      The bug completely broke zuiNext() iterator, that is used in the
      ZINTERSTORE and ZUNIONSTORE implementation, so those two commands are no
      longer reliable starting from Redis version 2.4.12 and latest 2.6.0-RC
      releases.
      
      This commit fixes the problem and adds a regression test.
      4dada1b5
  2. 16 May, 2012 2 commits
  3. 15 May, 2012 2 commits
  4. 14 May, 2012 7 commits
    • Pieter Noordhuis's avatar
      Whitespace · d318803f
      Pieter Noordhuis authored
      d318803f
    • Dave Pacheco's avatar
      use port_getn instead of port_get · 72f30bcd
      Dave Pacheco authored
      72f30bcd
    • Dave Pacheco's avatar
      first cut at event port support · 2aa1efb8
      Dave Pacheco authored
      2aa1efb8
    • antirez's avatar
      Added time.h include in redis-cli. · e67d014d
      antirez authored
      redis-cli.c uses the time() function to seed the PRNG, but time.h was
      not included. This was not noticed since sys/time.h is included and was
      enough in most systems (but not correct). With Ubuntu 12.04 GCC
      generates a warning that made us aware of the issue.
      e67d014d
    • antirez's avatar
      activeExpireCycle(): better precision in max time used. · eee68054
      antirez authored
      activeExpireCycle() can consume no more than a few milliseconds per
      iteration. This commit improves the precision of the check for the time
      elapsed in two ways:
      
      1) We check every 16 iterations instead of the main loop instead of 256.
      2) We reset iterations at the start of the function and not every time
         we switch to the next database, so the check is correctly performed
         every 16 iterations.
      eee68054
    • antirez's avatar
      Impovements for: Redis timer, hashes rehashing, keys collection. · a8a981a8
      antirez authored
      A previous commit introduced REDIS_HZ define that changes the frequency
      of calls to the serverCron() Redis function. This commit improves
      different related things:
      
      1) Software watchdog: now the minimal period can be set according to
      REDIS_HZ. The minimal period is two times the timer period, that is:
      
          (1000/REDIS_HZ)*2 milliseconds
      
      2) The incremental rehashing is now performed in the expires dictionary
      as well.
      
      3) The activeExpireCycle() function was improved in different ways:
      
      - Now it checks if it already used too much time using microseconds
        instead of milliseconds for better precision.
      - The time limit is now calculated correctly, in the previous version
        the division was performed before of the multiplication resulting in
        a timelimit of 0 if HZ was big enough.
      - Databases with less than 1% of buckets fill in the hash table are
        skipped, because getting random keys is too expensive in this
        condition.
      
      4) tryResizeHashTables() is now called at every timer call, we need to
         match the number of calls we do to the expired keys colleciton cycle.
      
      5) REDIS_HZ was raised to 100.
      a8a981a8
    • antirez's avatar
      Redis timer interrupt frequency configurable as REDIS_HZ. · f7f2b261
      antirez authored
      Redis uses a function called serverCron() that is very similar to the
      timer interrupt of an operating system. This function is used to handle
      a number of asynchronous things, like active expired keys collection,
      clients timeouts, update of statistics, things related to the cluster
      and replication, triggering of BGSAVE and AOF rewrite process, and so
      forth.
      
      In the past the timer was called 1 time per second. At some point it was
      raised to 10 times per second, but it still was fixed and could not be
      changed even at compile time, because different functions called from
      serverCron() assumed a given fixed frequency.
      
      This commmit makes the frequency configurable, so that it is simpler to
      pick a good tradeoff between overhead of this function (that is usually
      very small) and the responsiveness of Redis during a few critical
      circumstances where a lot of work is done inside the timer.
      
      An example of such a critical condition is mass-expire of a lot of keys
      in the same second. Up to a given percentage of CPU time is used to
      perform expired keys collection per expire cylce. Now changing the
      REDIS_HZ macro it is possible to do less work but more times per second
      in order to block the server for less time.
      
      If this patch will work well in our tests it will enter Redis 2.6-final.
      f7f2b261
  5. 12 May, 2012 6 commits
  6. 09 May, 2012 2 commits
  7. 06 May, 2012 4 commits
  8. 05 May, 2012 1 commit
    • Pieter Noordhuis's avatar
      Compare integers in ziplist regardless of encoding · 0ef88927
      Pieter Noordhuis authored
      Because of the introduction of new integer encoding types for ziplists
      in the 2.6 tree, the same integer value may have a different encoding in
      different versions of the ziplist implementation. This means that the
      encoding can NOT be used as a fast path in comparing integers.
      0ef88927
  9. 04 May, 2012 2 commits
  10. 02 May, 2012 6 commits
  11. 01 May, 2012 1 commit
  12. 30 Apr, 2012 3 commits