- 04 May, 2016 1 commit
-
-
antirez authored
Thanks to @tidwall for reporting. Close #3194.
-
- 18 Feb, 2016 4 commits
-
-
Itamar Haber authored
-
Itamar Haber authored
-
Itamar Haber authored
-
antirez authored
Related to issue #3019.
-
- 07 Oct, 2015 1 commit
-
-
antirez authored
the check for lat/long valid ranges were performed inside the for loop, two times instead of one, and the first time when the second element of the array, xy[1], was yet not populated. This resulted into issue #2799. Close issue #2799.
-
- 06 Oct, 2015 1 commit
-
-
antirez authored
-
- 01 Oct, 2015 1 commit
-
-
antirez authored
-
- 14 Sep, 2015 1 commit
-
-
antirez authored
Georadius works by computing the center + neighbors squares covering all the area of the specified position and radius. Then a distance filter is used to remove elements which are actually outside the range. When a huge radius is used, like 5000 km or more, adjacent neighbors may collide and be the same, leading to the reporting of the same element multiple times. This only happens in the edge case of huge radius but is not ideal. A robust but slow solution would involve qsorting the range to remove all the duplicates. However since the collisions are only in adjacent boxes, for the way they are ordered in the code, it is much faster to just check if the current box is the same as the previous one processed. This commit adds a regression test for the bug. Fixes #2767.
-
- 26 Jul, 2015 3 commits
- 09 Jul, 2015 2 commits
-
-
antirez authored
Rationale: 1. The commands look like internals exposed without a real strong use case. 2. Whatever there is an use case, the client would implement the commands client side instead of paying RTT just to use a simple to reimplement library. 3. They add complexity to an otherwise quite straightforward API. So for now KILLED ;-)
-
antirez authored
-
- 06 Jul, 2015 1 commit
-
-
antirez authored
-
- 01 Jul, 2015 1 commit
-
-
antirez authored
Instead of successive divisions in iteration the new code uses bitwise magic to interleave / deinterleave two 32bit values into a 64bit one. All tests still passing and is measurably faster, so worth it.
-
- 29 Jun, 2015 12 commits
-
-
antirez authored
-
antirez authored
I'm not a strong believer in multiple syntax for the same stuff, so now units can be specified only as m, km, ft, mi.
-
antirez authored
Stack traces produced by Redis on crash are the most useful tool we have to fix non easily reproducible crashes, or even easily reproducible ones where the user just posts a bug report and does not collaborate furhter. By declaring functions "static" they no longer show up in the stack trace.
-
antirez authored
-
antirez authored
In Redis MULTIWORDCOMMANDNAME are mapped to functions where the command name is all lowercase: multiwordcommandnameCommand().
-
antirez authored
-
antirez authored
-
antirez authored
If GEOENCODE must be our door to enter the Geocoding implementation details and do fancy things client side, than return the scores as well so that we can query the sorted sets directly if we wish to do the same search multiple times, or want to compute the boxes in the client side to refine our search needs.
-
antirez authored
-
antirez authored
-
antirez authored
Can't immagine how this is useful in the context of the API exported by Redis, and we are always in time to add more bloat if needed, later.
-
antirez authored
-
- 27 Jun, 2015 3 commits
- 26 Jun, 2015 1 commit
-
-
antirez authored
The GIS standard and all the major DBs implementing GIS related functions take coordinates as x,y that is longitude,latitude. It was a bad start for Redis to do things differently, so even if this means that existing users of the Geo module will be required to change their code, Redis now conforms to the standard. Usually Redis is very backward compatible, but this is not an exception to this rule, since this is the first Geo implementation entering the official Redis source code. It is not wise to try to be backward compatible with code forks... :-) Close #2637.
-
- 24 Jun, 2015 3 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
The returned step was in some case not enough towards normal coordinates (for example when our search position was was already near the margin of the central area, and we had to match, using the east or west neighbor, a very far point). Example: geoadd points 67.575457940146066 -62.001317572780565 far geoadd points 66.685439060295664 -58.925040587282297 center georadius points 66.685439060295664 -58.925040587282297 200 km In the above case the code failed to find a match (happens at smaller latitudes too) even if far and center are at less than 200km. Another fix introduced by this commit is a progressively larger area towards the poles, since meridians are a lot less far away, so we need to compensate for this. The current implementation works comparably to the Tcl brute-force stress tester implemented in the fuzzy test in the geo.tcl unit for latitudes between -70 and 70, and is pretty accurate over +/-80 too, with sporadic false negatives. A more mathematically clean implementation is possible by computing the meridian distance at the specified latitude and computing the step according to it.
-
- 23 Jun, 2015 5 commits
-
-
antirez authored
-
antirez authored
1. We no longer use a fake client but just rewriting. 2. We group all the inserts into a single ZADD dispatch (big speed win). 3. As a side effect of the correct implementation, replication works. 4. The return value of the command is now correct.
-
antirez authored
-
antirez authored
-
antirez authored
-