1. 30 Jan, 2020 1 commit
    • Guy Benoish's avatar
      ld2string should fail if string contains \0 in the middle · 2deb5551
      Guy Benoish authored
      This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
      I added tests for both cases.
      
      Main changes:
      1. Fixed string2ld to fail if string contains \0 in the middle
      2. Use string2ld in getLongDoubleFromObject - No point of
         having duplicated code here
      
      The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
      because the long double string was saved with length+1 (An innocent
      mistake, but it's actually a bug - The length passed to
      RM_SaveLongDouble should not include the last \0).
      2deb5551
  2. 04 Nov, 2019 1 commit
    • Oran Agra's avatar
      Add RM_ServerInfoGetFieldUnsigned · 04233097
      Oran Agra authored
      rename RM_ServerInfoGetFieldNumerical RM_ServerInfoGetFieldSigned
      move string2ull to util.c
      fix leak in RM_GetServerInfo when duplicate info fields exist
      04233097
  3. 03 Nov, 2019 2 commits
    • Oran Agra's avatar
      Module API for loading and saving long double · 779aebc9
      Oran Agra authored
      looks like each platform implements long double differently (different bit count)
      so we can't save them as binary, and we also want to avoid creating a new RDB
      format version, so we save these are hex strings using "%La".
      
      This commit includes a change in the arguments of ld2string to support this.
      as well as tests for coverage and short reads.
      
      coded by @guybe7
      779aebc9
    • Oran Agra's avatar
      Add module api for looking into INFO fields · 4d580438
      Oran Agra authored
      - Add RM_GetServerInfo and friends
      - Add auto memory for new opaque struct
      - Add tests for new APIs
      
      other minor fixes:
      - add const in various char pointers
      - requested_section in modulesCollectInfo was actually not sds but char*
      - extract new string2d out of getDoubleFromObject for code reuse
      
      Add module API for
      4d580438
  4. 28 Jan, 2019 1 commit
  5. 11 Dec, 2018 2 commits
  6. 15 Nov, 2018 1 commit
  7. 26 Oct, 2018 2 commits
  8. 24 Jul, 2018 2 commits
  9. 23 Jul, 2018 2 commits
  10. 21 Jul, 2018 1 commit
  11. 03 Jul, 2018 1 commit
  12. 05 Apr, 2018 1 commit
  13. 12 Dec, 2017 1 commit
  14. 10 May, 2016 1 commit
  15. 04 Nov, 2015 1 commit
    • antirez's avatar
      Fix HINCRBYFLOAT to work with long doubles. · 71aa9b75
      antirez authored
      During the refactoring needed for lazy free, specifically the conversion
      of t_hash from struct robj to plain SDS strings, HINCRBFLOAT was
      accidentally moved away from long doubles to doubles for internal
      processing of increments and formatting.
      
      The diminished precision created more obvious artifacts in the way small
      numbers are formatted once we convert from decimal number in radix 10 to
      double and back to its string in radix 10.
      
      By using more precision, we now have less surprising results at least
      with small numbers like "1.23", exactly like in the previous versions of
      Redis.
      
      See issue #2846.
      71aa9b75
  16. 01 Oct, 2015 4 commits
  17. 27 Feb, 2015 2 commits
  18. 12 Feb, 2015 1 commit
  19. 22 Jan, 2015 3 commits
  20. 21 Jan, 2015 1 commit
    • antirez's avatar
      getRandomHexChars(): use /dev/urandom just to seed. · 87301be1
      antirez authored
      On Darwin /dev/urandom depletes terribly fast. This is not an issue
      normally, but with Redis Cluster we generate a lot of unique IDs, for
      example during nodes handshakes. Our IDs need just to be unique without
      other strong crypto requirements, so this commit turns the function into
      something that gets a 20 bytes seed from /dev/urandom, and produces the
      rest of the output just using SHA1 in counter mode.
      87301be1
  21. 23 Dec, 2014 2 commits
    • Matt Stancliff's avatar
      Add simple ll2string() tests · 9b343678
      Matt Stancliff authored
      9b343678
    • Matt Stancliff's avatar
      Allow all code tests to run using Redis args · 8febcffd
      Matt Stancliff authored
      Previously, many files had individual main() functions for testing,
      but each required being compiled with their own testing flags.
      That gets difficult when you have 8 different flags you need
      to set just to run all tests (plus, some test files required
      other files to be compiled aaginst them, and it seems some didn't
      build at all without including the rest of Redis).
      
      Now all individual test main() funcions are renamed to a test
      function for the file itself and one global REDIS_TEST define enables
      testing across the entire codebase.
      
      Tests can now be run with:
        - `./redis-server test <test>`
      
        e.g. ./redis-server test ziplist
      
      If REDIS_TEST is not defined, then no tests get included and no
      tests are included in the final redis-server binary.
      8febcffd
  22. 29 Sep, 2014 1 commit
    • Matt Stancliff's avatar
      Clean up text throughout project · 12d0195b
      Matt Stancliff authored
        - Remove trailing newlines from redis.conf
        - Fix comment misspelling
        - Clarifies zipEncodeLength usage and a C API mention (#1243, #1242)
        - Fix cluster typos (inspired by @papanikge #1507)
        - Fix rewite -> rewrite in a few places (inspired by #682)
      
      Closes #1243, #1242, #1507
      12d0195b
  23. 15 Aug, 2014 1 commit
  24. 23 Jul, 2014 2 commits
  25. 23 Apr, 2014 1 commit
    • Glauber Costa's avatar
      fix null pointer access with no file pointer · 7dd44327
      Glauber Costa authored
      I happen to be working on a system that lacks urandom. While the code does try
      to handle this case and artificially create some bytes if the file pointer is
      empty, it does try to close it unconditionally, leading to a segfault.
      7dd44327
  26. 24 Jul, 2013 1 commit
  27. 02 Jul, 2013 1 commit
    • antirez's avatar
      pathIsBaseName() added to utils.c · 6978aeb3
      antirez authored
      The function is used to test that the specified string looks like just
      as the basename of a path, without any absolute or relative path.
      6978aeb3