1. 24 Apr, 2013 1 commit
    • antirez's avatar
      AOF: sync data on disk every 32MB when rewriting. · 336d722f
      antirez authored
      This prevents the kernel from putting too much stuff in the output
      buffers, doing too heavy I/O all at once. So the goal of this commit is
      to split the disk pressure due to the AOF rewrite process into smaller
      spikes.
      
      Please see issue #1019 for more information.
      336d722f
  2. 09 Apr, 2013 2 commits
    • antirez's avatar
      Cluster: use server.cluster_node_timeout directly. · 68cf249f
      antirez authored
      We used to copy this value into the server.cluster structure, however this
      was not necessary.
      
      The reason why we don't directly use server.cluster->node_timeout is
      that things that can be configured via redis.conf need to be directly
      available in the server structure as server.cluster is allocated later
      only if needed in order to reduce the memory footprint of non-cluster
      instances.
      68cf249f
    • antirez's avatar
      ef4f25ff
  3. 04 Apr, 2013 3 commits
  4. 02 Apr, 2013 1 commit
    • antirez's avatar
      Throttle BGSAVE attempt on saving error. · b237de33
      antirez authored
      When a BGSAVE fails, Redis used to flood itself trying to BGSAVE at
      every next cron call, that is either 10 or 100 times per second
      depending on configuration and server version.
      
      This commit does not allow a new automatic BGSAVE attempt to be
      performed before a few seconds delay (currently 5).
      
      This avoids both the auto-flood problem and filling the disk with
      logs at a serious rate.
      
      The five seconds limit, considering a log entry of 200 bytes, will use
      less than 4 MB of disk space per day that is reasonable, the sysadmin
      should notice before of catastrofic events especially since by default
      Redis will stop serving write queries after the first failed BGSAVE.
      
      This fixes issue #849
      b237de33
  5. 27 Mar, 2013 1 commit
    • antirez's avatar
      DEBUG set-active-expire added. · 32a83c82
      antirez authored
      We need the ability to disable the activeExpireCycle() (active
      expired key collection) call for testing purposes.
      32a83c82
  6. 20 Mar, 2013 2 commits
    • antirez's avatar
      Cluster: new flag PROMOTED introduced. · 506f9a42
      antirez authored
      A slave node set this flag for itself when, after receiving authorization
      from the majority of nodes, it turns itself into a master.
      
      At the same time now this flag is tested by nodes receiving a PING
      message before reconfiguring after a failover event. This makes the
      system more robust: even if currently there is no way to manually turn
      a slave into a master it is possible that we'll have such a feature in
      the future, or that simply because of misconfiguration a node joins the
      cluster as master while others believe it's a slave. This alone is now
      no longer enough to trigger reconfiguration as other nodes will check
      for the PROMOTED flag.
      
      The PROMOTED flag is cleared every time the node is turned back into a
      replica of some other node.
      506f9a42
    • antirez's avatar
      Cluster: add sender flags in cluster bus messages header. · 026b9483
      antirez authored
      Sender flags were not propagated for the sender, but only for nodes in
      the gossip section. This is odd and in the next commits we'll need to
      get updated flags for the sender node, so this commit adds a new field
      in the cluster messages header.
      
      The message header is the same size as we reused some free space that
      was marked as 'unused' because of alignment concerns.
      026b9483
  7. 15 Mar, 2013 1 commit
    • antirez's avatar
      Cluster: slaves start failover with a small delay. · 1375b061
      antirez authored
      Redis Cluster can cope with a minority of nodes not informed about the
      failure of a master in time for some reason (netsplit or node not
      functioning properly, blocked, ...) however to wait a few seconds before
      to start the failover will make most "normal" failovers simpler as the
      FAIL message will propagate before the slave election happens.
      1375b061
  8. 14 Mar, 2013 1 commit
  9. 13 Mar, 2013 2 commits
  10. 09 Mar, 2013 1 commit
  11. 08 Mar, 2013 1 commit
  12. 06 Mar, 2013 2 commits
    • antirez's avatar
      Cluster: clusterUpdateState() function simplified. · 3dad8196
      antirez authored
      Also the NEEDHELP Cluster state was removed as it will no longer be
      used by Redis Cluster.
      3dad8196
    • antirez's avatar
      API to lookup commands with their original name. · 7b190a08
      antirez authored
      A new server.orig_commands table was added to the server structure, this
      contains a copy of the commant table unaffected by rename-command
      statements in redis.conf.
      
      A new API lookupCommandOrOriginal() was added that checks both tables,
      new first, old later, so that rewriteClientCommandVector() and friends
      can lookup commands with their new or original name in order to fix the
      client->cmd pointer when the argument vector is renamed.
      
      This fixes the segfault of issue #986, but does not fix a wider range of
      problems resulting from renaming commands that actually operate on data
      and are registered into the AOF file or propagated to slaves... That is
      command renaming should be handled with care.
      7b190a08
  13. 05 Mar, 2013 1 commit
    • antirez's avatar
      Cluster: new node field fail_time. · 1a02b744
      antirez authored
      This is the unix time at which we set the FAIL flag for the node.
      It is only valid if FAIL is set.
      
      The idea is to use it in order to make the cluster more robust, for
      instance in order to revert a FAIL state if it is long-standing but
      still slots are assigned to this node, that is, no one is going to fix
      these slots apparently.
      1a02b744
  14. 04 Mar, 2013 1 commit
  15. 28 Feb, 2013 1 commit
    • antirez's avatar
      Cluster: new field in cluster node structure, "numslots". · 4521115b
      antirez authored
      Before a relatively slow popcount() operation was needed every time we
      needed to get the number of slots served by a given cluster node.
      Now we just need to check an integer that is taken in sync with the
      bitmap.
      4521115b
  16. 27 Feb, 2013 1 commit
  17. 26 Feb, 2013 1 commit
    • antirez's avatar
      Set process name in ps output to make operations safer. · 6356cf68
      antirez authored
      This commit allows Redis to set a process name that includes the binding
      address and the port number in order to make operations simpler.
      
      Redis children processes doing AOF rewrites or RDB saving change the
      name into redis-aof-rewrite and redis-rdb-bgsave respectively.
      
      This in general makes harder to kill the wrong process because of an
      error and makes simpler to identify saving children.
      
      This feature was suggested by Arnaud GRANAL in the Redis Google Group,
      Arnaud also pointed me to the setproctitle.c implementation includeed in
      this commit.
      
      This feature should work on all the Linux, OSX, and all the three major
      BSD systems.
      6356cf68
  18. 25 Feb, 2013 4 commits
  19. 22 Feb, 2013 2 commits
    • antirez's avatar
      Cluster: new state information, cluster size. · d218a4e2
      antirez authored
      The definition of cluster size is: the number of known nodes in the
      cluster that are masters and serving at least an hash slot.
      d218a4e2
    • antirez's avatar
      Cluster: introduced a failure reports system. · 97492977
      antirez authored
      A §Redis Cluster node used to mark a node as failing when itself
      detected a failure for that node, and a single acknowledge was received
      about the possible failure state.
      
      The new API will be used in order to possible to require that N other
      nodes have a PFAIL or FAIL state for a given node for a node to set it
      as failing.
      97492977
  20. 20 Feb, 2013 1 commit
  21. 15 Feb, 2013 1 commit
  22. 14 Feb, 2013 3 commits
  23. 12 Feb, 2013 5 commits
    • antirez's avatar
      dc24a6b1
    • antirez's avatar
    • antirez's avatar
      07888202
    • antirez's avatar
      Use replicationFeedSlaves() to send PING to slaves. · 4b83ad4e
      antirez authored
      A Redis master sends PING commands to slaves from time to time: doing
      this ensures that even if absence of writes, the master->slave channel
      remains active and the slave can feel the master presence, instead of
      closing the connection for timeout.
      
      This commit changes the way PINGs are sent to slaves in order to use the
      standard interface used to replicate all the other commands, that is,
      the function replicationFeedSlaves().
      
      With this change the stream of commands sent to every slave is exactly
      the same regardless of their exact state (Transferring RDB for first
      synchronization or slave already online). With the previous
      implementation the PING was only sent to online slaves, with the result
      that the output stream from master to slaves was not identical for all
      the slaves: this is a problem if we want to implement partial resyncs in
      the future using a global replication stream offset.
      
      TL;DR: this commit should not change the behaviour in practical terms,
      but is just something in preparation for partial resynchronization
      support.
      4b83ad4e
    • antirez's avatar
      Emit SELECT to slaves in a centralized way. · 7465ac7a
      antirez authored
      Before this commit every Redis slave had its own selected database ID
      state. This was not actually useful as the emitted stream of commands
      is identical for all the slaves.
      
      Now the the currently selected database is a global state that is set to
      -1 when a new slave is attached, in order to force the SELECT command to
      be re-emitted for all the slaves.
      
      This change is useful in order to implement replication partial
      resynchronization in the future, as makes sure that the stream of
      commands received by slaves, including SELECT commands, are exactly the
      same for every slave connected, at any time.
      
      In this way we could have a global offset that can identify a specific
      piece of the master -> slaves stream of commands.
      7465ac7a
  24. 08 Feb, 2013 1 commit