1. 04 Apr, 2014 5 commits
  2. 30 Mar, 2014 1 commit
    • antirez's avatar
      String value unsharing refactored into proper function. · 543ede03
      antirez authored
      All the Redis functions that need to modify the string value of a key in
      a destructive way (APPEND, SETBIT, SETRANGE, ...) require to make the
      object unshared (if refcount > 1) and encoded in raw format (if encoding
      is not already REDIS_ENCODING_RAW).
      
      This was cut & pasted many times in multiple places of the code. This
      commit puts the small logic needed into a function called
      dbUnshareStringValue().
      543ede03
  3. 24 Mar, 2014 1 commit
  4. 21 Mar, 2014 1 commit
  5. 20 Mar, 2014 3 commits
    • antirez's avatar
      Fix OBJECT IDLETIME return value converting to seconds. · 6d5790d6
      antirez authored
      estimateObjectIdleTime() returns a value in milliseconds now, so we need
      to scale the output of OBJECT IDLETIME to seconds.
      6d5790d6
    • antirez's avatar
      Obtain LRU clock in a resolution dependent way. · ad6b0f70
      antirez authored
      For testing purposes it is handy to have a very high resolution of the
      LRU clock, so that it is possible to experiment with scripts running in
      just a few seconds how the eviction algorithms works.
      
      This commit allows Redis to use the cached LRU clock, or a value
      computed on demand, depending on the resolution. So normally we have the
      good performance of a precomputed value, and a clock that wraps in many
      days using the normal resolution, but if needed, changing a define will
      switch behavior to an high resolution LRU clock.
      ad6b0f70
    • antirez's avatar
      Specify LRU resolution in milliseconds. · d77e2316
      antirez authored
      d77e2316
  6. 05 Dec, 2013 1 commit
  7. 27 Aug, 2013 3 commits
  8. 28 Jul, 2013 1 commit
    • antirez's avatar
      Remove dead variable bothsds from object.c. · bf56948f
      antirez authored
      Thanks to @run and @badboy for spotting this.
      Triva: clang was not able to provide me a warning about that when
      compiling.
      
      This closes #1024 and #1207, committing the change myself as the pull
      requests no longer apply cleanly after other changes to the same
      function.
      bf56948f
  9. 22 Jul, 2013 1 commit
    • antirez's avatar
      Introduction of a new string encoding: EMBSTR · 894eba07
      antirez authored
      Previously two string encodings were used for string objects:
      
      1) REDIS_ENCODING_RAW: a string object with obj->ptr pointing to an sds
      stirng.
      
      2) REDIS_ENCODING_INT: a string object where the obj->ptr void pointer
      is casted to a long.
      
      This commit introduces a experimental new encoding called
      REDIS_ENCODING_EMBSTR that implements an object represented by an sds
      string that is not modifiable but allocated in the same memory chunk as
      the robj structure itself.
      
      The chunk looks like the following:
      
      +--------------+-----------+------------+--------+----+
      | robj data... | robj->ptr | sds header | string | \0 |
      +--------------+-----+-----+------------+--------+----+
                           |                       ^
                           +-----------------------+
      
      The robj->ptr points to the contiguous sds string data, so the object
      can be manipulated with the same functions used to manipulate plan
      string objects, however we need just on malloc and one free in order to
      allocate or release this kind of objects. Moreover it has better cache
      locality.
      
      This new allocation strategy should benefit both the memory usage and
      the performances. A performance gain between 60 and 70% was observed
      during micro-benchmarks, however there is more work to do to evaluate
      the performance impact and the memory usage behavior.
      894eba07
  10. 16 Jul, 2013 1 commit
    • antirez's avatar
      Make sure that ZADD can accept the full range of double values. · 9d520a7f
      antirez authored
      This fixes issue #1194, that contains many details.
      
      However in short, it was possible for ZADD to not accept as score values
      that was however possible to obtain with multiple calls to ZINCRBY, like
      in the following example:
      
      redis 127.0.0.1:6379> zadd k 2.5e-308 m
      (integer) 1
      redis 127.0.0.1:6379> zincrby k -2.4e-308 m
      "9.9999999999999694e-310"
      redis 127.0.0.1:6379> zscore k m
      "9.9999999999999694e-310"
      redis 127.0.0.1:6379> zadd k 9.9999999999999694e-310 m1
      (error) ERR value is not a valid float
      
      The problem was due to strtod() returning ERANGE in the following case
      specified by POSIX:
      
      "If the correct value would cause an underflow, a value whose magnitude
      is no greater than the smallest normalized positive number in the return
      type shall be returned and errno set to [ERANGE].".
      
      Now instead the returned value is accepted even when ERANGE is returned
      as long as the return value of the function is not negative or positive
      HUGE_VAL or zero.
      9d520a7f
  11. 12 Jul, 2013 1 commit
    • antirez's avatar
      Fixed compareStringObject() and introduced collateStringObject(). · 81e55ec0
      antirez authored
      compareStringObject was not always giving the same result when comparing
      two exact strings, but encoded as integers or as sds strings, since it
      switched to strcmp() when at least one of the strings were not sds
      encoded.
      
      For instance the two strings "123" and "123\x00456", where the first
      string was integer encoded, would result into the old implementation of
      compareStringObject() to return 0 as if the strings were equal, while
      instead the second string is "greater" than the first in a binary
      comparison.
      
      The same compasion, but with "123" encoded as sds string, would instead
      return a value < 0, as it is correct. It is not impossible that the
      above caused some obscure bug, since the comparison was not always
      deterministic, and compareStringObject() is used in the implementation
      of skiplists, hash tables, and so forth.
      
      At the same time, collateStringObject() was introduced by this commit, so
      that can be used by SORT command to return sorted strings usign
      collation instead of binary comparison. See next commit.
      81e55ec0
  12. 28 Jan, 2013 2 commits
  13. 19 Jan, 2013 1 commit
  14. 08 Nov, 2012 1 commit
  15. 02 Apr, 2012 1 commit
  16. 27 Mar, 2012 1 commit
  17. 22 Mar, 2012 2 commits
  18. 03 Jan, 2012 1 commit
  19. 14 Nov, 2011 1 commit
  20. 12 Nov, 2011 1 commit
  21. 08 Nov, 2011 1 commit
  22. 04 Oct, 2011 1 commit
  23. 13 Jul, 2011 1 commit
  24. 25 Jun, 2011 1 commit
  25. 03 Jun, 2011 1 commit
  26. 05 May, 2011 1 commit
  27. 06 Apr, 2011 3 commits
  28. 08 Mar, 2011 1 commit