1. 03 Jan, 2021 4 commits
  2. 02 Jan, 2021 1 commit
  3. 01 Jan, 2021 1 commit
  4. 31 Dec, 2020 1 commit
    • filipe oliveira's avatar
      Add errorstats info section, Add failed_calls and rejected_calls to commandstats (#8217) · 90b9f08e
      filipe oliveira authored
      This Commit pushes forward the observability on overall error statistics and command statistics within redis-server:
      
      It extends INFO COMMANDSTATS to have
      - failed_calls in - so we can keep track of errors that happen from the command itself, broken by command.
      - rejected_calls - so we can keep track of errors that were triggered outside the commmand processing per se
      
      Adds a new section to INFO, named ERRORSTATS that enables keeping track of the different errors that
      occur within redis ( within processCommand and call ) based on the reply Error Prefix ( The first word
      after the "-", up to the first space ).
      
      This commit also fixes RM_ReplyWithError so that it can be correctly identified as an error reply.
      90b9f08e
  5. 30 Dec, 2020 1 commit
  6. 27 Dec, 2020 3 commits
  7. 25 Dec, 2020 3 commits
    • Itamar Haber's avatar
      Adds count to L/RPOP (#8179) · f44186e5
      Itamar Haber authored
      Adds: `L/RPOP <key> [count]`
      
      Implements no. 2 of the following strategies:
      
      1. Loop on listTypePop - this would result in multiple calls for memory freeing and allocating (see https://github.com/redis/redis/pull/8179/commits/769167a079b0e110d28e4a8099dce1ecd45682b5)
      2. Iterate the range to build the reply, then call quickListDelRange - this requires two iterations and **is the current choice**
      3. Refactor quicklist to have a pop variant of quickListDelRange - probably optimal but more complex
      
      Also:
      * There's a historical check for NULL after calling listTypePop that was converted to an assert.
      * This refactors common logic shared between LRANGE and the new form of LPOP/RPOP into addListRangeReply (adds test for b/w compat)
      * Consequently, it may have made sense to have `LRANGE l -1 -2` and `LRANGE l 9 0` be legit and return a reverse reply. Due to historical reasons that would be, however, a breaking change.
      * Added minimal comments to existing commands to adhere to the style, make core dev life easier and get commit karma, naturally.
      f44186e5
    • Itamar Haber's avatar
      e18068d9
    • xhe's avatar
      fix the format · e6c1aeaf
      xhe authored
      
      Signed-off-by: default avatarxhe <xw897002528@gmail.com>
      e6c1aeaf
  8. 24 Dec, 2020 22 commits
  9. 23 Dec, 2020 4 commits
    • Wang Yuan's avatar
      Add semicolon to calls of test_cond() (#8238) · 55abd1c6
      Wang Yuan authored
      55abd1c6
    • sundb's avatar
      58e9c261
    • Yang Bodong's avatar
      Tests: fix the problem that Darwin memory leak detection may fail (#8213) · ee59dc1b
      Yang Bodong authored
      Apparently the "leaks" took reports a different error string about process
      that's not found in each version of MacOS.
      This cause the test suite to fail on some OS versions, since some tests terminate
      the process before looking for leaks.
      Instead of looking at the error string, we now look at the (documented) exit code.
      ee59dc1b
    • Greg Femec's avatar
      Fix random element selection for large hash tables. (#8133) · 266949c7
      Greg Femec authored
      
      
      When a database on a 64 bit build grows past 2^31 keys, the underlying hash table expands to 2^32 buckets. After this point, the algorithms for selecting random elements only return elements from half of the available buckets because they use random() which has a range of 0 to 2^31 - 1. This causes problems for eviction policies which use dictGetSomeKeys or dictGetRandomKey. Over time they cause the hash table to become unbalanced because, while new keys are spread out evenly across all buckets, evictions come from only half of the available buckets. Eventually this half of the table starts to run out of keys and it takes longer and longer to find candidates for eviction. This continues until no more evictions can happen.
      
      This solution addresses this by using a 64 bit PRNG instead of libc random().
      Co-authored-by: default avatarGreg Femec <gfemec@google.com>
      266949c7