1. 04 Sep, 2012 1 commit
    • antirez's avatar
      Scripting: Force SORT BY constant determinism inside SORT itself. · 36741b2c
      antirez authored
      SORT is able to return (faster than when ordering) unordered output if
      the "BY" clause is used with a constant value. However we try to play
      well with scripting requirements of determinism providing always sorted
      outputs when SORT (and other similar commands) are called by Lua
      scripts.
      
      However we used the general mechanism in place in scripting in order to
      reorder SORT output, that is, if the command has the "S" flag set, the
      Lua scripting engine will take an additional step when converting a
      multi bulk reply to Lua value, calling a Lua sorting function.
      
      This is suboptimal as we can do it faster inside SORT itself.
      This is also broken as issue #545 shows us: basically when SORT is used
      with a constant BY, and additionally also GET is used, the Lua scripting
      engine was trying to order the output as a flat array, while it was
      actually a list of key-value pairs.
      
      What we do know is to recognized if the caller of SORT is the Lua client
      (since we can check this using the REDIS_LUA_CLIENT flag). If so, and if
      a "don't sort" condition is triggered by the BY option with a constant
      string, we force the lexicographical sorting.
      
      This commit fixes this bug and improves the performance, and at the same
      time simplifies the implementation. This does not mean I'm smart today,
      it means I was stupid when I committed the original implementation ;)
      36741b2c
  2. 31 Aug, 2012 1 commit
  3. 02 Jun, 2012 1 commit
    • antirez's avatar
      EVAL replication test: less false positives. · 80e808b6
      antirez authored
      wait_for_condition is now used instead of the usual "after 1000" (that
      is the way to sleep in Tcl). This should avoid to find the replica in
      a state where it is loading the RDB in memory, returning -LOADING error.
      
      This test used to fail when running the test over valgrind, due to the
      added latencies.
      80e808b6
  4. 26 Apr, 2012 1 commit
  5. 19 Apr, 2012 1 commit
  6. 18 Apr, 2012 1 commit
  7. 13 Apr, 2012 3 commits
  8. 28 Mar, 2012 1 commit
  9. 01 Feb, 2012 1 commit
  10. 31 Oct, 2011 1 commit
  11. 25 Oct, 2011 2 commits
  12. 20 Oct, 2011 1 commit
  13. 27 Sep, 2011 1 commit
  14. 15 Jul, 2011 2 commits
  15. 25 May, 2011 1 commit