1. 28 Oct, 2020 1 commit
  2. 26 Oct, 2020 1 commit
  3. 20 Oct, 2020 1 commit
  4. 17 Sep, 2020 1 commit
    • Wang Yuan's avatar
      Implement redisAtomic to replace _Atomic C11 builtin (#7707) · 445a4b66
      Wang Yuan authored
      Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
      _Atomic to establish inter-thread synchronization without mutex. But the
      compiler that must supports C11 _Atomic can compile redis code, that brings a
      lot of inconvenience since some common platforms can't support by default such
      as CentOS7, so we want to implement redis atomic type to make it more portable.
      
      We have implemented our atomic variable for redis that only has 'relaxed'
      operations in src/atomicvar.h, so we implement some operations with
      'sequentially-consistent', just like the default behavior of C11 _Atomic that
      can establish inter-thread synchronization. And we replace all uses of C11
      _Atomic with redis atomic variable.
      
      Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
      __sync macros if available, it supports most common platforms, and we will
      detect automatically which feature we use. In Makefile we use a dummy file to
      detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
      code theoretically if your gcc version is not less than 4.1.2(starts to support
      __sync_xxx operations). Otherwise, we remove use mutex fallback to implement
      redis atomic variable for performance and test. You will get compiling errors
      if your compiler doesn't support all features of above.
      
      For cover redis atomic variable tests, we add other CI jobs that build redis on
      CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
      For them, we just install gcc by default in order to cover different compiler
      versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
      
      We restore the feature that we can test redis with Helgrind to find data race
      errors. But you need install Valgrind in the default path configuration firstly
      before running your tests, since we use macros in helgrind.h to tell Helgrind
      inter-thread happens-before relationship explicitly for avoiding false positives.
      Please open an issue on github if you find data race errors relate to this commit.
      
      Unrelated:
      - Fix redefinition of typedef 'RedisModuleUserChangedFunc'
        For some old version compilers, they will report errors or warnings, if we
        re-define function type.
      445a4b66
  5. 25 Aug, 2020 1 commit
  6. 15 Aug, 2020 1 commit
  7. 11 Aug, 2020 1 commit
  8. 08 Aug, 2020 1 commit
  9. 06 Aug, 2020 1 commit
  10. 10 Jul, 2020 1 commit
  11. 19 May, 2020 1 commit
  12. 18 May, 2020 1 commit
  13. 05 May, 2020 1 commit
  14. 04 May, 2020 1 commit
  15. 22 Jul, 2019 1 commit
  16. 05 Jun, 2019 1 commit
  17. 26 Apr, 2019 2 commits
  18. 24 Apr, 2019 1 commit
  19. 08 Apr, 2019 1 commit
  20. 13 Mar, 2019 1 commit
  21. 12 Mar, 2019 1 commit
  22. 08 Mar, 2019 1 commit
  23. 07 Mar, 2019 2 commits
  24. 01 Mar, 2019 12 commits
  25. 26 Feb, 2019 1 commit
  26. 18 Feb, 2019 1 commit
  27. 14 Feb, 2019 1 commit