1. 10 Feb, 2015 9 commits
  2. 03 Feb, 2015 1 commit
  3. 02 Feb, 2015 1 commit
    • mattcollier's avatar
      Update redis-cli.c · 7db39b7f
      mattcollier authored
      Code was adding '\n'  (line 521) to the end of NIL values exlusively making csv output inconsistent.  Removed '\n'
      7db39b7f
  4. 30 Jan, 2015 6 commits
  5. 29 Jan, 2015 8 commits
  6. 22 Jan, 2015 15 commits
    • antirez's avatar
      267f2ec4
    • antirez's avatar
      0232eaac
    • antirez's avatar
      Merge branch 'testing' into 3.0 · c7e31c68
      antirez authored
      c7e31c68
    • antirez's avatar
      Cluster test: when valgrind is enabled, use a larger node-timeout. · 400ae01a
      antirez authored
      Removes some percentage of timing related failures.
      400ae01a
    • antirez's avatar
      Merge branch 'testing' into 3.0 · 096ad2e8
      antirez authored
      096ad2e8
    • antirez's avatar
      The seed must be static in getRandomHexChars(). · 71da1b15
      antirez authored
      71da1b15
    • antirez's avatar
      counter must be static in getRandomHexChars(). · 4e73b305
      antirez authored
      4e73b305
    • antirez's avatar
      getRandomHexChars(): use /dev/urandom just to seed. · b25154a3
      antirez authored
      On Darwin /dev/urandom depletes terribly fast. This is not an issue
      normally, but with Redis Cluster we generate a lot of unique IDs, for
      example during nodes handshakes. Our IDs need just to be unique without
      other strong crypto requirements, so this commit turns the function into
      something that gets a 20 bytes seed from /dev/urandom, and produces the
      rest of the output just using SHA1 in counter mode.
      b25154a3
    • antirez's avatar
      Cluster test initialization: use transaction for reset + set-config-epoch. · 7e41200b
      antirez authored
      Otherwise between the two commands other nodes may contact us making the
      next SET-CONFIG-EPOCH call impossible.
      7e41200b
    • antirez's avatar
      Merge branch 'testing' into 3.0 · 00e76ae8
      antirez authored
      00e76ae8
    • Matt Stancliff's avatar
      Fix cluster migrate memory leak · ebb07a0b
      Matt Stancliff authored
      Fixes valgrind error:
      48 bytes in 1 blocks are definitely lost in loss record 196 of 373
         at 0x4910D3: je_malloc (jemalloc.c:944)
         by 0x42807D: zmalloc (zmalloc.c:125)
         by 0x41FA0D: dictGetIterator (dict.c:543)
         by 0x41FA48: dictGetSafeIterator (dict.c:555)
         by 0x459B73: clusterHandleSlaveMigration (cluster.c:2776)
         by 0x45BF27: clusterCron (cluster.c:3123)
         by 0x423344: serverCron (redis.c:1239)
         by 0x41D6CD: aeProcessEvents (ae.c:311)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
      ebb07a0b
    • Matt Stancliff's avatar
      Fix potential invalid read past end of array · 98faed3a
      Matt Stancliff authored
      If array has N elements, we can't read +1 if we are already at N.
      
      Also, we need to move elements by their storage size in the array,
      not just by individual bytes.
      98faed3a
    • Matt Stancliff's avatar
      Fix cluster reset memory leak · 97ffeb7c
      Matt Stancliff authored
      [maybe] Fixes valgrind errors:
      32 bytes in 4 blocks are definitely lost in loss record 107 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80A9AFC: clusterSetMaster (cluster.c:801)
         by 0x80AEDC9: clusterCommand (cluster.c:3994)
         by 0x80682A5: call (redis.c:2049)
         by 0x8068A20: processCommand (redis.c:2309)
         by 0x8076497: processInputBuffer (networking.c:1143)
         by 0x8073BAF: readQueryFromClient (networking.c:1208)
         by 0x8060E98: aeProcessEvents (ae.c:412)
         by 0x806123B: aeMain (ae.c:455)
         by 0x806C3DB: main (redis.c:3832)
      
      64 bytes in 8 blocks are definitely lost in loss record 143 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80AAB40: clusterProcessPacket (cluster.c:801)
         by 0x80A847F: clusterReadHandler (cluster.c:1975)
         by 0x30000FF: ???
      
      80 bytes in 10 blocks are definitely lost in loss record 148 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80AAB40: clusterProcessPacket (cluster.c:801)
         by 0x80A847F: clusterReadHandler (cluster.c:1975)
         by 0x2FFFFFF: ???
      97ffeb7c
    • Matt Stancliff's avatar
      Fix sending uninitialized bytes · 4a36350d
      Matt Stancliff authored
      Fixes valgrind error:
      Syscall param write(buf) points to uninitialised byte(s)
         at 0x514C35D: ??? (syscall-template.S:81)
         by 0x456B81: clusterWriteHandler (cluster.c:1907)
         by 0x41D596: aeProcessEvents (ae.c:416)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
       Address 0x5f268e2 is 2,274 bytes inside a block of size 8,192 alloc'd
         at 0x4932D1: je_realloc (jemalloc.c:1297)
         by 0x428185: zrealloc (zmalloc.c:162)
         by 0x4269E0: sdsMakeRoomFor.part.0 (sds.c:142)
         by 0x426CD7: sdscatlen (sds.c:251)
         by 0x4579E7: clusterSendMessage (cluster.c:1995)
         by 0x45805A: clusterSendPing (cluster.c:2140)
         by 0x45BB03: clusterCron (cluster.c:2944)
         by 0x423344: serverCron (redis.c:1239)
         by 0x41D6CD: aeProcessEvents (ae.c:311)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
       Uninitialised value was created by a stack allocation
         at 0x457810: nodeUpdateAddressIfNeeded (cluster.c:1236)
      4a36350d
    • antirez's avatar
      Cluster test: wait for port to unbound in kill_instance. · c8f90374
      antirez authored
      Otherwise kill_instance + restart_instance in short succession will
      still find the port busy and will fail.
      c8f90374