1. 29 Nov, 2012 2 commits
    • antirez's avatar
      Introduced the Build ID in INFO and --version output. · 3b71404d
      antirez authored
      The idea is to be able to identify a build in a unique way, so for
      instance after a bug report we can recognize that the build is the one
      of a popular Linux distribution and perform the debugging in the same
      environment.
      3b71404d
    • antirez's avatar
      On crash memory test rewrote so that it actaully works. · cd99c14e
      antirez authored
      1) We no longer test location by location, otherwise the CPU write cache
      completely makes our business useless.
      2) We still need a memory test that operates in steps from the first to
      the last location in order to never hit the cache, but that is still
      able to retain the memory content.
      
      This was tested using a Linux box containing a bad memory module with a
      zingle bit error (always zero).
      
      So the final solution does has an error propagation step that is:
      
      1) Invert bits at every location.
      2) Swap adiacent locations.
      3) Swap adiacent locations again.
      4) Invert bits at every location.
      5) Swap adiacent locations.
      6) Swap adiacent locations again.
      
      Before and after these steps, and after step 4, a CRC64 checksum is computed.
      If the three CRC64 checksums don't match, a memory error was detected.
      cd99c14e
  2. 28 Nov, 2012 3 commits
  3. 22 Nov, 2012 6 commits
    • antirez's avatar
      EVALSHA is now case insensitive. · d0570c96
      antirez authored
      EVALSHA used to crash if the SHA1 was not lowercase (Issue #783).
      Fixed using a case insensitive dictionary type for the sha -> script
      map used for replication of scripts.
      d0570c96
    • antirez's avatar
      Fix integer overflow in zunionInterGenericCommand(). · cc85ed41
      antirez authored
      This fixes issue #761.
      cc85ed41
    • antirez's avatar
      Safer handling of MULTI/EXEC on errors. · 60f9dac6
      antirez authored
      After the transcation starts with a MULIT, the previous behavior was to
      return an error on problems such as maxmemory limit reached. But still
      to execute the transaction with the subset of queued commands on EXEC.
      
      While it is true that the client was able to check for errors
      distinguish QUEUED by an error reply, MULTI/EXEC in most client
      implementations uses pipelining for speed, so all the commands and EXEC
      are sent without caring about replies.
      
      With this change:
      
      1) EXEC fails if at least one command was not queued because of an
      error. The EXECABORT error is used.
      2) A generic error is always reported on EXEC.
      3) The client DISCARDs the MULTI state after a failed EXEC, otherwise
      pipelining multiple transactions would be basically impossible:
      After a failed EXEC the next transaction would be simply queued as
      the tail of the previous transaction.
      60f9dac6
    • antirez's avatar
      Make bio.c threads killable ASAP if needed. · dff1ec4a
      antirez authored
      We use this new bio.c feature in order to stop our I/O threads if there
      is a memory test to do on crash. In this case we don't want anything
      else than the main thread to run, otherwise the other threads may mess
      with the heap and the memory test will report a false positive.
      dff1ec4a
    • antirez's avatar
      Fast memory test on Redis crash. · d4b5c480
      antirez authored
      d4b5c480
    • antirez's avatar
      dd905417
  4. 19 Nov, 2012 2 commits
    • antirez's avatar
      Children creating AOF or RDB files now report memory used by COW. · c342b075
      antirez authored
      Finally Redis is able to report the amount of memory used by
      copy-on-write while saving an RDB or writing an AOF file in background.
      
      Note that this information is currently only logged (at NOTICE level)
      and not shown in INFO because this is less trivial (but surely doable
      with some minor form of interprocess communication).
      
      The reason we can't capture this information on the parent before we
      call wait3() is that the Linux kernel will release the child memory
      ASAP, and only retain the minimal state for the process that is useful
      to report the child termination to the parent.
      
      The COW size is obtained by summing all the Private_Dirty fields found
      in the "smap" file inside the proc filesystem for the process.
      
      All this is Linux specific and is not available on other systems.
      c342b075
    • antirez's avatar
      zmalloc_get_private_dirty() function added (Linux only). · 1d8af607
      antirez authored
      For non Linux systmes it just returns 0.
      
      This function is useful to estimate copy-on-write because of childs
      saving stuff on disk.
      1d8af607
  5. 14 Nov, 2012 1 commit
  6. 12 Nov, 2012 1 commit
    • antirez's avatar
      TTL API change: TTL returns -2 for non existing keys. · 50c41de7
      antirez authored
      The previous behavior was to return -1 if:
      
      1) Existing key but without an expire set.
      2) Non existing key.
      
      Now the second case is handled in a different, and TTL will return -2
      if the key does not exist at all.
      
      PTTL follows the same behavior as well.
      50c41de7
  7. 08 Nov, 2012 1 commit
  8. 06 Nov, 2012 1 commit
    • antirez's avatar
      Type mismatch errors are now prefixed with WRONGTYPE. · 46c5d396
      antirez authored
      So instead to reply with a generic error like:
      
      -ERR ... wrong kind of value ...
      
      now it replies with:
      
      -WRONGTYPE ... wrong kind of value ...
      
      This makes this particular error easy to check without resorting to
      (fragile) pattern matching of the error string (however the error string
      used to be consistent already).
      
      Client libraries should return a specific exeption type for this error.
      
      Most of the commit is about fixing unit tests.
      46c5d396
  9. 02 Nov, 2012 1 commit
  10. 01 Nov, 2012 3 commits
  11. 31 Oct, 2012 1 commit
    • antirez's avatar
      Invert two sides of if expression in SET to avoid a lookup. · 9fab63b3
      antirez authored
      Because of the short circuit behavior of && inverting the two sides of
      the if expression avoids an hash table lookup if the non-EX variant of
      SET is called.
      
      Thanks to Weibin Yao (@yaoweibin on github) for spotting this.
      9fab63b3
  12. 30 Oct, 2012 6 commits
  13. 22 Oct, 2012 7 commits
    • antirez's avatar
      2.7.0 branch created as a fork of 2.6.0. · f7b42b17
      antirez authored
      f7b42b17
    • antirez's avatar
      Redis 2.6.0 · 5eec376c
      antirez authored
      5eec376c
    • antirez's avatar
      A filed called slave_read_only added in INFO output. · 99d7dbe6
      antirez authored
      This was an important information missing from the INFO output in the
      replication section.
      
      It obviously reflects if the slave is read only or not.
      99d7dbe6
    • Greg Hurrell's avatar
      Fix (cosmetic) typos in dict.h · a61705dd
      Greg Hurrell authored
      a61705dd
    • Schuster's avatar
      redis-check-dump now understands dumps produced by Redis 2.6 · 16144589
      Schuster authored
      (Commit message from @antirez as it was missign in the original commits,
      also the patch was modified a bit to still work with 2.4 dumps and to
      avoid if expressions that are always true due to checked types range)
      
      This commit changes redis-check-dump to account for new encodings and
      for the new MSTIME expire format. It also refactors the test for valid
      type into a function.
      
      The code is still compatible with Redis 2.4 generated dumps.
      
      This fixes issue #709.
      16144589
    • antirez's avatar
      Default memory limit for 32bit instanced moved from 3.5 GB to 3 GB. · a25b25f4
      antirez authored
      In some system, notably osx, the 3.5 GB limit was too far and not able
      to prevent a crash for out of memory. The 3 GB limit works better and it
      is still a lot of memory within a 4 GB theorical limit so it's not going
      to bore anyone :-)
      
      This fixes issue #711
      a25b25f4
    • antirez's avatar
      Differentiate SCRIPT KILL error replies. · ab551808
      antirez authored
      When calling SCRIPT KILL currently you can get two errors:
      
      * No script in timeout (busy) state.
      * The script already performed a write.
      
      It is useful to be able to distinguish the two errors, but right now both
      start with "ERR" prefix, so string matching (that is fragile) must be used.
      
      This commit introduces two different prefixes.
      
      -NOTBUSY and -UNKILLABLE respectively to reply with an error when no
      script is busy at the moment, and when the script already executed a
      write operation and can not be killed.
      ab551808
  14. 18 Oct, 2012 1 commit
    • NanXiao's avatar
      Update src/redis-benchmark.c · a03c3270
      NanXiao authored
      The code of current implementation:
      
      if (c->pending == 0) clientDone(c);
      In clientDone function, the c's memory has been freed, then the loop will continue: while(c->pending). The memory of c has been freed now, so c->pending is invalid (c is an invalid pointer now), and this will cause memory dump in some platforams(eg: Solaris).
      
      So I think the code should be modified as:
      if (c->pending == 0)
      {
      clientDone(c);
      break;
      }
      and this will not lead to while(c->pending).
      a03c3270
  15. 16 Oct, 2012 1 commit
    • antirez's avatar
      Fix MULTI / EXEC rendering in MONITOR output. · 21645232
      antirez authored
      Before of this commit it used to be like this:
      
      MULTI
      EXEC
      ... actual commands of the transaction ...
      
      Because after all that is the natural order of things. Transaction
      commands are queued and executed *only after* EXEC is called.
      
      However this makes debugging with MONITOR a mess, so the code was
      modified to provide a coherent output.
      
      What happens is that MULTI is rendered in the MONITOR output as far as
      possible, instead EXEC is propagated only after the transaction is
      executed, or even in the case it fails because of WATCH, so in this case
      you'll simply see:
      
      MULTI
      EXEC
      
      An empty transaction.
      21645232
  16. 11 Oct, 2012 1 commit
  17. 05 Oct, 2012 2 commits
    • antirez's avatar
      Redis 2.6.0 RC8 (2.5.14) · 500dddc2
      antirez authored
      500dddc2
    • antirez's avatar
      Hash function switched to murmurhash2. · 99c3338c
      antirez authored
      The previously used hash function, djbhash, is not secure against
      collision attacks even when the seed is randomized as there are simple
      ways to find seed-independent collisions.
      
      The new hash function appears to be safe (or much harder to exploit at
      least) in this case, and has better distribution.
      
      Better distribution does not always means that's better. For instance in
      a fast benchmark with "DEBUG POPULATE 1000000" I obtained the following
      results:
      
          1.6 seconds with djbhash
          2.0 seconds with murmurhash2
      
      This is due to the fact that djbhash will hash objects that follow the
      pattern `prefix:<id>` and where the id is numerically near, to near
      buckets. This improves the locality.
      
      However in other access patterns with keys that have no relation
      murmurhash2 has some (apparently minimal) speed advantage.
      
      On the other hand a better distribution should significantly
      improve the quality of the distribution of elements returned with
      dictGetRandomKey() that is used in SPOP, SRANDMEMBER, RANDOMKEY, and
      other commands.
      
      Everything considered, and under the suspect that this commit fixes a
      security issue in Redis, we are switching to the new hash function.
      If some serious speed regression will be found in the future we'll be able
      to step back easiliy.
      
      This commit fixes issue #663.
      99c3338c