1. 18 Mar, 2019 3 commits
  2. 14 Mar, 2019 2 commits
  3. 10 Mar, 2019 2 commits
  4. 20 Feb, 2019 1 commit
  5. 31 Jan, 2019 1 commit
  6. 21 Dec, 2018 1 commit
  7. 11 Dec, 2018 4 commits
  8. 14 Nov, 2018 2 commits
  9. 31 Oct, 2018 3 commits
  10. 10 Oct, 2018 3 commits
  11. 03 Aug, 2018 3 commits
    • antirez's avatar
      Really bump version number to 4.0.11. · c7613cf3
      antirez authored
      c7613cf3
    • antirez's avatar
      Set repl_down_since to zero on state change. · 677f7585
      antirez authored
      PR #5081 fixes an "interesting" bug about Redis Cluster failover but in
      general about the updating of repl_down_since, that is used in order to
      count the time a slave was left disconnected from its master.
      
      While the fix provided resolves the specific issue, in general the
      validity of repl_down_since is limited to states that are different
      than the state CONNECTED, and the disconnected time is set when the
      state is DISCONNECTED. However from CONNECTED to other states, the state
      machine must always go to DISCONNECTED first. So it makes sense to set
      the field to zero (since it is meaningless in that context) when the
      state is set to CONNECTED.
      677f7585
    • WuYunlong's avatar
      fix server.repl_down_since resetting, so that slaves could failover · 8c6223f9
      WuYunlong authored
      automatically as expected.
      8c6223f9
  12. 23 Jul, 2018 1 commit
    • Oran Agra's avatar
      fix rare replication stream corruption with disk-based replication · 9535c215
      Oran Agra authored
      The slave sends \n keepalive messages to the master while parsing the rdb,
      and later sends REPLCONF ACK once a second. rarely, the master recives both
      a linefeed char and a REPLCONF in the same read, \n*3\r\n$8\r\nREPLCONF\r\n...
      and it tries to trim two chars (\r\n) from the query buffer,
      trimming the '*' from *3\r\n$8\r\nREPLCONF\r\n...
      
      then the master tries to process a command starting with '3' and replies to
      the slave a bunch of -ERR and one +OK.
      although the slave silently ignores these (prints a log message), this corrupts
      the replication offset at the slave since the slave increases the replication
      offset, and the master did not.
      
      other than the fix in processInlineBuffer, i did several other improvments
      while hunting this very rare bug.
      
      - when redis replies with "unknown command" it includes a portion of the
        arguments, not just the command name. so it would be easier to understand
        what was recived, in my case, on the slave side,  it was -ERR, but
        the "arguments" were the interesting part (containing info on the error).
      - about a year ago i added code in addReplyErrorLength to print the error to
        the log in case of a reply to master (since this string isn't actually
        trasmitted to the master), now changed that block to print a similar log
        message to indicate an error being sent from the master to the slave.
        note that the slave is marked as CLIENT_SLAVE only after PSYNC was received,
        so this will not cause any harm for REPLCONF, and will only indicate problems
        that are gonna corrupt the replication stream anyway.
      - two places were c->reply was emptied, and i wanted to reset sentlen
        this is a precaution (i did not actually see such a problem), since a
        non-zero sentlen will cause corruption to be transmitted on the socket.
      9535c215
  13. 29 Jun, 2018 3 commits
    • zhaozhao.zz's avatar
      fix exists command on slave · 5f1fcc59
      zhaozhao.zz authored
      5f1fcc59
    • antirez's avatar
      Fix infinite loop in dbRandomKey(). · ab145a9f
      antirez authored
      Thanks to @kevinmcgehee for signaling the issue and reasoning about the
      consequences and potential fixes.
      
      Issue #5015.
      ab145a9f
    • antirez's avatar
      Sentinel: add an option to deny online script reconfiguration. · 2fa43ece
      antirez authored
      The ability of "SENTINEL SET" to change the reconfiguration script at
      runtime is a problem even in the security model of Redis: any client
      inside the network may set any executable to be ran once a failover is
      triggered.
      
      This option adds protection for this problem: by default the two
      SENTINEL SET subcommands modifying scripts paths are denied. However the
      user is still able to rever that using the Sentinel configuration file
      in order to allow such a feature.
      2fa43ece
  14. 13 Jun, 2018 2 commits
  15. 01 Jun, 2018 1 commit
  16. 29 May, 2018 8 commits