1. 13 Aug, 2012 2 commits
  2. 03 Aug, 2012 1 commit
    • antirez's avatar
      Sentinel: SENTINEL FAILOVER command implemented. · cada7f96
      antirez authored
      This command can be used in order to force a Sentinel instance to start
      a failover for the specified master, as leader, forcing the failover
      even if the master is up.
      
      The commit also adds some minor refactoring and other improvements to
      functions already implemented that make them able to work when the
      master is not in SDOWN condition. For instance slave selection
      assumed that we ask INFO every second to every slave, this is true
      only when the master is in SDOWN condition, so slave selection did not
      worked when the master was not in SDOWN condition.
      cada7f96
  3. 02 Aug, 2012 3 commits
    • antirez's avatar
      Sentinel: client reconfiguration script execution. · 6275004c
      antirez authored
      This commit adds support to optionally execute a script when one of the
      following events happen:
      
      * The failover starts (with a slave already promoted).
      * The failover ends.
      * The failover is aborted.
      
      The script is called with enough parameters (documented in the example
      sentinel.conf file) to provide information about the old and new ip:port
      pair of the master, the role of the sentinel (leader or observer) and
      the name of the master.
      
      The goal of the script is to inform clients of the configuration change
      in a way specific to the environment Sentinel is running, that can't be
      implemented in a genereal way inside Sentinel itself.
      6275004c
    • Salvatore Sanfilippo's avatar
      Merge pull request #613 from tobstarr/patch-1 · 2990c366
      Salvatore Sanfilippo authored
      Fix version numbers
      2990c366
    • Tobias Schwab's avatar
      Fix version numbers · 2dccf1e4
      Tobias Schwab authored
      2dccf1e4
  4. 31 Jul, 2012 5 commits
    • antirez's avatar
      Sentinel: when leader in wait-start, sense another leader as race. · fd92b366
      antirez authored
      When we are in wait start, if another leader (or any other external
      entity) turns a slave into a master, abort the failover, and detect it
      as an observer.
      
      Note that the wait-start state is mainly there for this reason but the
      abort was yet not implemented.
      
      This adds a new sentinel event -failover-abort-race.
      fd92b366
    • antirez's avatar
    • Michael Parker's avatar
      Use correct variable name for value to convert. · f1d187bb
      Michael Parker authored
      Note by @antirez: this code was never compiled because utils.c lacked the
      float.h include, so we never noticed this variable was mispelled in the
      past.
      
      This should provide a noticeable speed boost when saving certain types
      of databases with many sorted sets inside.
      f1d187bb
    • antirez's avatar
      ed2a691a
    • antirez's avatar
      Sentinel: abort failover when in wait-start if master is back. · 75084e05
      antirez authored
      When we are a Leader Sentinel in wait-start state, starting with this
      commit the failover is aborted if the master returns online.
      
      This improves the way we handle a notable case of net split, that is the
      split between Sentinels and Redis servers, that will be a very common
      case of split becase Sentinels will often be installed in the client's
      network and servers can be in a differnt arm of the network.
      
      When Sentinels and Redis servers are isolated the master is in ODOWN
      condition since the Sentinels can agree about this state, however the
      failover does not start since there are no good slaves to promote (in
      this specific case all the slaves are unreachable).
      
      However when the split is resolved, Sentinels may sense the slave back
      a moment before they sense the master is back, so the failover may start
      without a good reason (since the master is actually working too).
      
      Now this condition is reversible, so the failover will be aborted
      immediately after if the master is detected to be working again, that
      is, not in SDOWN nor in ODOWN condition.
      75084e05
  5. 28 Jul, 2012 5 commits
  6. 27 Jul, 2012 2 commits
  7. 26 Jul, 2012 1 commit
  8. 25 Jul, 2012 8 commits
  9. 24 Jul, 2012 6 commits
    • antirez's avatar
      9e5bef38
    • antirez's avatar
      Prevent a spurious +sdown event on switch. · a23a5b6c
      antirez authored
      When we reset the master we should start with clean timestamps for ping
      replies otherwise we'll detect a spurious +sdown event, because on
      +master-switch event the previous master instance was probably in +sdown
      condition. Since we updated the address we should count time from
      scratch again.
      
      Also this commit makes sure to explicitly reset the count of pending
      commands, now we can do this because of the new way the hiredis link
      is closed.
      a23a5b6c
    • antirez's avatar
      Sentinel: debugging message removed. · d918e6f1
      antirez authored
      d918e6f1
    • antirez's avatar
      Sentinel: changes to connection handling and redirection. · 75fb6e5b
      antirez authored
      We disconnect the Redis instances hiredis link in a more robust way now.
      Also we change the way we perform the redirection for the +switch-master
      event, that is not just an instance reset with an address change.
      
      Using the same system we now implement the +redirect-to-master event
      that is triggered by an instance that is configured to be master but
      found to be a slave at the first INFO reply. In that case we monitor the
      master instead, logging the incident as an event.
      75fb6e5b
    • antirez's avatar
      Sentinel: check that instance still exists in reply callbacks. · 2179c269
      antirez authored
      We can't be sure the instance object still exists when the reply
      callback is called.
      2179c269
    • antirez's avatar
      Sentinel: more robust failover detection as observer. · d876d6fe
      antirez authored
      Sentinel observers detect failover checking if a slave attached to the
      monitored master turns into its replication state from slave to master.
      However while this change may in theory only happen after a SLAVEOF NO
      ONE command, in practie it is very easy to reboot a slave instance with
      a wrong configuration that turns it into a master, especially if it was
      a past master before a successfull failover.
      
      This commit changes the detection policy so that if an instance goes
      from slave to master, but at the same time the runid has changed, we
      sense a reboot, and in that case we don't detect a failover at all.
      
      This commit also introduces the "reboot" sentinel event, that is logged
      at "warning" level (so this will trigger an admin notification).
      
      The commit also fixes a problem in the disconnect handler that assumed
      that the instance object always existed, that is not the case. Now we
      no longer assume that redisAsyncFree() will call the disconnection
      handler before returning.
      d876d6fe
  10. 23 Jul, 2012 3 commits
  11. 22 Jul, 2012 2 commits
    • antirez's avatar
      03f412dd
    • antirez's avatar
      Allow Pub/Sub in contexts where other commands are blocked. · 5d73073f
      antirez authored
      Redis loading data from disk, and a Redis slave disconnected from its
      master with serve-stale-data disabled, are two conditions where
      commands are normally refused by Redis, returning an error.
      
      However there is no reason to disable Pub/Sub commands as well, given
      that this layer does not interact with the dataset. To allow Pub/Sub in
      as many contexts as possible is especially interesting now that Redis
      Sentinel uses Pub/Sub of a Redis master as a communication channel
      between Sentinels.
      
      This commit allows Pub/Sub to be used in the above two contexts where
      it was previously denied.
      5d73073f
  12. 21 Jul, 2012 1 commit
  13. 18 Jul, 2012 1 commit
    • antirez's avatar
      Don't assume that "char" is signed. · b62bdf1c
      antirez authored
      For the C standard char can be either signed or unsigned, it's up to the
      compiler, but Redis assumed that it was signed in a few places.
      
      The practical effect of this patch is that now Redis 2.6 will run
      correctly in every system where char is unsigned, notably the RaspBerry
      PI and other ARM systems with GCC.
      
      Thanks to Georgi Marinov (@eesn on twitter) that reported the problem
      and allowed me to use his RaspBerry via SSH to trace and fix the issue!
      b62bdf1c