1. 27 Jan, 2020 1 commit
  2. 15 Jan, 2020 1 commit
  3. 13 Jan, 2020 5 commits
  4. 10 Jan, 2020 2 commits
  5. 08 Jan, 2020 2 commits
  6. 07 Jan, 2020 4 commits
  7. 06 Jan, 2020 1 commit
  8. 04 Jan, 2020 1 commit
  9. 01 Jan, 2020 2 commits
    • antirez's avatar
      Fix active expire division by zero. · 0af467d1
      antirez authored
      Likely fix #6723.
      
      This is what happens AFAIK: we enter the main loop where we expire stuff
      until a given percentage of keys is still found to be logically expired.
      There are however other potential exit conditions.
      
      However the "sampled" variable is not always incremented inside the
      loop, because we may found no valid slot as we scan the hash table, but
      just NULLs ad dict entries. So when the do/while loop condition is
      triggered at the end, we do (expired*100/sampled), dividing by zero if
      we sampled 0 keys.
      0af467d1
    • John Sully's avatar
      e5565a79
  10. 31 Dec, 2019 2 commits
    • ShooterIT's avatar
      Rename rdb asynchronously · 2bc8db9c
      ShooterIT authored
      2bc8db9c
    • WuYunlong's avatar
      Fix petential cluster link error. · 0992ada2
      WuYunlong authored
      Funcion adjustOpenFilesLimit() has an implicit parameter, which is server.maxclients.
      This function aims to ajust maximum file descriptor number according to server.maxclients
      by best effort, which is "bestlimit" could be lower than "maxfiles" but greater than "oldlimit".
      When we try to increase "maxclients" using CONFIG SET command, we could increase maximum
      file descriptor number to a bigger value without calling aeResizeSetSize the same time.
      When later more and more clients connect to server, the allocated fd could be bigger and bigger,
      and eventually exceeds events size of aeEventLoop.events. When new nodes joins the cluster,
      new link is created, together with new fd, but when calling aeCreateFileEvent, we did not
      check the return value. In this case, we have a non-null "link" but the associated fd is not
      registered.
      
      So when we dynamically set "maxclients" we could reach an inconsistency between maximum file
      descriptor number of the process and server.maxclients. And later could cause cluster link and link
      fd inconsistency.
      
      While setting "maxclients" dynamically, we consider it as failed when resulting "maxclients" is not
      the same as expected. We try to restore back the maximum file descriptor number when we failed to set
      "maxclients" to the specified value, so that server.maxclients could act as a guard as before.
      0992ada2
  11. 30 Dec, 2019 1 commit
    • Guy Benoish's avatar
      Blocking XREAD[GROUP] should always reply with valid data (or timeout) · a351e74f
      Guy Benoish authored
      This commit solves the following bug:
      127.0.0.1:6379> XGROUP CREATE x grp $ MKSTREAM
      OK
      127.0.0.1:6379> XADD x 666 f v
      "666-0"
      127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
      1) 1) "x"
         2) 1) 1) "666-0"
               2) 1) "f"
                  2) "v"
      127.0.0.1:6379> XADD x 667 f v
      "667-0"
      127.0.0.1:6379> XDEL x 667
      (integer) 1
      127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
      1) 1) "x"
         2) (empty array)
      
      The root cause is that we use s->last_id in streamCompareID
      while we should use the last *valid* ID
      a351e74f
  12. 29 Dec, 2019 2 commits
    • antirez's avatar
      Fix duplicated CLIENT SETNAME reply. · 6e4f70b8
      antirez authored
      Happened when we set the name to "" to cancel the name.
      Was introduced during the RESP3 refactoring.
      
      See #6036.
      6e4f70b8
    • antirez's avatar
      Inline protocol: handle empty strings well. · 5521910d
      antirez authored
      This bug is from the first version of Redis. Probably the problem here
      is that before we used an SDS split function that created empty strings
      for additional spaces, like in "SET    foo          bar".
      AFAIK later we replaced it with the curretn sdssplitarg() API that has
      no such a problem. As a result, we introduced a bug, where it is no
      longer possible to do something like:
      
          SET foo ""
      
      Using the inline protocol. Now it is fixed.
      5521910d
  13. 26 Dec, 2019 2 commits
    • Oran Agra's avatar
      config.c adjust config limits and mutable · 0c3fe52e
      Oran Agra authored
      - make lua-replicate-commands mutable (it never was, but i don't see why)
      - make tcp-backlog immutable (fix a recent refactory mistake)
      - increase the max limit of a few configs to match what they were before
      the recent refactory
      0c3fe52e
    • Guy Benoish's avatar
      Stream: Handle streamID-related edge cases · 1f75ce30
      Guy Benoish authored
      This commit solves several edge cases that are related to
      exhausting the streamID limits: We should correctly calculate
      the succeeding streamID instead of blindly incrementing 'seq'
      This affects both XREAD and XADD.
      
      Other (unrelated) changes:
      Reply with a better error message when trying to add an entry
      to a stream that has exhausted last_id
      1f75ce30
  14. 23 Dec, 2019 1 commit
  15. 20 Dec, 2019 1 commit
  16. 18 Dec, 2019 6 commits
  17. 17 Dec, 2019 6 commits