- 21 Jul, 2020 3 commits
- 
- 
Remi Collet authored
- 
Wen Hui authoredSince the dynamic allocations in raxIterator are only used for deep walks, memory leak due to missing call to raxStop can only happen for rax with key names longer than 32 bytes. Out of all the missing calls, the only ones that may lead to a leak are the rax for consumer groups and consumers, and these were only in AOFRW and rdbSave, which normally only happen in fork or at shutdown. 
- 
Wen Hui authored
 
- 
- 20 Jul, 2020 5 commits
- 
- 
zhaozhao.zz authored
- 
WuYunlong authoredBefore this commit, processCommand() did not notice that cmd could be a module command which declared `getkeys-api` and handled it for the purpose of cluster redirect it as if it doesn't use any keys. This commit fixed it by reusing the codes in addReplyCommand(). 
- 
Oran Agra authored
- 
WuYunlong authoredIt will never happen that "lp != NULL && lp_bytes >= server.stream_node_max_bytes". Assume that "lp != NULL && lp_bytes >= server.stream_node_max_bytes", we got the following conditions: a. lp != NULL b. lp_bytes >= server.stream_node_max_bytes If server.stream_node_max_bytes is 0, given condition a, condition b is always satisfied If server.stream_node_max_bytes is not 0, given condition a and condition b, the codes just a few lines above set lp to NULL, a controdiction with condition a So that condition b is recundant. We could delete it safely. 
- 
Scott Brenner authored
 
- 
- 17 Jul, 2020 1 commit
- 
- 
Itamar Haber authoredAdds SHA256SUM to redis-stable tarball upload 
 
- 
- 16 Jul, 2020 4 commits
- 
- 
Itamar Haber authored
- 
Itamar Haber authoredCo-authored-by: Oran Agra <oran@redislabs.com> Co-authored-by: yoav-steinberg <yoav@monfort.co.il> 
- 
yoav-steinberg authoredSpecifically, the key passed to the module aof_rewrite callback is a stack allocated robj. When passing it to RedisModule_EmitAOF (with appropriate "s" fmt string) redis used to panic when trying to inc the ref count of the stack allocated robj. Now support such robjs by coying them to a new heap robj. This doesn't affect performance because using the alternative "c" or "b" format strings also copies the input to a new heap robj. 
- 
杨博东 authored
 
- 
- 15 Jul, 2020 6 commits
- 
- 
Luke Palmer authored
- 
dmurnane authoredCo-authored-by:Daniel Murnane <dmurnane@eitccorp.com> 
- 
Developer-Ecosystem-Engineering authoredExport following environment variables before building on macOS on Apple silicon export ARCH_FLAGS="-arch arm64" export SDK_NAME=macosx export SDK_PATH=$(xcrun --show-sdk-path --sdk $SDK_NAME) export CFLAGS="$ARCH_FLAGS -isysroot $SDK_PATH -I$SDK_PATH/usr/include" export CXXFLAGS=$CFLAGS export LDFLAGS="$ARCH_FLAGS" export CC="$(xcrun -sdk $SDK_PATH --find clang) $CFLAGS" export CXX="$(xcrun -sdk $SDK_PATH --find clang++) $CXXFLAGS" export LD="$(xcrun -sdk $SDK_PATH --find ld) $LDFLAGS" make make test .. All tests passed without errors! Backtrack logging assumes x86 and required updating 
- 
Wen Hui authored
- 
WuYunlong authored
- 
WuYunlong authored
 
- 
- 14 Jul, 2020 3 commits
- 
- 
Oran Agra authoredin case the rdb child failed, crashed or terminated unexpectedly redis would have marked the replica clients with repl_put_online_on_ack and then kill them only after a minute when no ack was received. it would not stream anything to these connections, so the only effect of this bug is a delay of 1 minute in the replicas attempt to re-connect. 
- 
Oran Agra authoredthis test when run with valgrind on github actions takes 160 seconds 
- 
WuYunlong authoredBefore this commit, the output of "./runtest-cluster --help" is incorrect. After this commit, the format of the following 3 output is consistent: ./runtest --help ./runtest-cluster --help ./runtest-sentinel --help 
 
- 
- 13 Jul, 2020 4 commits
- 
- 
Qu Chen authored
- 
Oran Agra authored
- 
Oran Agra authoredinterestingly the latency monitor test fails because valgrind is slow enough so that the time inside PEXPIREAT command from the moment of the first mstime() call to get the basetime until checkAlreadyExpired calls mstime() again is more than 1ms, and that test was too sensitive. using this opportunity to speed up the test (unrelated to the failure) the fix is just the longer time passed to PEXPIRE. 
- 
Oran Agra authoredin the majority of the cases (on this rarely used feature) we want to stop and be able to connect to the shard with redis-cli. since these are two different processes interracting with the tty we need to stop both, and we'll have to hit enter twice, but it's not that bad considering it is rarely used. 
 
- 
- 12 Jul, 2020 1 commit
- 
- 
Oran Agra authored* update daily CI to include cluster and sentinel tests * update daily CI to run when creating a new release * update release scripts to work on the new redis.io hosts 
 
- 
- 11 Jul, 2020 2 commits
- 
- 
jimgreen2013 authored* fix description about ZIP_BIG_PREVLEN(the code is ok), it's similar to antirez#4705 * fix description about ziplist entry encoding field (the code is ok), the max length should be 2^32 - 1 when encoding is 5 bytes 
- 
杨博东 authoredone of the differences (other than consistent code with SORT, GEORADIUS), is that the LFU of the old key is retained. 
 
- 
- 10 Jul, 2020 11 commits
- 
- 
马永泽 authoredCo-authored-by: Oran Agra <oran@redislabs.com> (styling) 
- 
Abhishek Soni authored
- 
Jiayuan Chen authored
- 
WuYunlong authored
- 
Yossi Gottlieb authored* TLS: Session caching configuration support. * TLS: Remove redundant config initialization. 
- 
Yossi Gottlieb authored
- 
James Hilliard authored
- 
Yossi Gottlieb authored* Tests: fix and reintroduce redis-cli tests. These tests have been broken and disabled for 10 years now! * TLS: add remaining redis-cli support. This adds support for the redis-cli --pipe, --rdb and --replica options previously unsupported in --tls mode. * Fix writeConn(). 
- 
Oran Agra authored
- 
Oran Agra authored
- 
Oran Agra authoredSimilarly to EXPIREAT with TTL in the past, which implicitly deletes the key and return success, RESTORE should not store key that are already expired into the db. When used together with REPLACE it should emit a DEL to keyspace notification and replication stream. 
 
-