1. 26 Jul, 2020 1 commit
  2. 24 Jul, 2020 1 commit
  3. 23 Jul, 2020 3 commits
    • Oran Agra's avatar
      Stabilize bgsave test that sometimes fails with valgrind (#7559) · 8a57969f
      Oran Agra authored
      on ci.redis.io the test fails a lot, reporting that bgsave didn't end.
      increaseing the timeout we wait for that bgsave to get aborted.
      in addition to that, i also verify that it indeed got aborted by
      checking that the save counter wasn't reset.
      
      add another test to verify that a successful bgsave indeed resets the
      change counter.
      8a57969f
    • Meir Shpilraien (Spielrein)'s avatar
    • Oran Agra's avatar
      Fix harmless bug in rioConnRead (#7557) · 40d7fca3
      Oran Agra authored
      this code is in use only if the master is disk-based, and the replica is
      diskless. In this case we use a buffered reader, but we must avoid reading
      past the rdb file, into the command stream. which Luckly rdb.c doesn't
      really attempt to do (it knows how much it should read).
      
      When rioConnRead detects that the extra buffering attempt reaches beyond
      the read limit it should read less, but if the caller actually requested
      more, then it should return with an error rather than a short read. the
      bug would have resulted in short read.
      
      in order to fix it, the code must consider the real requested size, and
      not the extra buffering size.
      40d7fca3
  4. 22 Jul, 2020 4 commits
  5. 21 Jul, 2020 7 commits
    • Oran Agra's avatar
      testsuite may leave servers alive on error (#7549) · 36b94943
      Oran Agra authored
      in cases where you have
      test name {
        start_server {
          start_server {
            assert
          }
        }
      }
      
      the exception will be thrown to the test proc, and the servers are
      supposed to be killed on the way out. but it seems there was always a
      bug of not cleaning the server stack, and recently (#7404) we started
      relying on that stack in order to kill them, so with that bug sometimes
      we would have tried to kill the same server twice, and leave one alive.
      
      luckly, in most cases the pattern is:
      start_server {
        test name {
        }
      }
      36b94943
    • Yossi Gottlieb's avatar
      Tests: drop TCL 8.6 dependency. (#7548) · f57e844b
      Yossi Gottlieb authored
      This re-implements the redis-cli --pipe test so it no longer depends on a close feature available only in TCL 8.6.
      
      Basically what this test does is run redis-cli --pipe, generates a bunch of commands and pipes them through redis-cli, and inspects the result in both Redis and the redis-cli output.
      
      To do that, we need to close stdin for redis-cli to indicate we're done so it can flush its buffers and exit. TCL has bi-directional channels can only offers a way to "one-way close" a channel with TCL 8.6. To work around that, we now generate the commands into a file and feed that file to redis-cli directly.
      
      As we're writing to an actual file, the number of commands is now reduced.
      f57e844b
    • Oran Agra's avatar
      Fixes to release scripts (#7547) · 343dd9bc
      Oran Agra authored
      343dd9bc
    • WuYunlong's avatar
      Clarification on the bug that was fixed in PR #7539. (#7541) · f7f77a74
      WuYunlong authored
      Before that PR, processCommand() did not notice that cmd could be a module
      command in which case getkeys_proc member has a different meaning.
      
      The outcome was that a module command which doesn't take any key names in its
      arguments (similar to SLOWLOG) would be handled as if it might have key name arguments
      (similar to MEMORY), would consider cluster redirect but will end up with 0 keys
      after an excessive call to getKeysFromCommand, and eventually do the right thing.
      f7f77a74
    • Remi Collet's avatar
      Fix deprecated tail syntax in tests (#7543) · 3f2fbc4c
      Remi Collet authored
      3f2fbc4c
    • Wen Hui's avatar
      Add missing calls to raxStop (#7532) · 4e8f2d68
      Wen Hui authored
      Since the dynamic allocations in raxIterator are only used for deep walks, memory
      leak due to missing call to raxStop can only happen for rax with key names longer
      than 32 bytes.
      
      Out of all the missing calls, the only ones that may lead to a leak are the rax
      for consumer groups and consumers, and these were only in AOFRW and rdbSave, which
      normally only happen in fork or at shutdown.
      4e8f2d68
    • Wen Hui's avatar
      2fbd0271
  6. 20 Jul, 2020 5 commits
  7. 17 Jul, 2020 1 commit
  8. 16 Jul, 2020 4 commits
  9. 15 Jul, 2020 6 commits
  10. 14 Jul, 2020 3 commits
    • Oran Agra's avatar
      diskless master disconnect replicas when rdb child failed (#7518) · a176cb56
      Oran Agra authored
      in case the rdb child failed, crashed or terminated unexpectedly redis
      would have marked the replica clients with repl_put_online_on_ack and
      then kill them only after a minute when no ack was received.
      
      it would not stream anything to these connections, so the only effect of
      this bug is a delay of 1 minute in the replicas attempt to re-connect.
      a176cb56
    • Oran Agra's avatar
      redis-cli tests, fix valgrind timing issue (#7519) · 254c9625
      Oran Agra authored
      this test when run with valgrind on github actions takes 160 seconds
      254c9625
    • WuYunlong's avatar
      Fix out of update help info in tcl tests. (#7516) · 8128d397
      WuYunlong authored
      Before this commit, the output of "./runtest-cluster --help" is incorrect.
      After this commit, the format of the following 3 output is consistent:
      ./runtest --help
      ./runtest-cluster --help
      ./runtest-sentinel --help
      8128d397
  11. 13 Jul, 2020 4 commits
  12. 12 Jul, 2020 1 commit