1. 18 Jul, 2014 3 commits
    • antirez's avatar
      LATENCY SAMPLES implemented. · 41c9d1c0
      antirez authored
      41c9d1c0
    • antirez's avatar
      Latency monitor: collect slow commands. · 44cf7395
      antirez authored
      We introduce the distinction between slow and fast commands since those
      are two different sources of latency. An O(1) or O(log N) command without
      side effects (can't trigger deletion of large objects as a side effect of
      its execution) if delayed is a symptom of inherent latency of the system.
      
      A non-fast command (commands that may run large O(N) computations) if
      delayed may just mean that the user is executing slow operations.
      
      The advices LATENCY should provide in this two different cases are
      different, so we log the two classes of commands in a separated way.
      44cf7395
    • antirez's avatar
      Latency monitor: basic samples collection. · 62ca4bd4
      antirez authored
      62ca4bd4
  2. 27 Jun, 2014 6 commits
    • antirez's avatar
      DEBUG CMDKEYS moved to COMMAND GETKEYS. · b18c92b9
      antirez authored
      b18c92b9
    • antirez's avatar
      COMMAND COUNT subcommand added. · d3f43db2
      antirez authored
      d3f43db2
    • antirez's avatar
      COMMAND: fix argument parsing. · b2051198
      antirez authored
      This fixes detection of wrong subcommand (that resulted in the default
      all-commands output instead) and allows COMMAND INFO to be called
      without arguments (resulting into an empty array) which is useful in
      programmtically generated calls like the following (in Ruby):
      
          redis.commands("command","info",*mycommands)
      
      Note: mycommands may be empty.
      b2051198
    • antirez's avatar
      COMMANDS command renamed COMMAND. · 3364b2d1
      antirez authored
      3364b2d1
    • antirez's avatar
      COMMANDS command: remove static + aesthetic changes. · 0aab8eb1
      antirez authored
      Static was removed since it is needed in order to get symbols in stack
      traces. Minor changes in the source code were operated to make it more
      similar to the existing Redis code base.
      0aab8eb1
    • Matt Stancliff's avatar
      Cluster: Add COMMANDS command · 60d62a99
      Matt Stancliff authored
      COMMANDS returns a nested multibulk reply for each
      command in the command table.  The reply for each
      command contains:
        - command name
        - arity
        - array of command flags
        - start key position
        - end key position
        - key offset step
        - optional: if the keys are not deterministic and
          Redis uses an internal key evaluation function,
          the 6th field appears and is defined as a status
          reply of: REQUIRES ARGUMENT PARSING
      
      Cluster clients need to know where the keys are in each
      command to implement proper routing to cluster nodes.
      
      Redis commands can have multiple keys, keys at offset steps, or other
      issues where you can't always assume the first element after
      the command name is the cluster routing key.
      
      Using the information exposed by COMMANDS, client implementations
      can have live, accurate key extraction details for all commands.
      
      Also implements COMMANDS INFO [commands...] to return only a
      specific set of commands instead of all 160+ commands live in Redis.
      60d62a99
  3. 26 Jun, 2014 1 commit
  4. 23 Jun, 2014 1 commit
  5. 21 Jun, 2014 4 commits
    • antirez's avatar
      Allow to call ROLE in LOADING state. · 82caeee1
      antirez authored
      82caeee1
    • antirez's avatar
      Assign an unique non-repeating ID to each new client. · b7dd4518
      antirez authored
      This will be used by CLIENT KILL and is also a good way to ensure a
      given client is still the same across CLIENT LIST calls.
      
      The output of CLIENT LIST was modified to include the new ID, but this
      change is considered to be backward compatible as the API does not imply
      you can do positional parsing, since each filed as a different name.
      b7dd4518
    • antirez's avatar
      Client types generalized. · d97d1a64
      antirez authored
      Because of output buffer limits Redis internals had this idea of type of
      clients: normal, pubsub, slave. It is possible to set different output
      buffer limits for the three kinds of clients.
      
      However all the macros and API were named after output buffer limit
      classes, while the idea of a client type is a generic one that can be
      reused.
      
      This commit does two things:
      
      1) Rename the API and defines with more general names.
      2) Change the class of clients executing the MONITOR command from "slave"
         to "normal".
      
      "2" is a good idea because you want to have very special settings for
      slaves, that are not a good idea for MONITOR clients that are instead
      normal clients even if they are conceptually slave-alike (since it is a
      push protocol).
      
      The backward-compatibility breakage resulting from "2" is considered to
      be minimal to care, since MONITOR is a debugging command, and because
      anyway this change is not going to break the format or the behavior, but
      just when a connection is closed on big output buffer issues.
      d97d1a64
    • antirez's avatar
      ROLE command added. · 9b460e80
      antirez authored
      The new ROLE command is designed in order to provide a client with
      informations about the replication in a fast and easy to use way
      compared to the INFO command where the same information is also
      available.
      9b460e80
  6. 05 Jun, 2014 1 commit
  7. 23 May, 2014 3 commits
  8. 12 May, 2014 1 commit
  9. 28 Apr, 2014 1 commit
    • antirez's avatar
      Accept multiple clients per iteration. · 357b039f
      antirez authored
      When the listening sockets readable event is fired, we have the chance
      to accept multiple clients instead of accepting a single one. This makes
      Redis more responsive when there is a mass-connect event (for example
      after the server startup), and in workloads where a connect-disconnect
      pattern is used often, so that multiple clients are waiting to be
      accepted continuously.
      
      As a side effect, this commit makes the LOADING, BUSY, and similar
      errors much faster to deliver to the client, making Redis more
      responsive when there is to return errors to inform the clients that the
      server is blocked in an not interruptible operation.
      357b039f
  10. 18 Apr, 2014 2 commits
  11. 16 Apr, 2014 13 commits
  12. 25 Mar, 2014 4 commits
    • antirez's avatar
      Fix off by one bug in freeMemoryIfNeeded() eviction pool. · 046e691a
      antirez authored
      Bug found by the continuous integration test running the Redis
      with valgrind:
      
      ==6245== Invalid read of size 8
      ==6245==    at 0x4C2DEEF: memcpy@GLIBC_2.2.5 (mc_replace_strmem.c:876)
      ==6245==    by 0x41F9E6: freeMemoryIfNeeded (redis.c:3010)
      ==6245==    by 0x41D2CC: processCommand (redis.c:2069)
      
      memmove() size argument was accounting for an extra element, going
      outside the bounds of the array.
      046e691a
    • antirez's avatar
      adjustOpenFilesLimit() refactoring. · c69c40a4
      antirez authored
      In this commit:
      * Decrement steps are semantically differentiated from the reserved FDs.
        Previously both values were 32 but the meaning was different.
      * Make it clear that we save setrlimit errno.
      * Don't explicitly handle wrapping of 'f', but prevent it from
        happening.
      * Add comments to make the function flow more readable.
      
      This integrates PR #1630
      c69c40a4
    • Matt Stancliff's avatar
      Fix potentially incorrect errno usage · b2a02cc9
      Matt Stancliff authored
      errno may be reset by the previous call to redisLog, so capture
      the original value for proper error reporting.
      b2a02cc9
    • Matt Stancliff's avatar
      Add REDIS_MIN_RESERVED_FDS define for open fds · 01fe750c
      Matt Stancliff authored
      Also update the original REDIS_EVENTLOOP_FDSET_INCR to
      include REDIS_MIN_RESERVED_FDS. REDIS_EVENTLOOP_FDSET_INCR
      exists to make sure more than (maxclients+RESERVED) entries
      are allocated, but we can only guarantee that if we include
      the current value of REDIS_MIN_RESERVED_FDS as a minimum
      for the INCR size.
      01fe750c