1. 15 Mar, 2019 1 commit
  2. 12 Mar, 2019 1 commit
  3. 08 Mar, 2019 1 commit
    • Steve Webster's avatar
      Increment delivery counter on XCLAIM unless RETRYCOUNT specified · f1e7df4b
      Steve Webster authored
      The XCLAIM docs state the XCLAIM increments the delivery counter for
      messages. This PR makes the code match the documentation - which seems
      like the desired behaviour - whilst still allowing RETRYCOUNT to be
      specified manually.
      
      My understanding of the way streamPropagateXCLAIM() works is that this
      change will safely propagate to replicas since retry count is pulled
      directly from the streamNACK struct.
      
      Fixes #5194
      f1e7df4b
  4. 30 Jan, 2019 1 commit
  5. 28 Jan, 2019 6 commits
  6. 18 Jan, 2019 1 commit
  7. 17 Jan, 2019 1 commit
  8. 28 Nov, 2018 1 commit
  9. 19 Nov, 2018 2 commits
  10. 12 Nov, 2018 1 commit
  11. 17 Oct, 2018 1 commit
  12. 16 Oct, 2018 2 commits
  13. 13 Oct, 2018 1 commit
  14. 10 Oct, 2018 2 commits
  15. 09 Oct, 2018 2 commits
  16. 30 Sep, 2018 1 commit
  17. 11 Sep, 2018 1 commit
  18. 05 Sep, 2018 1 commit
  19. 21 Aug, 2018 1 commit
    • Oran Agra's avatar
      Fix unstable tests on slow machines. · c8452ab0
      Oran Agra authored
      Few tests had borderline thresholds that were adjusted.
      
      The slave buffers test had two issues, preventing the slave buffer from growing:
      1) the slave didn't necessarily go to sleep on time, or woke up too early,
         now using SIGSTOP to make sure it goes to sleep exactly when we want.
      2) the master disconnected the slave on timeout
      c8452ab0
  20. 13 Aug, 2018 1 commit
  21. 02 Aug, 2018 1 commit
    • antirez's avatar
      Test: new sorted set skiplist order consistency. · d506334b
      antirez authored
      This should be able to find new bugs and regressions about the new
      sorted set update function when ZADD is used to update an element
      already existing.
      
      The test is able to find the bug fixed at 2f282aee immediately.
      d506334b
  22. 01 Aug, 2018 1 commit
  23. 24 Jul, 2018 1 commit
    • Oran Agra's avatar
      fix slave buffer test suite false positives · d4ae76d1
      Oran Agra authored
      it looks like on slow machines we're getting:
      [err]: slave buffer are counted correctly in tests/unit/maxmemory.tcl
      Expected condition '$slave_buf > 2*1024*1024' to be true (16914 > 2*1024*1024)
      
      this is a result of the slave waking up too early and eating the
      slave buffer before the traffic and the test ends.
      d4ae76d1
  24. 18 Jul, 2018 1 commit
    • Oran Agra's avatar
      make active defrag test more stable · f89c93c8
      Oran Agra authored
      on slower machines, the active defrag test tended to fail.
      although the fragmentation ratio was below the treshold, the defragger was
      still in the middle of a scan cycle.
      
      this commit changes:
      - the defragger uses the current fragmentation state, rather than the cache one
        that is updated by server cron every 100ms. this actually fixes a bug of
        starting one excess scan cycle
      - the test lets the defragger use more CPU cycles, in hope that the defrag
        will be faster, but also give it more time before we give up.
      f89c93c8
  25. 16 Jul, 2018 1 commit
    • Oran Agra's avatar
      slave buffers were wasteful and incorrectly counted causing eviction · bf680b6f
      Oran Agra authored
      A) slave buffers didn't count internal fragmentation and sds unused space,
         this caused them to induce eviction although we didn't mean for it.
      
      B) slave buffers were consuming about twice the memory of what they actually needed.
      - this was mainly due to sdsMakeRoomFor growing to twice as much as needed each time
        but networking.c not storing more than 16k (partially fixed recently in 237a38737).
      - besides it wasn't able to store half of the new string into one buffer and the
        other half into the next (so the above mentioned fix helped mainly for small items).
      - lastly, the sds buffers had up to 30% internal fragmentation that was wasted,
        consumed but not used.
      
      C) inefficient performance due to starting from a small string and reallocing many times.
      
      what i changed:
      - creating dedicated buffers for reply list, counting their size with zmalloc_size
      - when creating a new reply node from, preallocate it to at least 16k.
      - when appending a new reply to the buffer, first fill all the unused space of the
        previous node before starting a new one.
      
      other changes:
      - expose mem_not_counted_for_evict info field for the benefit of the test suite
      - add a test to make sure slave buffers are counted correctly and that they don't cause eviction
      bf680b6f
  26. 13 Jul, 2018 4 commits
  27. 12 Jul, 2018 1 commit
  28. 03 Jul, 2018 1 commit